cc: Switch it to use DISALLOW_COPY_AND_ASSIGN macro from base/ library.

cc: Switch it to use DISALLOW_COPY_AND_ASSIGN macro from base/ library.

BUG=144577
R=jamesr@chromium.org

Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=159356

[tfarina, 2012-09-28 20:32:25]

please, take a look.

[jamesr, 2012-09-28 20:37:06]

lgtm. thanks!

http://codereview.chromium.org/10985088/diff/1/cc/CCLayerTreeHost.h
File cc/CCLayerTreeHost.h (right):

http://codereview.chromium.org/10985088/diff/1/cc/CCLayerTreeHost.h#newcode9
cc/CCLayerTreeHost.h:9: #include "cc/own_ptr_vector.h"
hmm, chromium does a case-insensitive sort? I normally just bulk select all the
#includes and run 'sort' in vim, which puts lowercase after uppercase.

http://codereview.chromium.org/10985088/diff/1/cc/CCSchedulerStateMachine.h
File cc/CCSchedulerStateMachine.h (right):

http://codereview.chromium.org/10985088/diff/1/cc/CCSchedulerStateMachine.h#n...
cc/CCSchedulerStateMachine.h:22: class CCSchedulerStateMachine {
this class should be noncopyable as well

[tfarina, 2012-09-28 20:48:04]

http://codereview.chromium.org/10985088/diff/1/cc/CCLayerTreeHost.h
File cc/CCLayerTreeHost.h (right):

http://codereview.chromium.org/10985088/diff/1/cc/CCLayerTreeHost.h#newcode9
cc/CCLayerTreeHost.h:9: #include "cc/own_ptr_vector.h"
On 2012/09/28 20:37:06, jamesr wrote:
> hmm, chromium does a case-insensitive sort? I normally just bulk select all
the
> #includes and run 'sort' in vim, which puts lowercase after uppercase.

for me vim sort puts own_ptr_vector.h at line 14, which I think looks pretty
ugly.

./tool/sort-headers.py recommends that order, plus moving wtf and limits above.

Personally I think lowercase before UpperCase easy to find/read.

http://codereview.chromium.org/10985088/diff/1/cc/CCSchedulerStateMachine.h
File cc/CCSchedulerStateMachine.h (right):

http://codereview.chromium.org/10985088/diff/1/cc/CCSchedulerStateMachine.h#n...
cc/CCSchedulerStateMachine.h:22: class CCSchedulerStateMachine {
On 2012/09/28 20:37:06, jamesr wrote:
> this class should be noncopyable as well

Done.

[jamesr, 2012-09-28 20:52:47]

OK, that's fine.  We'll be renaming these all to lowercase to match the rest of
chromium in a few weeks anyway (we don't want to do renames yet since we might
need to merge things to the m23 release branch and drover can't handle renames).