Add desktop type context to most existing instances of FindTabbedBrowser.

Add desktop type context to most existing instances of FindTabbedBrowser.

BUG=129187
TEST=NONE

Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=160039

[Ben Goodger (Google), 2012-10-03 19:16:56]

lgtm

http://codereview.chromium.org/10967003/diff/42047/chrome/browser/profiles/pr...
File chrome/browser/profiles/profile_manager.cc (right):

http://codereview.chromium.org/10967003/diff/42047/chrome/browser/profiles/pr...
chrome/browser/profiles/profile_manager.cc:933: chrome::HostDesktopType
desktop_type) {
it's unfortunate to have ProfileManager have to know about HDT. To me this
implies a layering violation in this code. Not your fault. But it seems like if
this gesture originates in UI-land, PM should have a notification/observer
whatever back to UI-land saying that the operation completed with N params and
do with this info as you wish. Then ui-land could open the new window. WDYT? Can
you file a bug/drop a comment here to that effect?

http://codereview.chromium.org/10967003/diff/42047/chrome/browser/task_manage...
File chrome/browser/task_manager/task_manager.cc (right):

http://codereview.chromium.org/10967003/diff/42047/chrome/browser/task_manage...
chrome/browser/task_manager/task_manager.cc:1245: model_->AddResource(resource);
indent off

http://codereview.chromium.org/10967003/diff/42047/chrome/browser/ui/webui/op...
File chrome/browser/ui/webui/options/manage_profile_handler.cc (right):

http://codereview.chromium.org/10967003/diff/42047/chrome/browser/ui/webui/op...
chrome/browser/ui/webui/options/manage_profile_handler.cc:263: if (browser) {
nit: no braces

[robertshield, 2012-10-03 19:58:16]

Thanks, nits addressed. +CC kaiwang for check_deps heads up.

http://codereview.chromium.org/10967003/diff/42047/chrome/browser/profiles/pr...
File chrome/browser/profiles/profile_manager.cc (right):

http://codereview.chromium.org/10967003/diff/42047/chrome/browser/profiles/pr...
chrome/browser/profiles/profile_manager.cc:933: chrome::HostDesktopType
desktop_type) {
On 2012/10/03 19:16:56, Ben Goodger (Google) wrote:
> it's unfortunate to have ProfileManager have to know about HDT. To me this
> implies a layering violation in this code. Not your fault. But it seems like
if
> this gesture originates in UI-land, PM should have a notification/observer
> whatever back to UI-land saying that the operation completed with N params and
> do with this info as you wish. Then ui-land could open the new window. WDYT? 

Yeah, that would be much better. ProfileManager really shouldn't be opening
windows. Filed a bug at http://crbug.com/153864 to move
OnOpenWindowForNewProfile out of here.

> you file a bug/drop a comment here to that effect?

http://codereview.chromium.org/10967003/diff/42047/chrome/browser/task_manage...
File chrome/browser/task_manager/task_manager.cc (right):

http://codereview.chromium.org/10967003/diff/42047/chrome/browser/task_manage...
chrome/browser/task_manager/task_manager.cc:1245: model_->AddResource(resource);
On 2012/10/03 19:16:56, Ben Goodger (Google) wrote:
> indent off

Done.

http://codereview.chromium.org/10967003/diff/42047/chrome/browser/ui/webui/op...
File chrome/browser/ui/webui/options/manage_profile_handler.cc (right):

http://codereview.chromium.org/10967003/diff/42047/chrome/browser/ui/webui/op...
chrome/browser/ui/webui/options/manage_profile_handler.cc:263: if (browser) {
On 2012/10/03 19:16:56, Ben Goodger (Google) wrote:
> nit: no braces

Done.

[commit-bot: I haz the power, 2012-10-04 00:33:01]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/robertshield@chromium.org/10967003/47010

[commit-bot: I haz the power, 2012-10-04 00:33:21]

Presubmit check for 10967003-47010 failed and returned exit status 1.


Running presubmit commit checks ...

** Presubmit Messages **
You added one or more #includes of files that are temporarily
allowed but being removed. Can you avoid introducing the
#include? See relevant DEPS file(s) for details and contacts.
  chrome/browser/bookmarks/bookmark_browsertest.cc
      Illegal include: "chrome/browser/ui/host_desktop.h"
    Because of "!chrome/browser/ui/host_desktop.h" from
chrome/browser/bookmarks's specific_include_rules. \
  chrome/browser/download/download_browsertest.cc
      Illegal include: "chrome/browser/ui/host_desktop.h"
    Because of "!chrome/browser/ui/host_desktop.h" from
chrome/browser/bookmarks's specific_include_rules. \
  chrome/browser/profiles/profile_manager_browsertest.cc
      Illegal include: "chrome/browser/ui/host_desktop.h"
    Because of "!chrome/browser/ui/host_desktop.h" from
chrome/browser/bookmarks's specific_include_rules.

** Presubmit ERRORS **
Banned functions were used.
    chrome/browser/captive_portal/captive_portal_browsertest.cc:2060:
      This function is deprecated and we're working on removing it. Pass
      more context to get a Browser*, like a WebContents, window, or session
      id. Talk to ben@ or jam@ for more information.
    chrome/browser/captive_portal/captive_portal_browsertest.cc:2090:
      This function is deprecated and we're working on removing it. Pass
      more context to get a Browser*, like a WebContents, window, or session
      id. Talk to ben@ or jam@ for more information.
    chrome/browser/chromeos/enrollment_dialog_view.cc:114:
      This function is deprecated and we're working on removing it. Pass
      more context to get a Browser*, like a WebContents, window, or session
      id. Talk to ben@ or jam@ for more information.
    chrome/browser/chromeos/extensions/file_manager_util.cc:223:
      This function is deprecated and we're working on removing it. Pass
      more context to get a Browser*, like a WebContents, window, or session
      id. Talk to ben@ or jam@ for more information.
    chrome/browser/chromeos/locale_change_guard.cc:86:
      This function is deprecated and we're working on removing it. Pass
      more context to get a Browser*, like a WebContents, window, or session
      id. Talk to ben@ or jam@ for more information.
    chrome/browser/profiles/profile_manager.cc:523:
      This function is deprecated and we're working on removing it. Pass
      more context to get a Browser*, like a WebContents, window, or session
      id. Talk to ben@ or jam@ for more information.
    chrome/browser/protector/settings_change_global_error.cc:107:
      This function is deprecated and we're working on removing it. Pass
      more context to get a Browser*, like a WebContents, window, or session
      id. Talk to ben@ or jam@ for more information.
    chrome/browser/ui/browser_commands.cc:440:
      This function is deprecated and we're working on removing it. Pass
      more context to get a Browser*, like a WebContents, window, or session
      id. Talk to ben@ or jam@ for more information.
    chrome/browser/ui/browser_navigator.cc:59:
      This function is deprecated and we're working on removing it. Pass
      more context to get a Browser*, like a WebContents, window, or session
      id. Talk to ben@ or jam@ for more information.
    chrome/browser/ui/browser_navigator.cc:90:
      This function is deprecated and we're working on removing it. Pass
      more context to get a Browser*, like a WebContents, window, or session
      id. Talk to ben@ or jam@ for more information.
    chrome/browser/ui/browser_win.cc:29:
      This function is deprecated and we're working on removing it. Pass
      more context to get a Browser*, like a WebContents, window, or session
      id. Talk to ben@ or jam@ for more information.
    chrome/browser/ui/cocoa/bookmarks/bookmark_menu_cocoa_controller.mm:97:
      This function is deprecated and we're working on removing it. Pass
      more context to get a Browser*, like a WebContents, window, or session
      id. Talk to ben@ or jam@ for more information.
    chrome/browser/ui/cocoa/bookmarks/bookmark_menu_cocoa_controller.mm:119:
      This function is deprecated and we're working on removing it. Pass
      more context to get a Browser*, like a WebContents, window, or session
      id. Talk to ben@ or jam@ for more information.
    chrome/browser/ui/cocoa/history_menu_cocoa_controller.mm:43:
      This function is deprecated and we're working on removing it. Pass
      more context to get a Browser*, like a WebContents, window, or session
      id. Talk to ben@ or jam@ for more information.
    chrome/browser/ui/views/ash/balloon_collection_impl_ash.cc:72:
      This function is deprecated and we're working on removing it. Pass
      more context to get a Browser*, like a WebContents, window, or session
      id. Talk to ben@ or jam@ for more information.
   
chrome/browser/ui/views/bookmarks/bookmark_context_menu_controller_views_win.cc:125:
      This function is deprecated and we're working on removing it. Pass
      more context to get a Browser*, like a WebContents, window, or session
      id. Talk to ben@ or jam@ for more information.
    chrome/browser/ui/views/tab_contents/render_view_context_menu_win.cc:62:
      This function is deprecated and we're working on removing it. Pass
      more context to get a Browser*, like a WebContents, window, or session
      id. Talk to ben@ or jam@ for more information.
    chrome/browser/ui/webui/chrome_web_contents_handler.cc:48:
      This function is deprecated and we're working on removing it. Pass
      more context to get a Browser*, like a WebContents, window, or session
      id. Talk to ben@ or jam@ for more information.
    chrome/browser/ui/webui/chrome_web_contents_handler.cc:99:
      This function is deprecated and we're working on removing it. Pass
      more context to get a Browser*, like a WebContents, window, or session
      id. Talk to ben@ or jam@ for more information.

Presubmit checks took 3.2s to calculate.