chrome/browser/bookmarks/DEPS - Issue 10967003: Add desktop type context to most existing instances of FindTabbedBrowser.

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Side by Side Diff: chrome/browser/bookmarks/DEPS

Issue 10967003: Add desktop type context to most existing instances of FindTabbedBrowser. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: Moving check_deps exception to specific_include_rules after chat with Kai. Created 8 years, 2 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View unified diff | Download patch | Annotate | Revision Log

« no previous file with comments | « chrome/browser/automation/testing_automation_provider.cc ('k') | chrome/browser/bookmarks/bookmark_browsertest.cc » ('j') | no next file with comments »

OLD	NEW
1 include_rules = [	1 include_rules = [

2 # Bookmarks is being made into a Browser Component, so we have these	2 # Bookmarks is being made into a Browser Component, so we have these

3 # two basic rules followed by temporary exceptions. Please don't	3 # two basic rules followed by temporary exceptions. Please don't

4 # add to the list of exceptions!	4 # add to the list of exceptions!

5 "-chrome/browser",	5 "-chrome/browser",

6 "+chrome/browser/api",	6 "+chrome/browser/api",

7 "+chrome/browser/bookmarks",	7 "+chrome/browser/bookmarks",

8 "+chrome/browser/common",	8 "+chrome/browser/common",

9	9

10 # TODO(kaiwang): Bring this list to zero.	10 # TODO(kaiwang): Bring this list to zero.

(...skipping 40 matching lines...) Expand 10 before \| Expand all \| Expand 10 after Loading...
51 # TODO(kaiwang): Bring this list to zero.	51 # TODO(kaiwang): Bring this list to zero.

52 # Do not add to the list of temporarily-allowed dependencies below,	52 # Do not add to the list of temporarily-allowed dependencies below,

53 # and please do not introduce more #includes of these files.	53 # and please do not introduce more #includes of these files.

54 '._[a-z]test\.cc': [	54 '._[a-z]test\.cc': [

55 "!chrome/browser/browser_process.h",	55 "!chrome/browser/browser_process.h",

56 "!chrome/browser/extensions/extension_apitest.h",	56 "!chrome/browser/extensions/extension_apitest.h",

57 "!chrome/browser/history/in_memory_database.h",	57 "!chrome/browser/history/in_memory_database.h",

58 "!chrome/browser/importer/firefox2_importer.h",	58 "!chrome/browser/importer/firefox2_importer.h",

59 "!chrome/browser/profiles/profile_manager.h",	59 "!chrome/browser/profiles/profile_manager.h",

60 "!chrome/browser/ui/browser_commands.h",	60 "!chrome/browser/ui/browser_commands.h",

	61 "!chrome/browser/ui/host_desktop.h",

61 ]	62 ]

62 }	63 }

OLD	NEW