Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(21)

Side by Side Diff: chrome/browser/chromeos/status/network_menu.cc

Issue 10967003: Add desktop type context to most existing instances of FindTabbedBrowser. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Moving check_deps exception to specific_include_rules after chat with Kai. Created 8 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
OLDNEW
1 // Copyright (c) 2012 The Chromium Authors. All rights reserved. 1 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "chrome/browser/chromeos/status/network_menu.h" 5 #include "chrome/browser/chromeos/status/network_menu.h"
6 6
7 #include <algorithm> 7 #include <algorithm>
8 8
9 #include "ash/shell.h" 9 #include "ash/shell.h"
10 #include "ash/shell_delegate.h" 10 #include "ash/shell_delegate.h"
11 #include "base/bind.h" 11 #include "base/bind.h"
12 #include "base/command_line.h" 12 #include "base/command_line.h"
13 #include "base/logging.h" 13 #include "base/logging.h"
14 #include "base/stringprintf.h" 14 #include "base/stringprintf.h"
15 #include "base/utf_string_conversions.h" 15 #include "base/utf_string_conversions.h"
16 #include "chrome/browser/chromeos/choose_mobile_network_dialog.h" 16 #include "chrome/browser/chromeos/choose_mobile_network_dialog.h"
17 #include "chrome/browser/chromeos/cros/cros_library.h" 17 #include "chrome/browser/chromeos/cros/cros_library.h"
18 #include "chrome/browser/chromeos/enrollment_dialog_view.h" 18 #include "chrome/browser/chromeos/enrollment_dialog_view.h"
19 #include "chrome/browser/chromeos/login/user_manager.h" 19 #include "chrome/browser/chromeos/login/user_manager.h"
20 #include "chrome/browser/chromeos/mobile_config.h" 20 #include "chrome/browser/chromeos/mobile_config.h"
21 #include "chrome/browser/chromeos/options/network_config_view.h" 21 #include "chrome/browser/chromeos/options/network_config_view.h"
22 #include "chrome/browser/chromeos/sim_dialog_delegate.h" 22 #include "chrome/browser/chromeos/sim_dialog_delegate.h"
23 #include "chrome/browser/chromeos/status/network_menu_icon.h" 23 #include "chrome/browser/chromeos/status/network_menu_icon.h"
24 #include "chrome/browser/defaults.h" 24 #include "chrome/browser/defaults.h"
25 #include "chrome/browser/profiles/profile_manager.h" 25 #include "chrome/browser/profiles/profile_manager.h"
26 #include "chrome/browser/ui/browser.h" 26 #include "chrome/browser/ui/browser.h"
27 #include "chrome/browser/ui/browser_finder.h" 27 #include "chrome/browser/ui/browser_finder.h"
28 #include "chrome/browser/ui/chrome_pages.h" 28 #include "chrome/browser/ui/chrome_pages.h"
29 #include "chrome/browser/ui/host_desktop.h"
29 #include "chrome/browser/ui/singleton_tabs.h" 30 #include "chrome/browser/ui/singleton_tabs.h"
30 #include "chrome/common/chrome_switches.h" 31 #include "chrome/common/chrome_switches.h"
31 #include "chrome/common/url_constants.h" 32 #include "chrome/common/url_constants.h"
32 #include "content/public/browser/browser_thread.h" 33 #include "content/public/browser/browser_thread.h"
33 #include "grit/generated_resources.h" 34 #include "grit/generated_resources.h"
34 #include "grit/theme_resources.h" 35 #include "grit/theme_resources.h"
35 #include "net/base/escape.h" 36 #include "net/base/escape.h"
36 #include "ui/base/l10n/l10n_util.h" 37 #include "ui/base/l10n/l10n_util.h"
37 #include "ui/base/models/menu_model.h" 38 #include "ui/base/models/menu_model.h"
38 #include "ui/base/resource/resource_bundle.h" 39 #include "ui/base/resource/resource_bundle.h"
(...skipping 36 matching lines...) Expand 10 before | Expand all | Expand 10 after
75 chromeos::CrosLibrary::Get()->GetNetworkLibrary(); 76 chromeos::CrosLibrary::Get()->GetNetworkLibrary();
76 return cros->connected_network() ? network == cros->connected_network() : 77 return cros->connected_network() ? network == cros->connected_network() :
77 network == cros->connecting_network(); 78 network == cros->connecting_network();
78 } 79 }
79 80
80 // Returns the last active browser. If there is no such browser, creates a new 81 // Returns the last active browser. If there is no such browser, creates a new
81 // browser window with an empty tab and returns it. 82 // browser window with an empty tab and returns it.
82 Browser* GetAppropriateBrowser() { 83 Browser* GetAppropriateBrowser() {
83 DCHECK(chromeos::UserManager::Get()->IsSessionStarted()); 84 DCHECK(chromeos::UserManager::Get()->IsSessionStarted());
84 return browser::FindOrCreateTabbedBrowser( 85 return browser::FindOrCreateTabbedBrowser(
85 ProfileManager::GetDefaultProfileOrOffTheRecord()); 86 ProfileManager::GetDefaultProfileOrOffTheRecord(),
87 chrome::HOST_DESKTOP_TYPE_ASH);
86 } 88 }
87 89
88 } // namespace 90 } // namespace
89 91
90 namespace chromeos { 92 namespace chromeos {
91 93
92 class NetworkMenuModel : public ui::MenuModel { 94 class NetworkMenuModel : public ui::MenuModel {
93 public: 95 public:
94 struct MenuItem { 96 struct MenuItem {
95 MenuItem() 97 MenuItem()
(...skipping 337 matching lines...) Expand 10 before | Expand all | Expand 10 after
433 FLAG_WIMAX | 435 FLAG_WIMAX |
434 FLAG_CELLULAR | FLAG_ADD_CELLULAR | 436 FLAG_CELLULAR | FLAG_ADD_CELLULAR |
435 FLAG_VPN | FLAG_ADD_VPN)) { 437 FLAG_VPN | FLAG_ADD_VPN)) {
436 ConnectToNetworkAt(index, std::string(), std::string(), -1); 438 ConnectToNetworkAt(index, std::string(), std::string(), -1);
437 } else if (flags & FLAG_DISCONNECT_VPN) { 439 } else if (flags & FLAG_DISCONNECT_VPN) {
438 const VirtualNetwork* active_vpn = cros->virtual_network(); 440 const VirtualNetwork* active_vpn = cros->virtual_network();
439 if (active_vpn) 441 if (active_vpn)
440 cros->DisconnectFromNetwork(active_vpn); 442 cros->DisconnectFromNetwork(active_vpn);
441 } else if (flags & FLAG_VIEW_ACCOUNT) { 443 } else if (flags & FLAG_VIEW_ACCOUNT) {
442 Browser* browser = browser::FindOrCreateTabbedBrowser( 444 Browser* browser = browser::FindOrCreateTabbedBrowser(
443 ProfileManager::GetDefaultProfileOrOffTheRecord()); 445 ProfileManager::GetDefaultProfileOrOffTheRecord(),
446 chrome::HOST_DESKTOP_TYPE_ASH);
444 chrome::ShowSingletonTab(browser, GURL(top_up_url_)); 447 chrome::ShowSingletonTab(browser, GURL(top_up_url_));
445 } 448 }
446 } 449 }
447 450
448 void NetworkMenuModel::SetMenuModelDelegate(ui::MenuModelDelegate* delegate) { 451 void NetworkMenuModel::SetMenuModelDelegate(ui::MenuModelDelegate* delegate) {
449 } 452 }
450 453
451 //////////////////////////////////////////////////////////////////////////////// 454 ////////////////////////////////////////////////////////////////////////////////
452 // NetworkMenuModel, private methods: 455 // NetworkMenuModel, private methods:
453 456
(...skipping 653 matching lines...) Expand 10 before | Expand all | Expand 10 after
1107 1110
1108 void NetworkMenu::ShowOtherWifi() { 1111 void NetworkMenu::ShowOtherWifi() {
1109 NetworkConfigView::ShowForType(TYPE_WIFI, delegate_->GetNativeWindow()); 1112 NetworkConfigView::ShowForType(TYPE_WIFI, delegate_->GetNativeWindow());
1110 } 1113 }
1111 1114
1112 void NetworkMenu::ShowOtherCellular() { 1115 void NetworkMenu::ShowOtherCellular() {
1113 ChooseMobileNetworkDialog::ShowDialog(delegate_->GetNativeWindow()); 1116 ChooseMobileNetworkDialog::ShowDialog(delegate_->GetNativeWindow());
1114 } 1117 }
1115 1118
1116 } // namespace chromeos 1119 } // namespace chromeos
OLDNEW
« no previous file with comments | « chrome/browser/chromeos/options/network_config_view.cc ('k') | chrome/browser/chromeos/system/ash_system_tray_delegate.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698