chrome/browser/ui/views/tab_contents/render_view_context_menu_win.cc - Issue 10967003: Add desktop type context to most existing instances of FindTabbedBrowser.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/ui/views/tab_contents/render_view_context_menu_win.cc

Issue 10967003: Add desktop type context to most existing instances of FindTabbedBrowser. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: Moving check_deps exception to specific_include_rules after chat with Kai. Created 8 years, 2 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/browser/ui/views/bookmarks/bookmark_context_menu_controller_views_win.cc ('k') | chrome/browser/ui/webui/chrome_web_contents_handler.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/ui/views/tab_contents/render_view_context_menu_win.cc

diff --git a/chrome/browser/ui/views/tab_contents/render_view_context_menu_win.cc b/chrome/browser/ui/views/tab_contents/render_view_context_menu_win.cc

index 9b70ba1477965ef840e750107f43066da096a431..594800348572eb59e1f760ebe93b7ebac2fced2e 100644

--- a/chrome/browser/ui/views/tab_contents/render_view_context_menu_win.cc

+++ b/chrome/browser/ui/views/tab_contents/render_view_context_menu_win.cc

@@ -56,8 +56,12 @@ void RenderViewContextMenuWin::ExecuteCommand(int command_id,

// implements the delegate for the context menu. This would break if there

// are other delegates for the context menu. This is ok for now as this

// code only executes for Windows 8 metro mode.

- Browser* browser = browser::FindTabbedBrowser(

- profile_->GetOriginalProfile(), false);

+ // TODO(robertshield): FTB - Switch this to HOST_DESKTOP_TYPE_ASH when

+ // we make that the default for metro.

+ Browser* browser =

+ browser::FindTabbedBrowser(profile_->GetOriginalProfile(),

+ false,

+ chrome::HOST_DESKTOP_TYPE_NATIVE);

if (browser) {

content::OpenURLParams url_params(

params_.link_url,