Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(3422)

Unified Diff: chrome/browser/protector/settings_change_global_error.h

Issue 10967003: Add desktop type context to most existing instances of FindTabbedBrowser. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Moving check_deps exception to specific_include_rules after chat with Kai. Created 8 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/protector/settings_change_global_error.h
diff --git a/chrome/browser/protector/settings_change_global_error.h b/chrome/browser/protector/settings_change_global_error.h
index ebab480ed122cf05b35ab7dcb5ad4a5a895775ad..7f537c132809fe01eabc63b526fe33c8e365b760 100644
--- a/chrome/browser/protector/settings_change_global_error.h
+++ b/chrome/browser/protector/settings_change_global_error.h
@@ -12,6 +12,7 @@
#include "chrome/browser/protector/base_setting_change.h"
#include "chrome/browser/ui/browser_list_observer.h"
#include "chrome/browser/ui/global_error/global_error.h"
+#include "chrome/browser/ui/host_desktop.h"
class Browser;
class Profile;
@@ -33,14 +34,18 @@ class SettingsChangeGlobalError : public GlobalError,
virtual ~SettingsChangeGlobalError();
// Adds a global error to the given browser profile and shows a bubble
- // immediately if |show_bubble| is |true|.
- void AddToProfile(Profile* profile, bool show_bubble);
+ // immediately on the desktop specified by |desktop_type| if |show_bubble| is
+ // |true|.
+ void AddToProfile(Profile* profile,
+ bool show_bubble,
+ chrome::HostDesktopType desktop_type);
// Removes global error from its profile.
void RemoveFromProfile();
- // Displays the bubble in the last active tabbed browser.
- void ShowBubble();
+ // Displays the bubble in the last active tabbed browser on the desktop
+ // specified by |desktop_type|.
+ void ShowBubble(chrome::HostDesktopType desktop_type);
// Returns the change instance to which this error refers.
BaseSettingChange* change() { return change_; }
« no previous file with comments | « chrome/browser/protector/protector_service.cc ('k') | chrome/browser/protector/settings_change_global_error.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698