Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(169)

Issue 1095893005: Merge to XFA: Add missing operators for CFX_xxxString combo patch. (Closed)

Created:
5 years, 8 months ago by Tom Sepez
Modified:
5 years, 8 months ago
Reviewers:
Lei Zhang
CC:
pdfium-reviews_googlegroups.com
Base URL:
https://pdfium.googlesource.com/pdfium.git@xfa
Target Ref:
refs/heads/xfa
Visibility:
Public.

Description

Merge to XFA: Add missing operators for CFX_xxxString combo patch. This pulls in: Review URL: https://codereview.chromium.org/1099193002 Review URL: https://codereview.chromium.org/1090303003 Review URL: https://codereview.chromium.org/1084293003 Review URL: https://codereview.chromium.org/1099213002 Plus one fix to an XFA file to fix compilation. TBR=thestig@chromium.org Committed: https://pdfium.googlesource.com/pdfium/+/b208774174e102da9f218d89bf8a3af7a0e37f09

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+247 lines, -62 lines) Patch
M core/include/fxcrt/fx_string.h View 10 chunks +42 lines, -14 lines 0 comments Download
M core/src/fpdfapi/fpdf_page/fpdf_page_graph_state.cpp View 1 chunk +1 line, -1 line 0 comments Download
M core/src/fpdfapi/fpdf_parser/fpdf_parser_parser.cpp View 2 chunks +2 lines, -2 lines 0 comments Download
M core/src/fpdfapi/fpdf_parser/fpdf_parser_utility.cpp View 2 chunks +2 lines, -2 lines 0 comments Download
M core/src/fxcrt/fx_basic_bstring.cpp View 1 chunk +1 line, -1 line 0 comments Download
M core/src/fxcrt/fx_basic_bstring_unittest.cpp View 2 chunks +78 lines, -0 lines 0 comments Download
M core/src/fxcrt/fx_basic_buffer.cpp View 4 chunks +5 lines, -5 lines 0 comments Download
M core/src/fxcrt/fx_basic_maps.cpp View 4 chunks +6 lines, -6 lines 0 comments Download
M core/src/fxcrt/fx_basic_wstring_unittest.cpp View 1 chunk +108 lines, -29 lines 0 comments Download
M xfa/src/fxfa/src/parser/xfa_object_imp.cpp View 2 chunks +2 lines, -2 lines 0 comments Download

Messages

Total messages: 3 (0 generated)
Tom Sepez
TBR'd.
5 years, 8 months ago (2015-04-22 19:29:10 UTC) #1
Tom Sepez
Committed patchset #1 (id:1) manually as b208774174e102da9f218d89bf8a3af7a0e37f09 (presubmit successful).
5 years, 8 months ago (2015-04-22 19:29:25 UTC) #2
Lei Zhang
5 years, 8 months ago (2015-04-22 20:35:30 UTC) #3
Message was sent while issue was closed.
lgtm

Powered by Google App Engine
This is Rietveld 408576698