Add missing operators for CFX_ByteStringC.

Add missing operators for CFX_ByteStringC.

Removing the implicit cast operator forces a build breakage should we
use ByteStringC in STL containers. Adding an operator< restores correct
behaviour. Adding an operator[] avoids re-writing some code to call
GetPtr() prior to array indexing.

Part 1 of 4.

R=thestig@chromium.org
TBR=brucedawson@chromium.org
BUG=pdfium:142
.

Committed: https://pdfium.googlesource.com/pdfium/+/1ddf056da74de0a34631b8a719f4f02b4ec82144

[Tom Sepez, 2015-04-21 19:25:15]

tsepez@chromium.org changed reviewers:
+ thestig@chromium.org

[Tom Sepez, 2015-04-21 19:25:16]

Lei, for review.

[Tom Sepez, 2015-04-21 19:34:50]

https://codereview.chromium.org/1090303003/diff/1/core/include/fxcrt/fx_string.h
File core/include/fxcrt/fx_string.h (left):

https://codereview.chromium.org/1090303003/diff/1/core/include/fxcrt/fx_strin...
core/include/fxcrt/fx_string.h:103: #define FXBSTR_ID(c1, c2, c3, c4) ((c1 <<
24) | (c2 << 16) | (c3 << 8) | (c4))
Moved below, just because.

[Tom Sepez, 2015-04-21 20:03:03]

tsepez@chromium.org changed reviewers:
+ brucedawson@chromium.org

[Tom Sepez, 2015-04-21 20:03:19]

+Bruce, just for good measure.

[Lei Zhang, 2015-04-21 22:05:51]

lgtm

https://codereview.chromium.org/1090303003/diff/40001/core/include/fxcrt/fx_s...
File core/include/fxcrt/fx_string.h (right):

https://codereview.chromium.org/1090303003/diff/40001/core/include/fxcrt/fx_s...
core/include/fxcrt/fx_string.h:147: const FX_BYTE& operator[] (int index) const
Can this be size_t ?

[brucedawson, 2015-04-22 10:36:08]

There's one bug I noticed that should be fixed.

https://codereview.chromium.org/1090303003/diff/40001/core/include/fxcrt/fx_s...
File core/include/fxcrt/fx_string.h (right):

https://codereview.chromium.org/1090303003/diff/40001/core/include/fxcrt/fx_s...
core/include/fxcrt/fx_string.h:152: bool operator< (const CFX_ByteStringC& that)
The operator itself needs to be marked const.

https://codereview.chromium.org/1090303003/diff/40001/core/src/fpdfapi/fpdf_p...
File core/src/fpdfapi/fpdf_page/fpdf_page_graph_state.cpp (right):

https://codereview.chromium.org/1090303003/diff/40001/core/src/fpdfapi/fpdf_p...
core/src/fpdfapi/fpdf_page/fpdf_page_graph_state.cpp:430:
FXSYS_memcpy32(m_BlendMode, blend_mode.GetPtr(), blend_mode.GetLength());
Consider instead adding and then using a c_str() function so that the usage
matches that of std::string (just a thought).

[Tom Sepez, 2015-04-22 16:54:19]

https://codereview.chromium.org/1090303003/diff/40001/core/include/fxcrt/fx_s...
File core/include/fxcrt/fx_string.h (right):

https://codereview.chromium.org/1090303003/diff/40001/core/include/fxcrt/fx_s...
core/include/fxcrt/fx_string.h:147: const FX_BYTE& operator[] (int index) const
On 2015/04/21 22:05:51, Lei Zhang wrote:
> Can this be size_t ?

Done.

https://codereview.chromium.org/1090303003/diff/40001/core/include/fxcrt/fx_s...
core/include/fxcrt/fx_string.h:152: bool operator< (const CFX_ByteStringC& that)
On 2015/04/22 10:36:08, brucedawson wrote:
> The operator itself needs to be marked const.

Done.

https://codereview.chromium.org/1090303003/diff/40001/core/src/fpdfapi/fpdf_p...
File core/src/fpdfapi/fpdf_page/fpdf_page_graph_state.cpp (right):

https://codereview.chromium.org/1090303003/diff/40001/core/src/fpdfapi/fpdf_p...
core/src/fpdfapi/fpdf_page/fpdf_page_graph_state.cpp:430:
FXSYS_memcpy32(m_BlendMode, blend_mode.GetPtr(), blend_mode.GetLength());
On 2015/04/22 10:36:08, brucedawson wrote:
> Consider instead adding and then using a c_str() function so that the usage
> matches that of std::string (just a thought).
Yep.  The CFX_xxxStringC types have an existing GetPtr().  The CFX_xxxString
types didn't, so we added it, and we picked the name, which is why it's called
c_str(). I'll Follow-up someday.

[Tom Sepez, 2015-04-22 19:03:25]

Bruce to TBR during absence.

[Tom Sepez, 2015-04-22 19:04:19]

Committed patchset #5 (id:80001) manually as
1ddf056da74de0a34631b8a719f4f02b4ec82144 (presubmit successful).