Add missing operators for CFX_WideStringC.

Add missing operators for CFX_WideStringC.

Part 2 of 4.

R=thestig@chromium.org
TBR=brucedawson@chromium.org
BUG=pdfium:142
Committed: https://pdfium.googlesource.com/pdfium/+/fbfcbc5e82d89585a63a77c63e782fb6768c8dc8

[Tom Sepez, 2015-04-21 20:05:03]

tsepez@chromium.org changed reviewers:
+ brucedawson@chromium.org, thestig@chromium.org

[Tom Sepez, 2015-04-21 20:05:04]

Lei, Bruce, for review.

[Lei Zhang, 2015-04-21 22:07:56]

https://codereview.chromium.org/1099193002/diff/1/core/include/fxcrt/fx_string.h
File core/include/fxcrt/fx_string.h (right):

https://codereview.chromium.org/1099193002/diff/1/core/include/fxcrt/fx_strin...
core/include/fxcrt/fx_string.h:612: const FX_WCHAR& operator[] (int index) const
Same as last CL, size_t ?

https://codereview.chromium.org/1099193002/diff/1/core/src/fxcrt/fx_basic_wst...
File core/src/fxcrt/fx_basic_wstring_unittest.cpp (right):

https://codereview.chromium.org/1099193002/diff/1/core/src/fxcrt/fx_basic_wst...
core/src/fxcrt/fx_basic_wstring_unittest.cpp:34: EXPECT_EQ('a', abc[0]);
I'm surprised this compiles given that operator[] returns a FX_WCHAR.

[Tom Sepez, 2015-04-21 22:17:11]

>
https://codereview.chromium.org/1099193002/diff/1/core/src/fxcrt/fx_basic_wst...
> core/src/fxcrt/fx_basic_wstring_unittest.cpp:34: EXPECT_EQ('a', abc[0]);
> I'm surprised this compiles given that operator[] returns a FX_WCHAR.
Hmm. I'd imagine that we have a char vs wchar_t comparison, integral promotion
takes place, and maybe we get a signed/unsigned comparison warning (which is
suppressed at the moment). Other reasons why this doesn't work?

[Tom Sepez, 2015-04-21 22:18:45]

On 2015/04/21 22:17:11, Tom Sepez wrote:
> >
>
https://codereview.chromium.org/1099193002/diff/1/core/src/fxcrt/fx_basic_wst...
> > core/src/fxcrt/fx_basic_wstring_unittest.cpp:34: EXPECT_EQ('a', abc[0]);
> > I'm surprised this compiles given that operator[] returns a FX_WCHAR.
> Hmm. I'd imagine that we have a char vs wchar_t comparison, integral promotion
> takes place, and maybe we get a signed/unsigned comparison warning (which is
> suppressed at the moment). Other reasons why this doesn't work?
Anyways, its easy enough to make them L''s.

[Lei Zhang, 2015-04-21 22:32:42]

lgtm

At least in Chromium I've always found EXPECT_EQ() to be much more picky w.r.t.
having the right types.

[brucedawson, 2015-04-22 10:47:12]

https://codereview.chromium.org/1099193002/diff/1/core/include/fxcrt/fx_string.h
File core/include/fxcrt/fx_string.h (right):

https://codereview.chromium.org/1099193002/diff/1/core/include/fxcrt/fx_strin...
core/include/fxcrt/fx_string.h:617: bool operator< (const CFX_WideStringC& that)
The operator itself needs to be const.

[Tom Sepez, 2015-04-22 17:06:46]

https://codereview.chromium.org/1099193002/diff/1/core/include/fxcrt/fx_string.h
File core/include/fxcrt/fx_string.h (right):

https://codereview.chromium.org/1099193002/diff/1/core/include/fxcrt/fx_strin...
core/include/fxcrt/fx_string.h:612: const FX_WCHAR& operator[] (int index) const
On 2015/04/21 22:07:56, Lei Zhang wrote:
> Same as last CL, size_t ?

Done.

https://codereview.chromium.org/1099193002/diff/1/core/include/fxcrt/fx_strin...
core/include/fxcrt/fx_string.h:617: bool operator< (const CFX_WideStringC& that)
On 2015/04/22 10:47:12, brucedawson wrote:
> The operator itself needs to be const.

Done.

https://codereview.chromium.org/1099193002/diff/1/core/include/fxcrt/fx_strin...
core/include/fxcrt/fx_string.h:619: int result = wmemcmp(m_Ptr, that.m_Ptr,
std::min(m_Length, that.m_Length));
Bruce, you're OK with wmemcmp, right?  No windows strangeness hiding here?

https://codereview.chromium.org/1099193002/diff/1/core/src/fxcrt/fx_basic_wst...
File core/src/fxcrt/fx_basic_wstring_unittest.cpp (right):

https://codereview.chromium.org/1099193002/diff/1/core/src/fxcrt/fx_basic_wst...
core/src/fxcrt/fx_basic_wstring_unittest.cpp:34: EXPECT_EQ('a', abc[0]);
On 2015/04/21 22:07:56, Lei Zhang wrote:
> I'm surprised this compiles given that operator[] returns a FX_WCHAR.

Done.

[Tom Sepez, 2015-04-22 19:15:55]

Bruce to TBR during absence.

[Tom Sepez, 2015-04-22 19:16:35]

Committed patchset #3 (id:40001) manually as
fbfcbc5e82d89585a63a77c63e782fb6768c8dc8 (presubmit successful).