Issue 1084293003: Add missing operators for CFX_WideString

Issue 1084293003: Add missing operators for CFX_WideString (Closed)

Created:
5 years, 8 months ago by Tom Sepez

Modified:
5 years, 8 months ago

Reviewers:
Lei Zhang, brucedawson

CC:
pdfium-reviews_googlegroups.com

Base URL:
https://pdfium.googlesource.com/pdfium.git@master

Target Ref:
refs/heads/master

Visibility:
Public.

More Reviews

Description

Add missing operators for CFX_WideString Part 4 of 4. BUG=pdfium:142 R=brucedawson@chromium.org, thestig@chromium.org Committed: https://pdfium.googlesource.com/pdfium/+/ea6a069e6e593d97513e86fc761cf789a9714c22

Patch Set 2 : Remove DOS line endings, #

Patch Set 3 : L'' #

Created: 5 years, 8 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+73 lines, -29 lines)			Patch
	M	core/include/fxcrt/fx_string.h	View	1	1 chunk	+5 lines, -0 lines	0 comments	Download
	M	core/src/fxcrt/fx_basic_wstring_unittest.cpp	View	1 2	1 chunk	+68 lines, -29 lines	0 comments	Download

Messages

Total messages: 7 (1 generated)

Expand Messages | Collapse Messages | Show Generated Messages | Hide Generated Messages

Lei Zhang

https://codereview.chromium.org/1084293003/diff/1/core/src/fxcrt/fx_basic_wstring_unittest.cpp File core/src/fxcrt/fx_basic_wstring_unittest.cpp (right): https://codereview.chromium.org/1084293003/diff/1/core/src/fxcrt/fx_basic_wstring_unittest.cpp#newcode12 core/src/fxcrt/fx_basic_wstring_unittest.cpp:12: EXPECT_EQ('a', abc[0]); Also concerned whether this actually compiles.

5 years, 8 months ago (2015-04-21 22:12:34 UTC) #3

Tom Sepez

5 years, 8 months ago (2015-04-22 17:23:10 UTC) #7

Message was sent while issue was closed.

Committed patchset #3 (id:40001) manually as
ea6a069e6e593d97513e86fc761cf789a9714c22 (presubmit successful).

Expand Messages | Collapse Messages | Show Generated Messages | Hide Generated Messages