Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(240)

Issue 1099213002: Add missing operators for CFX_ByteString. (Closed)

Created:
5 years, 8 months ago by Tom Sepez
Modified:
5 years, 8 months ago
Reviewers:
Lei Zhang, brucedawson
CC:
pdfium-reviews_googlegroups.com
Base URL:
https://pdfium.googlesource.com/pdfium.git@master
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Patch Set 1 #

Patch Set 2 : Typo in comment. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+47 lines, -0 lines) Patch
M core/include/fxcrt/fx_string.h View 2 chunks +8 lines, -0 lines 0 comments Download
M core/src/fxcrt/fx_basic_bstring_unittest.cpp View 1 1 chunk +39 lines, -0 lines 0 comments Download

Messages

Total messages: 5 (1 generated)
Tom Sepez
Lei, Bruce, for review.
5 years, 8 months ago (2015-04-21 20:50:25 UTC) #2
Lei Zhang
lgtm
5 years, 8 months ago (2015-04-21 22:11:40 UTC) #3
brucedawson
lgtm
5 years, 8 months ago (2015-04-22 10:45:25 UTC) #4
Tom Sepez
5 years, 8 months ago (2015-04-22 17:09:40 UTC) #5
Message was sent while issue was closed.
Committed patchset #2 (id:20001) manually as
ca19b6e6b4e81ba0fce1bc9d2e145cb39cf0537d (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698