Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(295)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 10942040: Fix CC*Renderer and CC*LayerImpl to compile with Clang (Closed)

Created:
8 years, 3 months ago by enne (OOO)
Modified:
8 years, 3 months ago
Reviewers:
jamesr
CC:
chromium-reviews, cc-bugs_chromium.org
Visibility:
Public.

Description

Fix CC*Renderer and CC*LayerImpl to compile with Clang BUG=none Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=157654

Patch Set 1 #

Total comments: 1
Unified diffs Side-by-side diffs Delta from patch set Stats (+346 lines, -106 lines) Patch
M cc/CCDirectRenderer.h View 3 chunks +5 lines, -13 lines 0 comments Download
M cc/CCDirectRenderer.cpp View 2 chunks +23 lines, -0 lines 0 comments Download
M cc/CCIOSurfaceLayerImpl.h View 1 chunk +1 line, -1 line 0 comments Download
M cc/CCIOSurfaceLayerImpl.cpp View 1 chunk +6 lines, -0 lines 0 comments Download
M cc/CCLayerImpl.h View 3 chunks +5 lines, -5 lines 0 comments Download
M cc/CCLayerImpl.cpp View 2 chunks +25 lines, -0 lines 0 comments Download
M cc/CCLayerQuad.h View 1 chunk +1 line, -7 lines 0 comments Download
M cc/CCLayerQuad.cpp View 1 chunk +8 lines, -0 lines 0 comments Download
M cc/CCLayerSorter.h View 3 chunks +5 lines, -3 lines 0 comments Download
M cc/CCLayerSorter.cpp View 2 chunks +23 lines, -0 lines 0 comments Download
M cc/CCLayerTreeHost.h View 2 chunks +4 lines, -28 lines 0 comments Download
M cc/CCLayerTreeHost.cpp View 1 chunk +41 lines, -0 lines 0 comments Download
M cc/CCLayerTreeHostCommon.h View 1 chunk +3 lines, -0 lines 0 comments Download
M cc/CCLayerTreeHostCommon.cpp View 1 chunk +8 lines, -0 lines 0 comments Download
M cc/CCLayerTreeHostImpl.h View 2 chunks +5 lines, -2 lines 0 comments Download
M cc/CCLayerTreeHostImpl.cpp View 2 chunks +18 lines, -0 lines 0 comments Download
M cc/CCRenderPass.h View 1 chunk +2 lines, -0 lines 0 comments Download
M cc/CCRenderPass.cpp View 1 chunk +4 lines, -0 lines 0 comments Download
M cc/CCRenderer.h View 2 chunks +2 lines, -2 lines 0 comments Download
A cc/CCRenderer.cpp View 1 chunk +21 lines, -0 lines 0 comments Download
M cc/CCRendererGL.h View 1 chunk +1 line, -1 line 0 comments Download
M cc/CCRendererGL.cpp View 1 chunk +5 lines, -0 lines 0 comments Download
M cc/CCResourceProvider.h View 3 chunks +10 lines, -36 lines 0 comments Download
M cc/CCResourceProvider.cpp View 1 chunk +58 lines, -0 lines 0 comments Download
M cc/CCScrollbarAnimationController.h View 1 chunk +1 line, -1 line 0 comments Download
M cc/CCScrollbarAnimationController.cpp View 1 chunk +5 lines, -0 lines 0 comments Download
M cc/CCScrollbarLayerImpl.h View 2 chunks +3 lines, -0 lines 0 comments Download
M cc/CCScrollbarLayerImpl.cpp View 2 chunks +10 lines, -0 lines 0 comments Download
M cc/CCSingleThreadProxy.h View 1 chunk +4 lines, -4 lines 0 comments Download
M cc/CCSingleThreadProxy.cpp View 3 chunks +20 lines, -0 lines 0 comments Download
M cc/CCTextureLayerImpl.h View 1 chunk +1 line, -1 line 0 comments Download
M cc/CCTextureLayerImpl.cpp View 1 chunk +5 lines, -0 lines 0 comments Download
M cc/CCTiledLayerImpl.h View 1 chunk +1 line, -1 line 0 comments Download
M cc/CCTiledLayerImpl.cpp View 1 chunk +5 lines, -0 lines 1 comment Download
M cc/CCVideoLayerImpl.h View 1 chunk +1 line, -1 line 0 comments Download
M cc/CCVideoLayerImpl.cpp View 1 chunk +5 lines, -0 lines 0 comments Download
M cc/cc.gyp View 1 chunk +1 line, -0 lines 0 comments Download

Messages

Total messages: 4 (0 generated)
enne (OOO)
Just touching a few classes at a time...
8 years, 3 months ago (2012-09-19 21:14:24 UTC) #1
jamesr
lgtm https://codereview.chromium.org/10942040/diff/1/cc/CCTiledLayerImpl.cpp File cc/CCTiledLayerImpl.cpp (right): https://codereview.chromium.org/10942040/diff/1/cc/CCTiledLayerImpl.cpp#newcode219 cc/CCTiledLayerImpl.cpp:219: return "ContentLayer"; lol, ContentLayer
8 years, 3 months ago (2012-09-19 21:25:49 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/enne@chromium.org/10942040/1
8 years, 3 months ago (2012-09-19 21:29:57 UTC) #3
commit-bot: I haz the power
8 years, 3 months ago (2012-09-19 23:34:12 UTC) #4 
Change committed as 157654

Powered by Google App Engine
This is Rietveld 408576698