Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(439)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1091513005: Separate mojo/shell into a runner and the application manager (shell) (Closed)

Created:
5 years, 8 months ago by Ben Goodger (Google)
Modified:
5 years, 8 months ago
Reviewers:
sky
CC:
chromium-reviews, qsr+mojo_chromium.org, viettrungluu+watch_chromium.org, yzshen+watch_chromium.org, abarth-chromium, Aaron Boodman, darin (slow to review), ben+mojo_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Separate mojo/shell into a runner and the application manager (shell) R=sky@chromium.org BUG= Committed: https://crrev.com/ee05293936b654dfbc42889ba374bba21bd5c453 Cr-Commit-Position: refs/heads/master@{#327148}

Patch Set 1 #

Patch Set 2 : . #

Patch Set 3 : . #

Total comments: 1

Patch Set 4 : . #

Unified diffs Side-by-side diffs Delta from patch set Stats (+269 lines, -8412 lines) Patch
M components/gles2/BUILD.gn View 1 1 chunk +1 line, -1 line 0 comments Download
M mandoline/app/BUILD.gn View 1 chunk +1 line, -1 line 0 comments Download
M mojo/BUILD.gn View 1 chunk +1 line, -1 line 0 comments Download
M mojo/application/BUILD.gn View 1 chunk +1 line, -1 line 0 comments Download
A + mojo/runner/BUILD.gn View 1 2 3 11 chunks +36 lines, -35 lines 0 comments Download
A + mojo/runner/DEPS View 0 chunks +-1 lines, --1 lines 0 comments Download
A + mojo/runner/PRESUBMIT.py View 0 chunks +-1 lines, --1 lines 0 comments Download
A + mojo/runner/android/android_handler.h View 2 chunks +3 lines, -3 lines 0 comments Download
A + mojo/runner/android/android_handler.cc View 2 chunks +3 lines, -3 lines 0 comments Download
A + mojo/runner/android/android_handler_loader.h View 2 chunks +5 lines, -5 lines 0 comments Download
A + mojo/runner/android/android_handler_loader.cc View 1 chunk +1 line, -1 line 0 comments Download
A + mojo/runner/android/apk/AndroidManifest.xml View 0 chunks +-1 lines, --1 lines 0 comments Download
A + mojo/runner/android/apk/res/values/strings.xml View 0 chunks +-1 lines, --1 lines 0 comments Download
A + mojo/runner/android/apk/src/org/chromium/mojo/shell/AndroidHandler.java View 0 chunks +-1 lines, --1 lines 0 comments Download
A + mojo/runner/android/apk/src/org/chromium/mojo/shell/Bootstrap.java View 0 chunks +-1 lines, --1 lines 0 comments Download
A + mojo/runner/android/apk/src/org/chromium/mojo/shell/FileHelper.java View 0 chunks +-1 lines, --1 lines 0 comments Download
A + mojo/runner/android/apk/src/org/chromium/mojo/shell/MojoShellActivity.java View 0 chunks +-1 lines, --1 lines 0 comments Download
A + mojo/runner/android/apk/src/org/chromium/mojo/shell/MojoShellApplication.java View 0 chunks +-1 lines, --1 lines 0 comments Download
A + mojo/runner/android/apk/src/org/chromium/mojo/shell/ShellMain.java View 0 chunks +-1 lines, --1 lines 0 comments Download
A + mojo/runner/android/background_application_loader.h View 2 chunks +4 lines, -4 lines 0 comments Download
A + mojo/runner/android/background_application_loader.cc View 1 chunk +2 lines, -2 lines 0 comments Download
A + mojo/runner/android/background_application_loader_unittest.cc View 1 chunk +1 line, -1 line 0 comments Download
A + mojo/runner/android/bootstrap.cc View 1 chunk +1 line, -1 line 0 comments Download
A + mojo/runner/android/library_loader.cc View 1 chunk +2 lines, -2 lines 0 comments Download
A + mojo/runner/android/main.h View 2 chunks +3 lines, -3 lines 0 comments Download
A + mojo/runner/android/main.cc View 2 chunks +8 lines, -8 lines 0 comments Download
A + mojo/runner/android/native_viewport_application_loader.h View 2 chunks +4 lines, -4 lines 0 comments Download
A + mojo/runner/android/native_viewport_application_loader.cc View 1 chunk +1 line, -1 line 0 comments Download
A + mojo/runner/android/run_android_application_function.h View 2 chunks +3 lines, -3 lines 0 comments Download
A + mojo/runner/android/tests/src/org/chromium/mojo/shell/ShellTestBase.java View 0 chunks +-1 lines, --1 lines 0 comments Download
A + mojo/runner/android/ui_application_loader_android.h View 2 chunks +4 lines, -4 lines 0 comments Download
A + mojo/runner/android/ui_application_loader_android.cc View 1 chunk +2 lines, -2 lines 0 comments Download
A + mojo/runner/child_process.h View 2 chunks +3 lines, -3 lines 0 comments Download
A + mojo/runner/child_process.cc View 2 chunks +4 lines, -4 lines 0 comments Download
A + mojo/runner/child_process.mojom View 0 chunks +-1 lines, --1 lines 0 comments Download
A + mojo/runner/child_process_host.h View 2 chunks +5 lines, -5 lines 0 comments Download
A + mojo/runner/child_process_host.cc View 1 2 2 chunks +4 lines, -4 lines 0 comments Download
A + mojo/runner/child_process_host_unittest.cc View 1 chunk +2 lines, -2 lines 0 comments Download
A + mojo/runner/context.h View 1 2 2 chunks +6 lines, -6 lines 0 comments Download
A + mojo/runner/context.cc View 1 2 2 chunks +7 lines, -7 lines 0 comments Download
A + mojo/runner/data_pipe_peek_unittest.cc View 1 chunk +2 lines, -2 lines 0 comments Download
A + mojo/runner/desktop/launcher_process.h View 0 chunks +-1 lines, --1 lines 0 comments Download
A + mojo/runner/desktop/launcher_process.cc View 1 chunk +2 lines, -2 lines 0 comments Download
A + mojo/runner/desktop/main.cc View 1 chunk +4 lines, -4 lines 0 comments Download
A + mojo/runner/filename_util.h View 2 chunks +3 lines, -3 lines 0 comments Download
A + mojo/runner/filename_util.cc View 1 chunk +1 line, -1 line 0 comments Download
A + mojo/runner/in_process_native_runner.h View 3 chunks +5 lines, -5 lines 0 comments Download
A + mojo/runner/in_process_native_runner.cc View 1 chunk +2 lines, -2 lines 0 comments Download
A + mojo/runner/in_process_native_runner_unittest.cc View 1 chunk +2 lines, -2 lines 0 comments Download
A + mojo/runner/init.h View 2 chunks +3 lines, -3 lines 0 comments Download
A + mojo/runner/init.cc View 1 chunk +1 line, -1 line 0 comments Download
A + mojo/runner/native_application_support.h View 2 chunks +3 lines, -3 lines 0 comments Download
A + mojo/runner/native_application_support.cc View 1 chunk +1 line, -1 line 0 comments Download
A + mojo/runner/native_runner_unittest.cc View 1 2 1 chunk +3 lines, -3 lines 0 comments Download
A + mojo/runner/out_of_process_native_runner.h View 2 chunks +4 lines, -4 lines 0 comments Download
A + mojo/runner/out_of_process_native_runner.cc View 1 chunk +4 lines, -4 lines 0 comments Download
A + mojo/runner/shell_apptest.cc View 1 chunk +2 lines, -2 lines 0 comments Download
A + mojo/runner/shell_test_base.h View 2 chunks +4 lines, -4 lines 0 comments Download
A + mojo/runner/shell_test_base.cc View 2 chunks +2 lines, -2 lines 0 comments Download
A + mojo/runner/shell_test_base_android.cc View 1 chunk +2 lines, -2 lines 0 comments Download
A + mojo/runner/shell_test_base_unittest.cc View 1 chunk +1 line, -1 line 0 comments Download
A + mojo/runner/shell_test_main.cc View 1 chunk +2 lines, -2 lines 0 comments Download
A + mojo/runner/switches.h View 2 chunks +3 lines, -5 lines 0 comments Download
A + mojo/runner/switches.cc View 3 chunks +1 line, -11 lines 0 comments Download
A + mojo/runner/task_runners.h View 2 chunks +3 lines, -3 lines 0 comments Download
A + mojo/runner/task_runners.cc View 1 chunk +1 line, -1 line 0 comments Download
A + mojo/runner/test/BUILD.gn View 0 chunks +-1 lines, --1 lines 0 comments Download
A + mojo/runner/test/pingable.mojom View 0 chunks +-1 lines, --1 lines 0 comments Download
A + mojo/runner/test/pingable_app.cc View 1 chunk +1 line, -1 line 0 comments Download
A + mojo/runner/url_resolver.h View 2 chunks +3 lines, -3 lines 0 comments Download
A + mojo/runner/url_resolver.cc View 1 chunk +4 lines, -4 lines 0 comments Download
A + mojo/runner/url_resolver_unittest.cc View 1 chunk +1 line, -1 line 0 comments Download
M mojo/shell/BUILD.gn View 1 2 2 chunks +41 lines, -376 lines 0 comments Download
M mojo/shell/DEPS View 1 chunk +1 line, -6 lines 0 comments Download
D mojo/shell/PRESUBMIT.py View 1 chunk +0 lines, -16 lines 0 comments Download
D mojo/shell/android/android_handler.h View 1 chunk +0 lines, -46 lines 0 comments Download
D mojo/shell/android/android_handler.cc View 1 chunk +0 lines, -111 lines 0 comments Download
D mojo/shell/android/android_handler_loader.h View 1 chunk +0 lines, -37 lines 0 comments Download
D mojo/shell/android/android_handler_loader.cc View 1 chunk +0 lines, -25 lines 0 comments Download
D mojo/shell/android/apk/AndroidManifest.xml View 1 chunk +0 lines, -31 lines 0 comments Download
D mojo/shell/android/apk/res/values/strings.xml View 1 chunk +0 lines, -10 lines 0 comments Download
D mojo/shell/android/apk/src/org/chromium/mojo/shell/AndroidHandler.java View 1 chunk +0 lines, -138 lines 0 comments Download
D mojo/shell/android/apk/src/org/chromium/mojo/shell/Bootstrap.java View 1 chunk +0 lines, -45 lines 0 comments Download
D mojo/shell/android/apk/src/org/chromium/mojo/shell/FileHelper.java View 1 chunk +0 lines, -179 lines 0 comments Download
D mojo/shell/android/apk/src/org/chromium/mojo/shell/MojoShellActivity.java View 1 chunk +0 lines, -67 lines 0 comments Download
D mojo/shell/android/apk/src/org/chromium/mojo/shell/MojoShellApplication.java View 1 chunk +0 lines, -57 lines 0 comments Download
D mojo/shell/android/apk/src/org/chromium/mojo/shell/ShellMain.java View 1 chunk +0 lines, -105 lines 0 comments Download
D mojo/shell/android/background_application_loader.h View 1 chunk +0 lines, -64 lines 0 comments Download
D mojo/shell/android/background_application_loader.cc View 1 chunk +0 lines, -73 lines 0 comments Download
D mojo/shell/android/background_application_loader_unittest.cc View 1 chunk +0 lines, -51 lines 0 comments Download
D mojo/shell/android/bootstrap.cc View 1 chunk +0 lines, -43 lines 0 comments Download
D mojo/shell/android/library_loader.cc View 1 chunk +0 lines, -44 lines 0 comments Download
D mojo/shell/android/main.h View 1 chunk +0 lines, -18 lines 0 comments Download
D mojo/shell/android/main.cc View 1 chunk +0 lines, -211 lines 0 comments Download
D mojo/shell/android/native_viewport_application_loader.h View 1 chunk +0 lines, -58 lines 0 comments Download
D mojo/shell/android/native_viewport_application_loader.cc View 1 chunk +0 lines, -50 lines 0 comments Download
D mojo/shell/android/run_android_application_function.h View 1 chunk +0 lines, -27 lines 0 comments Download
D mojo/shell/android/tests/src/org/chromium/mojo/shell/ShellTestBase.java View 1 chunk +0 lines, -40 lines 0 comments Download
D mojo/shell/android/ui_application_loader_android.h View 1 chunk +0 lines, -54 lines 0 comments Download
D mojo/shell/android/ui_application_loader_android.cc View 1 chunk +0 lines, -48 lines 0 comments Download
A + mojo/shell/application_loader.h View 0 chunks +-1 lines, --1 lines 0 comments Download
A + mojo/shell/application_manager.h View 1 2 3 1 chunk +4 lines, -4 lines 0 comments Download
A + mojo/shell/application_manager.cc View 1 2 2 chunks +6 lines, -6 lines 0 comments Download
D mojo/shell/application_manager/BUILD.gn View 1 chunk +0 lines, -77 lines 0 comments Download
D mojo/shell/application_manager/application_loader.h View 1 chunk +0 lines, -38 lines 0 comments Download
D mojo/shell/application_manager/application_manager.h View 1 2 1 chunk +0 lines, -232 lines 0 comments Download
D mojo/shell/application_manager/application_manager.cc View 1 2 1 chunk +0 lines, -463 lines 0 comments Download
D mojo/shell/application_manager/application_manager_unittest.cc View 1 2 1 chunk +0 lines, -741 lines 0 comments Download
D mojo/shell/application_manager/data_pipe_peek.h View 1 chunk +0 lines, -38 lines 0 comments Download
D mojo/shell/application_manager/data_pipe_peek.cc View 1 chunk +0 lines, -160 lines 0 comments Download
D mojo/shell/application_manager/fetcher.h View 1 chunk +0 lines, -76 lines 0 comments Download
D mojo/shell/application_manager/fetcher.cc View 1 chunk +0 lines, -38 lines 0 comments Download
D mojo/shell/application_manager/identity.h View 1 chunk +0 lines, -31 lines 0 comments Download
D mojo/shell/application_manager/identity.cc View 1 chunk +0 lines, -28 lines 0 comments Download
D mojo/shell/application_manager/local_fetcher.h View 1 chunk +0 lines, -51 lines 0 comments Download
D mojo/shell/application_manager/local_fetcher.cc View 1 chunk +0 lines, -107 lines 0 comments Download
D mojo/shell/application_manager/native_runner.h View 1 chunk +0 lines, -58 lines 0 comments Download
D mojo/shell/application_manager/network_fetcher.h View 1 chunk +0 lines, -83 lines 0 comments Download
D mojo/shell/application_manager/network_fetcher.cc View 1 chunk +0 lines, -251 lines 0 comments Download
D mojo/shell/application_manager/query_util.h View 1 chunk +0 lines, -23 lines 0 comments Download
D mojo/shell/application_manager/query_util.cc View 1 chunk +0 lines, -31 lines 0 comments Download
D mojo/shell/application_manager/query_util_unittest.cc View 1 chunk +0 lines, -47 lines 0 comments Download
D mojo/shell/application_manager/shell_impl.h View 1 chunk +0 lines, -62 lines 0 comments Download
D mojo/shell/application_manager/shell_impl.cc View 1 chunk +0 lines, -62 lines 0 comments Download
D mojo/shell/application_manager/test.mojom View 1 chunk +0 lines, -23 lines 0 comments Download
A + mojo/shell/application_manager_unittest.cc View 1 2 1 chunk +3 lines, -3 lines 0 comments Download
D mojo/shell/child_process.h View 1 chunk +0 lines, -17 lines 0 comments Download
D mojo/shell/child_process.cc View 1 chunk +0 lines, -321 lines 0 comments Download
D mojo/shell/child_process.mojom View 1 chunk +0 lines, -17 lines 0 comments Download
D mojo/shell/child_process_host.h View 1 chunk +0 lines, -86 lines 0 comments Download
D mojo/shell/child_process_host.cc View 1 2 1 chunk +0 lines, -163 lines 0 comments Download
D mojo/shell/child_process_host_unittest.cc View 1 chunk +0 lines, -63 lines 0 comments Download
D mojo/shell/context.h View 1 2 1 chunk +0 lines, -87 lines 0 comments Download
D mojo/shell/context.cc View 1 2 1 chunk +0 lines, -324 lines 0 comments Download
A + mojo/shell/data_pipe_peek.h View 2 chunks +3 lines, -3 lines 0 comments Download
A + mojo/shell/data_pipe_peek.cc View 1 chunk +1 line, -1 line 0 comments Download
D mojo/shell/data_pipe_peek_unittest.cc View 1 chunk +0 lines, -113 lines 0 comments Download
D mojo/shell/desktop/launcher_process.h View 1 chunk +0 lines, -17 lines 0 comments Download
D mojo/shell/desktop/launcher_process.cc View 1 chunk +0 lines, -136 lines 0 comments Download
D mojo/shell/desktop/main.cc View 1 chunk +0 lines, -24 lines 0 comments Download
A + mojo/shell/fetcher.h View 2 chunks +3 lines, -3 lines 0 comments Download
A + mojo/shell/fetcher.cc View 1 chunk +1 line, -1 line 0 comments Download
D mojo/shell/filename_util.h View 1 chunk +0 lines, -28 lines 0 comments Download
D mojo/shell/filename_util.cc View 1 chunk +0 lines, -72 lines 0 comments Download
A + mojo/shell/identity.h View 2 chunks +3 lines, -3 lines 0 comments Download
A + mojo/shell/identity.cc View 1 chunk +2 lines, -2 lines 0 comments Download
D mojo/shell/in_process_native_runner.h View 1 chunk +0 lines, -67 lines 0 comments Download
D mojo/shell/in_process_native_runner.cc View 1 chunk +0 lines, -72 lines 0 comments Download
D mojo/shell/in_process_native_runner_unittest.cc View 1 chunk +0 lines, -23 lines 0 comments Download
D mojo/shell/init.h View 1 chunk +0 lines, -18 lines 0 comments Download
D mojo/shell/init.cc View 1 chunk +0 lines, -24 lines 0 comments Download
A + mojo/shell/local_fetcher.h View 2 chunks +4 lines, -4 lines 0 comments Download
A + mojo/shell/local_fetcher.cc View 1 chunk +1 line, -1 line 0 comments Download
D mojo/shell/native_application_support.h View 1 chunk +0 lines, -51 lines 0 comments Download
D mojo/shell/native_application_support.cc View 1 chunk +0 lines, -145 lines 0 comments Download
A + mojo/shell/native_runner.h View 2 chunks +4 lines, -4 lines 0 comments Download
D mojo/shell/native_runner_unittest.cc View 1 2 1 chunk +0 lines, -101 lines 0 comments Download
A + mojo/shell/network_fetcher.h View 2 chunks +4 lines, -4 lines 0 comments Download
A + mojo/shell/network_fetcher.cc View 2 chunks +2 lines, -2 lines 0 comments Download
D mojo/shell/out_of_process_native_runner.h View 1 chunk +0 lines, -65 lines 0 comments Download
D mojo/shell/out_of_process_native_runner.cc View 1 chunk +0 lines, -72 lines 0 comments Download
A + mojo/shell/query_util.h View 2 chunks +3 lines, -3 lines 0 comments Download
A + mojo/shell/query_util.cc View 1 chunk +1 line, -1 line 0 comments Download
A + mojo/shell/query_util_unittest.cc View 1 chunk +1 line, -1 line 0 comments Download
D mojo/shell/shell_apptest.cc View 1 chunk +0 lines, -197 lines 0 comments Download
A + mojo/shell/shell_impl.h View 2 chunks +4 lines, -4 lines 0 comments Download
A + mojo/shell/shell_impl.cc View 1 chunk +2 lines, -2 lines 0 comments Download
D mojo/shell/shell_test_base.h View 1 chunk +0 lines, -59 lines 0 comments Download
D mojo/shell/shell_test_base.cc View 1 chunk +0 lines, -73 lines 0 comments Download
D mojo/shell/shell_test_base_android.cc View 1 chunk +0 lines, -47 lines 0 comments Download
D mojo/shell/shell_test_base_unittest.cc View 1 chunk +0 lines, -309 lines 0 comments Download
D mojo/shell/shell_test_main.cc View 1 chunk +0 lines, -30 lines 0 comments Download
M mojo/shell/switches.h View 2 chunks +3 lines, -14 lines 0 comments Download
M mojo/shell/switches.cc View 2 chunks +0 lines, -47 lines 0 comments Download
D mojo/shell/task_runners.h View 1 chunk +0 lines, -53 lines 0 comments Download
D mojo/shell/task_runners.cc View 1 chunk +0 lines, -39 lines 0 comments Download
A + mojo/shell/test.mojom View 0 chunks +-1 lines, --1 lines 0 comments Download
D mojo/shell/test/BUILD.gn View 1 chunk +0 lines, -28 lines 0 comments Download
D mojo/shell/test/pingable.mojom View 1 chunk +0 lines, -9 lines 0 comments Download
D mojo/shell/test/pingable_app.cc View 1 chunk +0 lines, -69 lines 0 comments Download
D mojo/shell/url_resolver.h View 1 chunk +0 lines, -79 lines 0 comments Download
D mojo/shell/url_resolver.cc View 1 chunk +0 lines, -118 lines 0 comments Download
D mojo/shell/url_resolver_unittest.cc View 1 chunk +0 lines, -150 lines 0 comments Download
M mojo/tools/mopy/paths.py View 1 2 3 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 7 (2 generated)
Ben Goodger (Google)
5 years, 8 months ago (2015-04-27 19:23:42 UTC) #1
sky
LGTM https://codereview.chromium.org/1091513005/diff/40001/mojo/runner/BUILD.gn File mojo/runner/BUILD.gn (right): https://codereview.chromium.org/1091513005/diff/40001/mojo/runner/BUILD.gn#newcode406 mojo/runner/BUILD.gn:406: "//mojo/runner/test:bindings", nit: sort.
5 years, 8 months ago (2015-04-27 19:25:30 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1091513005/60001
5 years, 8 months ago (2015-04-27 21:28:36 UTC) #5
commit-bot: I haz the power
Committed patchset #4 (id:60001)
5 years, 8 months ago (2015-04-27 21:53:06 UTC) #6
commit-bot: I haz the power
5 years, 8 months ago (2015-04-27 21:53:58 UTC) #7
Message was sent while issue was closed. 
Patchset 4 (id:??) landed as
https://crrev.com/ee05293936b654dfbc42889ba374bba21bd5c453
Cr-Commit-Position: refs/heads/master@{#327148}

Powered by Google App Engine
This is Rietveld 408576698