Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(707)

Unified Diff: mojo/shell/android/ui_application_loader_android.h

Issue 1091513005: Separate mojo/shell into a runner and the application manager (shell) (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: . Created 5 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: mojo/shell/android/ui_application_loader_android.h
diff --git a/mojo/shell/android/ui_application_loader_android.h b/mojo/shell/android/ui_application_loader_android.h
deleted file mode 100644
index 37cc063d8b90d43963e04f41956328f63b643875..0000000000000000000000000000000000000000
--- a/mojo/shell/android/ui_application_loader_android.h
+++ /dev/null
@@ -1,54 +0,0 @@
-// Copyright 2014 The Chromium Authors. All rights reserved.
-// Use of this source code is governed by a BSD-style license that can be
-// found in the LICENSE file.
-
-#ifndef SHELL_ANDROID_UI_APPLICATION_LOADER_ANDROID_H_
-#define SHELL_ANDROID_UI_APPLICATION_LOADER_ANDROID_H_
-
-#include "base/macros.h"
-#include "base/memory/scoped_ptr.h"
-#include "mojo/shell/application_manager/application_loader.h"
-
-namespace base {
-class MessageLoop;
-}
-
-namespace mojo {
-namespace shell {
-
-class ApplicationManager;
-
-// ApplicationLoader implementation that creates a background thread and issues
-// load
-// requests there.
-class UIApplicationLoader : public ApplicationLoader {
- public:
- UIApplicationLoader(scoped_ptr<ApplicationLoader> real_loader,
- base::MessageLoop* ui_message_loop);
- ~UIApplicationLoader() override;
-
- // ApplicationLoader overrides:
- void Load(const GURL& url,
- InterfaceRequest<Application> application_request) override;
-
- private:
- class UILoader;
-
- // These functions are exected on the background thread. They call through
- // to |background_loader_| to do the actual loading.
- // TODO: having this code take a |manager| is fragile (as ApplicationManager
- // isn't thread safe).
- void LoadOnUIThread(const GURL& url,
- InterfaceRequest<Application> application_request);
- void ShutdownOnUIThread();
-
- scoped_ptr<ApplicationLoader> loader_;
- base::MessageLoop* ui_message_loop_;
-
- DISALLOW_COPY_AND_ASSIGN(UIApplicationLoader);
-};
-
-} // namespace shell
-} // namespace mojo
-
-#endif // SHELL_ANDROID_UI_APPLICATION_LOADER_ANDROID_H_

Powered by Google App Engine
This is Rietveld 408576698