Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1699)

Unified Diff: mojo/shell/child_process_host.h

Issue 1091513005: Separate mojo/shell into a runner and the application manager (shell) (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: . Created 5 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « mojo/shell/child_process.mojom ('k') | mojo/shell/child_process_host.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: mojo/shell/child_process_host.h
diff --git a/mojo/shell/child_process_host.h b/mojo/shell/child_process_host.h
deleted file mode 100644
index bc302064255d6febda7bbd0fd42818a806a8bd7a..0000000000000000000000000000000000000000
--- a/mojo/shell/child_process_host.h
+++ /dev/null
@@ -1,86 +0,0 @@
-// Copyright 2014 The Chromium Authors. All rights reserved.
-// Use of this source code is governed by a BSD-style license that can be
-// found in the LICENSE file.
-
-#ifndef SHELL_CHILD_PROCESS_HOST_H_
-#define SHELL_CHILD_PROCESS_HOST_H_
-
-#include "base/macros.h"
-#include "base/process/process.h"
-#include "mojo/edk/embedder/channel_info_forward.h"
-#include "mojo/edk/embedder/platform_channel_pair.h"
-#include "mojo/edk/embedder/scoped_platform_handle.h"
-#include "mojo/shell/child_process.mojom.h"
-#include "mojo/shell/child_process_host.h"
-
-namespace mojo {
-namespace shell {
-
-class Context;
-
-// This class represents a "child process host". Handles launching and
-// connecting a platform-specific "pipe" to the child, and supports joining the
-// child process. Currently runs a single app (loaded from the file system).
-//
-// This class is not thread-safe. It should be created/used/destroyed on a
-// single thread.
-//
-// Note: Does not currently work on Windows before Vista.
-// Note: After |Start()|, |StartApp| must be called and this object must
-// remained alive until the |on_app_complete| callback is called.
-class ChildProcessHost {
- public:
- // |name| is just for debugging ease.
- ChildProcessHost(Context* context, const std::string& name);
- virtual ~ChildProcessHost();
-
- // |Start()|s the child process; calls |DidStart()| (on the thread on which
- // |Start()| was called) when the child has been started (or failed to start).
- // After calling |Start()|, this object must not be destroyed until
- // |DidStart()| has been called.
- // TODO(vtl): Consider using weak pointers and removing this requirement.
- void Start();
-
- // Waits for the child process to terminate, and returns its exit code.
- // Note: If |Start()| has been called, this must not be called until the
- // callback has been called.
- int Join();
-
- // See |ChildController|:
- void StartApp(const String& app_path,
- bool clean_app_path,
- InterfaceRequest<Application> application_request,
- const ChildController::StartAppCallback& on_app_complete);
- void ExitNow(int32_t exit_code);
-
- protected:
- // virtual for testing.
- virtual void DidStart(bool success);
-
- private:
- bool DoLaunch();
-
- void AppCompleted(int32_t result);
-
- // Callback for |embedder::CreateChannel()|.
- void DidCreateChannel(embedder::ChannelInfo* channel_info);
-
- Context* const context_;
- const std::string name_;
- base::Process child_process_;
- embedder::PlatformChannelPair platform_channel_pair_;
- ChildControllerPtr controller_;
- embedder::ChannelInfo* channel_info_;
- ChildController::StartAppCallback on_app_complete_;
-
- // Platform-specific "pipe" to the child process. Valid immediately after
- // creation.
- embedder::ScopedPlatformHandle platform_channel_;
-
- DISALLOW_COPY_AND_ASSIGN(ChildProcessHost);
-};
-
-} // namespace shell
-} // namespace mojo
-
-#endif // SHELL_CHILD_PROCESS_HOST_H_
« no previous file with comments | « mojo/shell/child_process.mojom ('k') | mojo/shell/child_process_host.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698