Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(7)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1090413003: [chrome/browser/sync && sync_file_system] favor DCHECK_CURRENTLY_ON for better logs (Closed)

Created:
5 years, 8 months ago by anujsharma
Modified:
5 years, 8 months ago
Reviewers:
maniscalco, nhiroki
CC:
chromium-reviews, Mostyn Bramley-Moore
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

favor DCHECK_CURRENTLY_ON for better logs in chrome/browser/sync and sync_file_system BUG=466848 Committed: https://crrev.com/86194487d0cdf451b1177477828c8870b9cbd10c Cr-Commit-Position: refs/heads/master@{#326465}

Patch Set 1 #

Patch Set 2 : Fixed nits #

Patch Set 3 : Fixed build breaks #

Unified diffs Side-by-side diffs Delta from patch set Stats (+119 lines, -119 lines) Patch
M chrome/browser/sync/glue/autofill_data_type_controller.cc View 2 chunks +5 lines, -5 lines 0 comments Download
M chrome/browser/sync/glue/autofill_profile_data_type_controller.cc View 3 chunks +5 lines, -5 lines 0 comments Download
M chrome/browser/sync/glue/autofill_wallet_data_type_controller.cc View 1 6 chunks +7 lines, -7 lines 0 comments Download
M chrome/browser/sync/glue/bookmark_change_processor.cc View 3 chunks +3 lines, -3 lines 0 comments Download
M chrome/browser/sync/glue/bookmark_data_type_controller.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/sync/glue/bookmark_model_associator.cc View 3 chunks +5 lines, -5 lines 0 comments Download
M chrome/browser/sync/glue/extension_setting_data_type_controller.cc View 2 chunks +3 lines, -3 lines 0 comments Download
M chrome/browser/sync/glue/frontend_data_type_controller.cc View 10 chunks +10 lines, -10 lines 0 comments Download
M chrome/browser/sync/glue/history_model_worker.cc View 1 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/sync/glue/non_frontend_data_type_controller.cc View 12 chunks +13 lines, -13 lines 0 comments Download
M chrome/browser/sync/glue/password_data_type_controller.cc View 2 chunks +3 lines, -3 lines 0 comments Download
M chrome/browser/sync/glue/search_engine_data_type_controller.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/sync/glue/sync_backend_host_impl.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/sync/glue/sync_backend_host_impl_unittest.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/sync/glue/sync_backend_registrar.cc View 3 chunks +3 lines, -3 lines 0 comments Download
M chrome/browser/sync/glue/typed_url_change_processor.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/sync/glue/typed_url_data_type_controller.cc View 3 chunks +3 lines, -3 lines 0 comments Download
M chrome/browser/sync/profile_sync_service_android.cc View 15 chunks +35 lines, -35 lines 0 comments Download
M chrome/browser/sync/profile_sync_service_autofill_unittest.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/sync/profile_sync_test_util.h View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/sync/profile_sync_test_util.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/sync/sessions/session_data_type_controller.cc View 5 chunks +5 lines, -5 lines 0 comments Download
M chrome/browser/sync/test/integration/autofill_helper.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M chrome/browser/sync_file_system/local/local_file_sync_service.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M chrome/browser/sync_file_system/sync_file_system_service.cc View 6 chunks +6 lines, -6 lines 0 comments Download

Messages

Total messages: 13 (4 generated)
anujsharma
nhiroki@chromium.org: Please review changes in chrome/browser/sync_file_system module maniscalco@chromium.org: Please review changes in chrome/browser/sync module
5 years, 8 months ago (2015-04-22 12:09:28 UTC) #2
maniscalco
chrome/browser/sync lgtm
5 years, 8 months ago (2015-04-22 17:46:18 UTC) #3
nhiroki
chrome/browser/sync_file_system lgtm
5 years, 8 months ago (2015-04-22 22:33:16 UTC) #4
anujsharma
On 2015/04/22 22:33:16, nhiroki wrote: > chrome/browser/sync_file_system lgtm thanks maniscalco and nhiroki for lgtm.
5 years, 8 months ago (2015-04-23 02:11:53 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1090413003/40001
5 years, 8 months ago (2015-04-23 02:13:31 UTC) #7
commit-bot: I haz the power
Try jobs failed on following builders: linux_chromium_gn_chromeos_rel on tryserver.chromium.linux (JOB_TIMED_OUT, http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_gn_chromeos_rel/builds/30222)
5 years, 8 months ago (2015-04-23 06:18:03 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1090413003/40001
5 years, 8 months ago (2015-04-23 06:20:32 UTC) #11
commit-bot: I haz the power
Committed patchset #3 (id:40001)
5 years, 8 months ago (2015-04-23 06:38:30 UTC) #12
commit-bot: I haz the power
5 years, 8 months ago (2015-04-23 06:39:31 UTC) #13
Message was sent while issue was closed. 
Patchset 3 (id:??) landed as
https://crrev.com/86194487d0cdf451b1177477828c8870b9cbd10c
Cr-Commit-Position: refs/heads/master@{#326465}

Powered by Google App Engine
This is Rietveld 408576698