chrome/browser/sync/glue/bookmark_change_processor.cc - Issue 1090413003: [chrome/browser/sync && sync_file_system] favor DCHECK_CURRENTLY_ON for better logs

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/sync/glue/bookmark_change_processor.cc

Issue 1090413003: [chrome/browser/sync && sync_file_system] favor DCHECK_CURRENTLY_ON for better logs (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Fixed build breaks Created 5 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/browser/sync/glue/autofill_wallet_data_type_controller.cc ('k') | chrome/browser/sync/glue/bookmark_data_type_controller.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/sync/glue/bookmark_change_processor.cc

diff --git a/chrome/browser/sync/glue/bookmark_change_processor.cc b/chrome/browser/sync/glue/bookmark_change_processor.cc

index ad7ab852baacadd3bfa1b726fb693b382e40beea..0336a78b604ce21d8f3eefc68c6b27f01db88495 100644

--- a/chrome/browser/sync/glue/bookmark_change_processor.cc

+++ b/chrome/browser/sync/glue/bookmark_change_processor.cc

@@ -54,7 +54,7 @@ BookmarkChangeProcessor::BookmarkChangeProcessor(

bookmark_model_(NULL),

profile_(profile),

model_associator_(model_associator) {

- DCHECK(BrowserThread::CurrentlyOn(BrowserThread::UI));

+ DCHECK_CURRENTLY_ON(BrowserThread::UI);

DCHECK(model_associator);

DCHECK(profile);

DCHECK(error_handler);

@@ -66,7 +66,7 @@ BookmarkChangeProcessor::~BookmarkChangeProcessor() {

}

void BookmarkChangeProcessor::StartImpl() {

- DCHECK(BrowserThread::CurrentlyOn(BrowserThread::UI));

+ DCHECK_CURRENTLY_ON(BrowserThread::UI);

DCHECK(!bookmark_model_);

bookmark_model_ = BookmarkModelFactory::GetForProfile(profile_);

DCHECK(bookmark_model_->loaded());

@@ -524,7 +524,7 @@ void BookmarkChangeProcessor::ApplyChangesFromSyncModel(

const syncer::BaseTransaction* trans,

int64 model_version,

const syncer::ImmutableChangeRecordList& changes) {

- DCHECK(BrowserThread::CurrentlyOn(BrowserThread::UI));

+ DCHECK_CURRENTLY_ON(BrowserThread::UI);

// A note about ordering. Sync backend is responsible for ordering the change

// records in the following order: