chrome/browser/sync_file_system/local/local_file_sync_service.cc - Issue 1090413003: [chrome/browser/sync && sync_file_system] favor DCHECK_CURRENTLY_ON for better logs

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/sync_file_system/local/local_file_sync_service.cc

Issue 1090413003: [chrome/browser/sync && sync_file_system] favor DCHECK_CURRENTLY_ON for better logs (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Fixed build breaks Created 5 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/browser/sync/test/integration/autofill_helper.cc ('k') | chrome/browser/sync_file_system/sync_file_system_service.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/sync_file_system/local/local_file_sync_service.cc

diff --git a/chrome/browser/sync_file_system/local/local_file_sync_service.cc b/chrome/browser/sync_file_system/local/local_file_sync_service.cc

index 51ab55a64687005c26b8e323bbeadded32da2284..b9c76f7469adef148d748559f66844d76d851da5 100644

--- a/chrome/browser/sync_file_system/local/local_file_sync_service.cc

+++ b/chrome/browser/sync_file_system/local/local_file_sync_service.cc

@@ -120,7 +120,7 @@ scoped_ptr<LocalFileSyncService> LocalFileSyncService::CreateForTesting(

}

LocalFileSyncService::~LocalFileSyncService() {

- DCHECK(BrowserThread::CurrentlyOn(BrowserThread::UI));

+ DCHECK_CURRENTLY_ON(BrowserThread::UI);

}

void LocalFileSyncService::Shutdown() {

@@ -350,7 +350,7 @@ LocalFileSyncService::LocalFileSyncService(Profile* profile,

BrowserThread::GetMessageLoopProxyForThread(BrowserThread::IO)

.get())),

local_change_processor_(nullptr) {

- DCHECK(BrowserThread::CurrentlyOn(BrowserThread::UI));

+ DCHECK_CURRENTLY_ON(BrowserThread::UI);

sync_context_->AddOriginChangeObserver(this);

}