chrome/browser/sync/test/integration/autofill_helper.cc - Issue 1090413003: [chrome/browser/sync && sync_file_system] favor DCHECK_CURRENTLY_ON for better logs

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/sync/test/integration/autofill_helper.cc

Issue 1090413003: [chrome/browser/sync && sync_file_system] favor DCHECK_CURRENTLY_ON for better logs (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Fixed build breaks Created 5 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/browser/sync/sessions/session_data_type_controller.cc ('k') | chrome/browser/sync_file_system/local/local_file_sync_service.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/sync/test/integration/autofill_helper.cc

diff --git a/chrome/browser/sync/test/integration/autofill_helper.cc b/chrome/browser/sync/test/integration/autofill_helper.cc

index b5877fc5c3692043629ba94b0470ca1de15bdf17..957de84de9b5faff4cda647a1a9d6bd0010104a9 100644

--- a/chrome/browser/sync/test/integration/autofill_helper.cc

+++ b/chrome/browser/sync/test/integration/autofill_helper.cc

@@ -101,14 +101,14 @@ void RemoveKeyDontBlockForSync(int profile, const AutofillKey& key) {

void GetAllAutofillEntriesOnDBThread(AutofillWebDataService* wds,

std::vector<AutofillEntry>* entries) {

- DCHECK(BrowserThread::CurrentlyOn(BrowserThread::DB));

+ DCHECK_CURRENTLY_ON(BrowserThread::DB);

AutofillTable::FromWebDatabase(

wds->GetDatabase())->GetAllAutofillEntries(entries);

}

std::vector<AutofillEntry> GetAllAutofillEntries(AutofillWebDataService* wds) {

std::vector<AutofillEntry> entries;

- DCHECK(BrowserThread::CurrentlyOn(BrowserThread::UI));

+ DCHECK_CURRENTLY_ON(BrowserThread::UI);

RunOnDBThreadAndBlock(Bind(&GetAllAutofillEntriesOnDBThread,

Unretained(wds),

&entries));