chrome/browser/sync/glue/sync_backend_registrar.cc - Issue 1090413003: [chrome/browser/sync && sync_file_system] favor DCHECK_CURRENTLY_ON for better logs

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/sync/glue/sync_backend_registrar.cc

Issue 1090413003: [chrome/browser/sync && sync_file_system] favor DCHECK_CURRENTLY_ON for better logs (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Fixed build breaks Created 5 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/browser/sync/glue/sync_backend_host_impl_unittest.cc ('k') | chrome/browser/sync/glue/typed_url_change_processor.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/sync/glue/sync_backend_registrar.cc

diff --git a/chrome/browser/sync/glue/sync_backend_registrar.cc b/chrome/browser/sync/glue/sync_backend_registrar.cc

index bcddbb28f7eef51f418efc6ee13d758967654b23..d7b22c7c6cb62b7154d08f8b04632cdcee16c870 100644

--- a/chrome/browser/sync/glue/sync_backend_registrar.cc

+++ b/chrome/browser/sync/glue/sync_backend_registrar.cc

@@ -61,7 +61,7 @@ SyncBackendRegistrar::SyncBackendRegistrar(

scoped_ptr<base::Thread> sync_thread) :

name_(name),

profile_(profile) {

- DCHECK(BrowserThread::CurrentlyOn(BrowserThread::UI));

+ DCHECK_CURRENTLY_ON(BrowserThread::UI);

CHECK(profile_);

// TODO(pavely): Remove ScopedTracker below once crbug.com/426272 is fixed.

@@ -148,7 +148,7 @@ void SyncBackendRegistrar::SetInitialTypes(syncer::ModelTypeSet initial_types) {

}

bool SyncBackendRegistrar::IsNigoriEnabled() const {

- DCHECK(BrowserThread::CurrentlyOn(BrowserThread::UI));

+ DCHECK_CURRENTLY_ON(BrowserThread::UI);

base::AutoLock lock(lock_);

return routing_info_.find(syncer::NIGORI) != routing_info_.end();

}

@@ -203,7 +203,7 @@ syncer::ModelTypeSet SyncBackendRegistrar::GetLastConfiguredTypes() const {

}

void SyncBackendRegistrar::RequestWorkerStopOnUIThread() {

- DCHECK(BrowserThread::CurrentlyOn(BrowserThread::UI));

+ DCHECK_CURRENTLY_ON(BrowserThread::UI);

base::AutoLock lock(lock_);

for (WorkerMap::const_iterator it = workers_.begin();

it != workers_.end(); ++it) {