Change beforeinstallprompt event to take an array of platforms.

Change beforeinstallprompt event to take an array of platforms.

Currently it just takes a single platform.

BUG=460945
Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=194004

[benwells, 2015-04-16 10:08:33]

benwells@chromium.org changed reviewers:
+ mlamouri@chromium.org

[benwells, 2015-04-16 10:08:33]

benwells@chromium.org changed reviewers:
+ mlamouri@chromium.org

[benwells, 2015-04-16 10:08:33]

This chromium patch will need to land before this:
https://codereview.chromium.org/1090863002/

[benwells, 2015-04-16 10:08:34]

This chromium patch will need to land before this:
https://codereview.chromium.org/1090863002/

[mlamouri (slow - plz ping), 2015-04-16 10:32:22]

Looks great! lgtm

https://codereview.chromium.org/1089813002/diff/1/Source/modules/app_banner/B...
File Source/modules/app_banner/BeforeInstallPromptEvent.cpp (left):

https://codereview.chromium.org/1089813002/diff/1/Source/modules/app_banner/B...
Source/modules/app_banner/BeforeInstallPromptEvent.cpp:27: ,
m_platform(init.platform())
, m_platforms(init.platforms())

https://codereview.chromium.org/1089813002/diff/1/Source/modules/app_banner/B...
File Source/modules/app_banner/BeforeInstallPromptEventInit.idl (left):

https://codereview.chromium.org/1089813002/diff/1/Source/modules/app_banner/B...
Source/modules/app_banner/BeforeInstallPromptEventInit.idl:6: DOMString platform
= "web";
DOMString[] platforms = [];

[benwells, 2015-04-16 11:39:59]

https://codereview.chromium.org/1089813002/diff/1/Source/modules/app_banner/B...
File Source/modules/app_banner/BeforeInstallPromptEventInit.idl (left):

https://codereview.chromium.org/1089813002/diff/1/Source/modules/app_banner/B...
Source/modules/app_banner/BeforeInstallPromptEventInit.idl:6: DOMString platform
= "web";
On 2015/04/16 10:32:21, Mounir Lamouri wrote:
> DOMString[] platforms = [];

I tried that but got an error in the v8 code generator at compile time. Any
ideas? This is the error:

FAILED: cd ../../third_party/WebKit/Source/bindings/modules/v8; python
../../scripts/idl_compiler.py --cache-dir
../../../../../../out/Debug/gen/blink/bindings/scripts --output-dir
../../../../../../out/Debug/gen/blink/bindings/modules/v8 --info-dir
../../../../../../out/Debug/gen/blink/bindings/ --target-component modules
--write-file-only-if-changed 1
"../../../modules/app_banner/BeforeInstallPromptEventInit.idl"
Traceback (most recent call last):
  File "../../scripts/idl_compiler.py", line 202, in <module>
    sys.exit(main())
  File "../../scripts/idl_compiler.py", line 198, in main
    generate_bindings(options, input_filename)
  File "../../scripts/idl_compiler.py", line 156, in generate_bindings
    idl_compiler.compile_file(input_filename)
  File "../../scripts/idl_compiler.py", line 134, in compile_file
    self.compile_and_write(idl_filename)
  File "../../scripts/idl_compiler.py", line 117, in compile_and_write
    target_definitions, interface_name)
  File
"/usr/local/google/home/benwells/Projects/clankium/src/third_party/WebKit/Source/bindings/scripts/code_generator_v8.py",
line 183, in generate_code
    return self.generate_code_internal(definitions, definition_name)
  File
"/usr/local/google/home/benwells/Projects/clankium/src/third_party/WebKit/Source/bindings/scripts/code_generator_v8.py",
line 208, in generate_code_internal
    definitions.dictionaries[definition_name])
  File
"/usr/local/google/home/benwells/Projects/clankium/src/third_party/WebKit/Source/bindings/scripts/code_generator_v8.py",
line 265, in generate_dictionary_code
    dictionary, interfaces_info)
  File
"/usr/local/google/home/benwells/Projects/clankium/src/third_party/WebKit/Source/bindings/scripts/v8_dictionary.py",
line 62, in dictionary_context
    key=operator.attrgetter('name'))],
  File
"/usr/local/google/home/benwells/Projects/clankium/src/third_party/WebKit/Source/bindings/scripts/v8_dictionary.py",
line 100, in member_context
    cpp_default_value, v8_default_value = default_values()
  File
"/usr/local/google/home/benwells/Projects/clankium/src/third_party/WebKit/Source/bindings/scripts/v8_dictionary.py",
line 94, in default_values
    member.default_value)
TypeError: 'NoneType' object is not callable

[mlamouri (slow - plz ping), 2015-04-16 13:33:27]

https://codereview.chromium.org/1089813002/diff/1/Source/modules/app_banner/B...
File Source/modules/app_banner/BeforeInstallPromptEvent.cpp (left):

https://codereview.chromium.org/1089813002/diff/1/Source/modules/app_banner/B...
Source/modules/app_banner/BeforeInstallPromptEvent.cpp:27: ,
m_platform(init.platform())
On 2015/04/16 at 10:32:21, Mounir Lamouri wrote:
> , m_platforms(init.platforms())

Keep this.

https://codereview.chromium.org/1089813002/diff/1/Source/modules/app_banner/B...
File Source/modules/app_banner/BeforeInstallPromptEventInit.idl (left):

https://codereview.chromium.org/1089813002/diff/1/Source/modules/app_banner/B...
Source/modules/app_banner/BeforeInstallPromptEventInit.idl:6: DOMString platform
= "web";
On 2015/04/16 at 11:39:59, benwells wrote:
> On 2015/04/16 10:32:21, Mounir Lamouri wrote:
> > DOMString[] platforms = [];
> 
> I tried that but got an error in the v8 code generator at compile time. Any
ideas? This is the error:
> 
> FAILED: cd ../../third_party/WebKit/Source/bindings/modules/v8; python
../../scripts/idl_compiler.py --cache-dir
../../../../../../out/Debug/gen/blink/bindings/scripts --output-dir
../../../../../../out/Debug/gen/blink/bindings/modules/v8 --info-dir
../../../../../../out/Debug/gen/blink/bindings/ --target-component modules
--write-file-only-if-changed 1
"../../../modules/app_banner/BeforeInstallPromptEventInit.idl"
> Traceback (most recent call last):
>   File "../../scripts/idl_compiler.py", line 202, in <module>
>     sys.exit(main())
>   File "../../scripts/idl_compiler.py", line 198, in main
>     generate_bindings(options, input_filename)
>   File "../../scripts/idl_compiler.py", line 156, in generate_bindings
>     idl_compiler.compile_file(input_filename)
>   File "../../scripts/idl_compiler.py", line 134, in compile_file
>     self.compile_and_write(idl_filename)
>   File "../../scripts/idl_compiler.py", line 117, in compile_and_write
>     target_definitions, interface_name)
>   File
"/usr/local/google/home/benwells/Projects/clankium/src/third_party/WebKit/Source/bindings/scripts/code_generator_v8.py",
line 183, in generate_code
>     return self.generate_code_internal(definitions, definition_name)
>   File
"/usr/local/google/home/benwells/Projects/clankium/src/third_party/WebKit/Source/bindings/scripts/code_generator_v8.py",
line 208, in generate_code_internal
>     definitions.dictionaries[definition_name])
>   File
"/usr/local/google/home/benwells/Projects/clankium/src/third_party/WebKit/Source/bindings/scripts/code_generator_v8.py",
line 265, in generate_dictionary_code
>     dictionary, interfaces_info)
>   File
"/usr/local/google/home/benwells/Projects/clankium/src/third_party/WebKit/Source/bindings/scripts/v8_dictionary.py",
line 62, in dictionary_context
>     key=operator.attrgetter('name'))],
>   File
"/usr/local/google/home/benwells/Projects/clankium/src/third_party/WebKit/Source/bindings/scripts/v8_dictionary.py",
line 100, in member_context
>     cpp_default_value, v8_default_value = default_values()
>   File
"/usr/local/google/home/benwells/Projects/clankium/src/third_party/WebKit/Source/bindings/scripts/v8_dictionary.py",
line 94, in default_values
>     member.default_value)
> TypeError: 'NoneType' object is not callable

Checking the spec and asking the editor, it's actually not possible to have
default values for dictionary :(

Please keep:
DOMString[] platforms;

[mlamouri (slow - plz ping), 2015-04-16 13:34:02]

https://codereview.chromium.org/1089813002/diff/1/Source/modules/app_banner/B...
File Source/modules/app_banner/BeforeInstallPromptEvent.cpp (left):

https://codereview.chromium.org/1089813002/diff/1/Source/modules/app_banner/B...
Source/modules/app_banner/BeforeInstallPromptEvent.cpp:27: ,
m_platform(init.platform())
On 2015/04/16 at 13:33:27, Mounir Lamouri wrote:
> On 2015/04/16 at 10:32:21, Mounir Lamouri wrote:
> > , m_platforms(init.platforms())
> 
> Keep this.

I realise that might not be clear. I mean that this comment still applies.

[mlamouri (slow - plz ping), 2015-04-16 14:28:09]

Hmm, actually, after talking about this on IRC, it seems that we should be using
sequence<DOMString> instead of DOMString[].

[benwells, 2015-04-17 06:58:52]

benwells@chromium.org changed reviewers:
+ jochen@chromium.org

[benwells, 2015-04-17 06:58:53]

Converted to sequence.

+jochen for owners review of Source/web and public/web.

https://codereview.chromium.org/1089813002/diff/1/Source/modules/app_banner/B...
File Source/modules/app_banner/BeforeInstallPromptEvent.cpp (left):

https://codereview.chromium.org/1089813002/diff/1/Source/modules/app_banner/B...
Source/modules/app_banner/BeforeInstallPromptEvent.cpp:27: ,
m_platform(init.platform())
On 2015/04/16 13:34:01, Mounir Lamouri wrote:
> On 2015/04/16 at 13:33:27, Mounir Lamouri wrote:
> > On 2015/04/16 at 10:32:21, Mounir Lamouri wrote:
> > > , m_platforms(init.platforms())
> > 
> > Keep this.
> 
> I realise that might not be clear. I mean that this comment still applies.

Done.

https://codereview.chromium.org/1089813002/diff/1/Source/modules/app_banner/B...
File Source/modules/app_banner/BeforeInstallPromptEventInit.idl (left):

https://codereview.chromium.org/1089813002/diff/1/Source/modules/app_banner/B...
Source/modules/app_banner/BeforeInstallPromptEventInit.idl:6: DOMString platform
= "web";
On 2015/04/16 13:33:27, Mounir Lamouri wrote:
> On 2015/04/16 at 11:39:59, benwells wrote:
> > On 2015/04/16 10:32:21, Mounir Lamouri wrote:
> > > DOMString[] platforms = [];
> > 
> > I tried that but got an error in the v8 code generator at compile time. Any
> ideas? This is the error:
> > 
> > FAILED: cd ../../third_party/WebKit/Source/bindings/modules/v8; python
> ../../scripts/idl_compiler.py --cache-dir
> ../../../../../../out/Debug/gen/blink/bindings/scripts --output-dir
> ../../../../../../out/Debug/gen/blink/bindings/modules/v8 --info-dir
> ../../../../../../out/Debug/gen/blink/bindings/ --target-component modules
> --write-file-only-if-changed 1
> "../../../modules/app_banner/BeforeInstallPromptEventInit.idl"
> > Traceback (most recent call last):
> >   File "../../scripts/idl_compiler.py", line 202, in <module>
> >     sys.exit(main())
> >   File "../../scripts/idl_compiler.py", line 198, in main
> >     generate_bindings(options, input_filename)
> >   File "../../scripts/idl_compiler.py", line 156, in generate_bindings
> >     idl_compiler.compile_file(input_filename)
> >   File "../../scripts/idl_compiler.py", line 134, in compile_file
> >     self.compile_and_write(idl_filename)
> >   File "../../scripts/idl_compiler.py", line 117, in compile_and_write
> >     target_definitions, interface_name)
> >   File
>
"/usr/local/google/home/benwells/Projects/clankium/src/third_party/WebKit/Source/bindings/scripts/code_generator_v8.py",
> line 183, in generate_code
> >     return self.generate_code_internal(definitions, definition_name)
> >   File
>
"/usr/local/google/home/benwells/Projects/clankium/src/third_party/WebKit/Source/bindings/scripts/code_generator_v8.py",
> line 208, in generate_code_internal
> >     definitions.dictionaries[definition_name])
> >   File
>
"/usr/local/google/home/benwells/Projects/clankium/src/third_party/WebKit/Source/bindings/scripts/code_generator_v8.py",
> line 265, in generate_dictionary_code
> >     dictionary, interfaces_info)
> >   File
>
"/usr/local/google/home/benwells/Projects/clankium/src/third_party/WebKit/Source/bindings/scripts/v8_dictionary.py",
> line 62, in dictionary_context
> >     key=operator.attrgetter('name'))],
> >   File
>
"/usr/local/google/home/benwells/Projects/clankium/src/third_party/WebKit/Source/bindings/scripts/v8_dictionary.py",
> line 100, in member_context
> >     cpp_default_value, v8_default_value = default_values()
> >   File
>
"/usr/local/google/home/benwells/Projects/clankium/src/third_party/WebKit/Source/bindings/scripts/v8_dictionary.py",
> line 94, in default_values
> >     member.default_value)
> > TypeError: 'NoneType' object is not callable
> 
> Checking the spec and asking the editor, it's actually not possible to have
> default values for dictionary :(
> 
> Please keep:
> DOMString[] platforms;

Done.

[mlamouri (slow - plz ping), 2015-04-17 10:43:08]

still lgtm

[jochen (gone - plz use gerrit), 2015-04-17 11:24:50]

lgtm

[benwells, 2015-04-17 12:54:59]

The CQ bit was checked by benwells@chromium.org

[commit-bot: I haz the power, 2015-04-17 12:55:09]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1089813002/20001

[commit-bot: I haz the power, 2015-04-17 16:38:46]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2015-04-17 16:38:47]

Try jobs failed on following builders:
  win_blink_rel on tryserver.blink (JOB_FAILED,
http://build.chromium.org/p/tryserver.blink/builders/win_blink_rel/builds/59653)

[benwells, 2015-04-19 22:36:53]

The CQ bit was checked by benwells@chromium.org

[commit-bot: I haz the power, 2015-04-19 22:37:05]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1089813002/20001

[commit-bot: I haz the power, 2015-04-20 02:15:03]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2015-04-20 02:15:04]

Try jobs failed on following builders:
  linux_blink_rel on tryserver.blink (JOB_FAILED,
http://build.chromium.org/p/tryserver.blink/builders/linux_blink_rel/builds/5...)

[benwells, 2015-04-20 06:34:01]

The CQ bit was checked by benwells@chromium.org

[benwells, 2015-04-20 06:34:01]

The patchset sent to the CQ was uploaded after l-g-t-m from jochen@chromium.org,
mlamouri@chromium.org
Link to the patchset: https://codereview.chromium.org/1089813002/#ps40001
(title: "Update test expectations")

[commit-bot: I haz the power, 2015-04-20 06:34:18]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1089813002/40001

[commit-bot: I haz the power, 2015-04-20 08:44:27]

Committed patchset #3 (id:40001) as
https://src.chromium.org/viewvc/blink?view=rev&revision=194004