Source/modules/app_banner/BeforeInstallPromptEvent.idl - Issue 1089813002: Change beforeinstallprompt event to take an array of platforms.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: Source/modules/app_banner/BeforeInstallPromptEvent.idl

Issue 1089813002: Change beforeinstallprompt event to take an array of platforms. (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master

Patch Set: Update test expectations Created 5 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « Source/modules/app_banner/BeforeInstallPromptEvent.cpp ('k') | Source/modules/app_banner/BeforeInstallPromptEventInit.idl » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: Source/modules/app_banner/BeforeInstallPromptEvent.idl

diff --git a/Source/modules/app_banner/BeforeInstallPromptEvent.idl b/Source/modules/app_banner/BeforeInstallPromptEvent.idl

index 1444c7e5716d1f70a68568e772dd2d3686e16816..133bbd49da99570675de0398ab7fc91d3fd28631 100644

--- a/Source/modules/app_banner/BeforeInstallPromptEvent.idl

+++ b/Source/modules/app_banner/BeforeInstallPromptEvent.idl

@@ -6,6 +6,6 @@

Constructor(DOMString platform, optional BeforeInstallPromptEventInit eventInitDict),

RuntimeEnabled=AppBanner,

] interface BeforeInstallPromptEvent : Event {

- readonly attribute DOMString platform;

+ readonly attribute sequence<DOMString> platforms;

[CallWith=ScriptState] readonly attribute Promise<DOMString> userChoice;

};