Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1326)

Unified Diff: Source/modules/app_banner/BeforeInstallPromptEvent.h

Issue 1089813002: Change beforeinstallprompt event to take an array of platforms. (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master
Patch Set: Update test expectations Created 5 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: Source/modules/app_banner/BeforeInstallPromptEvent.h
diff --git a/Source/modules/app_banner/BeforeInstallPromptEvent.h b/Source/modules/app_banner/BeforeInstallPromptEvent.h
index 23160ddde8b667d27b8923db7beb9e04c1a6cd23..4a3c80399a810d22dff515e8cc518f766ee5d954 100644
--- a/Source/modules/app_banner/BeforeInstallPromptEvent.h
+++ b/Source/modules/app_banner/BeforeInstallPromptEvent.h
@@ -23,9 +23,9 @@ public:
return adoptRefWillBeNoop(new BeforeInstallPromptEvent());
}
- static PassRefPtrWillBeRawPtr<BeforeInstallPromptEvent> create(const AtomicString& name, const String& platform)
+ static PassRefPtrWillBeRawPtr<BeforeInstallPromptEvent> create(const AtomicString& name, const Vector<String>& platforms)
{
- return adoptRefWillBeNoop(new BeforeInstallPromptEvent(name, platform));
+ return adoptRefWillBeNoop(new BeforeInstallPromptEvent(name, platforms));
}
static PassRefPtrWillBeRawPtr<BeforeInstallPromptEvent> create(const AtomicString& name, const BeforeInstallPromptEventInit& init)
@@ -33,17 +33,17 @@ public:
return adoptRefWillBeNoop(new BeforeInstallPromptEvent(name, init));
}
- String platform() const;
+ Vector<String> platforms() const;
ScriptPromise userChoice(ScriptState*) const;
virtual const AtomicString& interfaceName() const override;
private:
BeforeInstallPromptEvent();
- BeforeInstallPromptEvent(const AtomicString& name, const String& platform);
+ BeforeInstallPromptEvent(const AtomicString& name, const Vector<String>& platforms);
BeforeInstallPromptEvent(const AtomicString& name, const BeforeInstallPromptEventInit&);
- String m_platform;
+ Vector<String> m_platforms;
};
DEFINE_TYPE_CASTS(BeforeInstallPromptEvent, Event, event, event->interfaceName() == EventNames::BeforeInstallPromptEvent, event.interfaceName() == EventNames::BeforeInstallPromptEvent);
« no previous file with comments | « Source/modules/app_banner/AppBannerController.cpp ('k') | Source/modules/app_banner/BeforeInstallPromptEvent.cpp » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698