Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1552)

Unified Diff: Source/modules/app_banner/BeforeInstallPromptEvent.cpp

Issue 1089813002: Change beforeinstallprompt event to take an array of platforms. (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master
Patch Set: Update test expectations Created 5 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: Source/modules/app_banner/BeforeInstallPromptEvent.cpp
diff --git a/Source/modules/app_banner/BeforeInstallPromptEvent.cpp b/Source/modules/app_banner/BeforeInstallPromptEvent.cpp
index 47f5b7739b21a376f2f9a25cb723dd4bf9534b84..bc2db5ea387504fd64ad4953e7b9a8f077a6a322 100644
--- a/Source/modules/app_banner/BeforeInstallPromptEvent.cpp
+++ b/Source/modules/app_banner/BeforeInstallPromptEvent.cpp
@@ -16,15 +16,15 @@ BeforeInstallPromptEvent::BeforeInstallPromptEvent()
{
}
-BeforeInstallPromptEvent::BeforeInstallPromptEvent(const AtomicString& name, const String& platform)
+BeforeInstallPromptEvent::BeforeInstallPromptEvent(const AtomicString& name, const Vector<String>& platforms)
: Event(name, false, true)
- , m_platform(platform)
+ , m_platforms(platforms)
{
}
BeforeInstallPromptEvent::BeforeInstallPromptEvent(const AtomicString& name, const BeforeInstallPromptEventInit& init)
: Event(name, false, true)
- , m_platform(init.platform())
+ , m_platforms(init.platforms())
{
}
@@ -32,9 +32,9 @@ BeforeInstallPromptEvent::~BeforeInstallPromptEvent()
{
}
-String BeforeInstallPromptEvent::platform() const
+Vector<String> BeforeInstallPromptEvent::platforms() const
{
- return m_platform;
+ return m_platforms;
}
ScriptPromise BeforeInstallPromptEvent::userChoice(ScriptState* scriptState) const
« no previous file with comments | « Source/modules/app_banner/BeforeInstallPromptEvent.h ('k') | Source/modules/app_banner/BeforeInstallPromptEvent.idl » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698