Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(233)

Side by Side Diff: Source/modules/app_banner/BeforeInstallPromptEvent.cpp

Issue 1089813002: Change beforeinstallprompt event to take an array of platforms. (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master
Patch Set: Created 5 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 // Copyright 2015 The Chromium Authors. All rights reserved. 1 // Copyright 2015 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "config.h" 5 #include "config.h"
6 #include "modules/app_banner/BeforeInstallPromptEvent.h" 6 #include "modules/app_banner/BeforeInstallPromptEvent.h"
7 7
8 #include "bindings/core/v8/ScriptPromise.h" 8 #include "bindings/core/v8/ScriptPromise.h"
9 #include "core/dom/DOMException.h" 9 #include "core/dom/DOMException.h"
10 #include "core/dom/ExceptionCode.h" 10 #include "core/dom/ExceptionCode.h"
11 #include "modules/app_banner/BeforeInstallPromptEventInit.h" 11 #include "modules/app_banner/BeforeInstallPromptEventInit.h"
12 12
13 namespace blink { 13 namespace blink {
14 14
15 BeforeInstallPromptEvent::BeforeInstallPromptEvent() 15 BeforeInstallPromptEvent::BeforeInstallPromptEvent()
16 { 16 {
17 } 17 }
18 18
19 BeforeInstallPromptEvent::BeforeInstallPromptEvent(const AtomicString& name, con st String& platform) 19 BeforeInstallPromptEvent::BeforeInstallPromptEvent(const AtomicString& name, con st Vector<String>& platforms)
20 : Event(name, false, true) 20 : Event(name, false, true)
21 , m_platform(platform) 21 , m_platforms(platforms)
22 { 22 {
23 } 23 }
24 24
25 BeforeInstallPromptEvent::BeforeInstallPromptEvent(const AtomicString& name, con st BeforeInstallPromptEventInit& init) 25 BeforeInstallPromptEvent::BeforeInstallPromptEvent(const AtomicString& name, con st BeforeInstallPromptEventInit& init)
26 : Event(name, false, true) 26 : Event(name, false, true)
27 , m_platform(init.platform())
mlamouri (slow - plz ping) 2015/04/16 10:32:21 , m_platforms(init.platforms())
mlamouri (slow - plz ping) 2015/04/16 13:33:27 Keep this.
mlamouri (slow - plz ping) 2015/04/16 13:34:01 I realise that might not be clear. I mean that thi
benwells 2015/04/17 06:58:53 Done.
28 { 27 {
29 } 28 }
30 29
31 BeforeInstallPromptEvent::~BeforeInstallPromptEvent() 30 BeforeInstallPromptEvent::~BeforeInstallPromptEvent()
32 { 31 {
33 } 32 }
34 33
35 String BeforeInstallPromptEvent::platform() const 34 Vector<String> BeforeInstallPromptEvent::platforms() const
36 { 35 {
37 return m_platform; 36 return m_platforms;
38 } 37 }
39 38
40 ScriptPromise BeforeInstallPromptEvent::userChoice(ScriptState* scriptState) con st 39 ScriptPromise BeforeInstallPromptEvent::userChoice(ScriptState* scriptState) con st
41 { 40 {
42 return ScriptPromise::rejectWithDOMException(scriptState, DOMException::crea te(NotSupportedError, "Subscription failed - no active Service Worker")); 41 return ScriptPromise::rejectWithDOMException(scriptState, DOMException::crea te(NotSupportedError, "Subscription failed - no active Service Worker"));
43 } 42 }
44 43
45 const AtomicString& BeforeInstallPromptEvent::interfaceName() const 44 const AtomicString& BeforeInstallPromptEvent::interfaceName() const
46 { 45 {
47 return EventNames::BeforeInstallPromptEvent; 46 return EventNames::BeforeInstallPromptEvent;
48 } 47 }
49 48
50 } // namespace blink 49 } // namespace blink
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698