Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(246)

Issue 1086083002: [turbofan] Fix ForInStatement that deopts during filter. (Closed)

Created:
5 years, 8 months ago by Michael Starzinger
Modified:
5 years, 8 months ago
Reviewers:
Jarin
CC:
v8-dev
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

[turbofan] Fix ForInStatement that deopts during filter. This adds a missing bailout id to a ForInStatement for when retrieving and filtering a property name deoptimizes. This can happen with proxies that have a getPropertyDescriptor trap. R=jarin@chromium.org TEST=mjsunit/for-in-opt Committed: https://crrev.com/b807d112d785f65807494761c9d0b2fae5d6a7af Cr-Commit-Position: refs/heads/master@{#27846}

Patch Set 1 #

Patch Set 2 : Ported to all architectures. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+12 lines, -7 lines) Patch
M src/arm/full-codegen-arm.cc View 1 1 chunk +1 line, -0 lines 0 comments Download
M src/arm64/full-codegen-arm64.cc View 1 1 chunk +1 line, -0 lines 0 comments Download
M src/ast.h View 1 chunk +3 lines, -2 lines 0 comments Download
M src/compiler/ast-graph-builder.cc View 1 chunk +1 line, -2 lines 0 comments Download
M src/ia32/full-codegen-ia32.cc View 1 chunk +1 line, -0 lines 0 comments Download
M src/mips/full-codegen-mips.cc View 1 1 chunk +1 line, -0 lines 0 comments Download
M src/mips64/full-codegen-mips64.cc View 1 1 chunk +1 line, -0 lines 0 comments Download
M src/ppc/full-codegen-ppc.cc View 1 1 chunk +1 line, -0 lines 0 comments Download
M src/x64/full-codegen-x64.cc View 1 1 chunk +1 line, -0 lines 0 comments Download
M src/x87/full-codegen-x87.cc View 1 1 chunk +1 line, -0 lines 0 comments Download
M test/mjsunit/mjsunit.status View 1 chunk +0 lines, -3 lines 0 comments Download

Messages

Total messages: 6 (1 generated)
Michael Starzinger
Jarin: PTAL (ports are still missing). Toon: FYI (thanks for the test case).
5 years, 8 months ago (2015-04-15 09:11:46 UTC) #1
Jarin
lgtm
5 years, 8 months ago (2015-04-15 11:45:54 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1086083002/20001
5 years, 8 months ago (2015-04-15 13:07:03 UTC) #4
commit-bot: I haz the power
Committed patchset #2 (id:20001)
5 years, 8 months ago (2015-04-15 13:12:18 UTC) #5
commit-bot: I haz the power
5 years, 8 months ago (2015-04-15 13:12:27 UTC) #6
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/b807d112d785f65807494761c9d0b2fae5d6a7af
Cr-Commit-Position: refs/heads/master@{#27846}

Powered by Google App Engine
This is Rietveld 408576698