src/x64/full-codegen-x64.cc - Issue 1086083002: [turbofan] Fix ForInStatement that deopts during filter.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: src/x64/full-codegen-x64.cc

Issue 1086083002: [turbofan] Fix ForInStatement that deopts during filter. (Closed) Base URL: https://chromium.googlesource.com/v8/v8.git@master

Patch Set: Ported to all architectures. Created 5 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: src/x64/full-codegen-x64.cc

diff --git a/src/x64/full-codegen-x64.cc b/src/x64/full-codegen-x64.cc

index 9c7a41f44906a2e4c326d9b52d40f9fbc496899d..90d309504218bffd333366d1a2c03752c71bfb58 100644

--- a/src/x64/full-codegen-x64.cc

+++ b/src/x64/full-codegen-x64.cc

@@ -1244,6 +1244,7 @@ void FullCodeGenerator::VisitForInStatement(ForInStatement* stmt) {

__ Push(rcx); // Enumerable.

__ Push(rbx); // Current entry.

__ InvokeBuiltin(Builtins::FILTER_KEY, CALL_FUNCTION);

+ PrepareForBailoutForId(stmt->FilterId(), TOS_REG);

__ Cmp(rax, Smi::FromInt(0));

__ j(equal, loop_statement.continue_label());

__ movp(rbx, rax);

« no previous file with comments | « src/ppc/full-codegen-ppc.cc ('k') | src/x87/full-codegen-x87.cc » ('j') | no next file with comments »