Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(230)

Side by Side Diff: src/mips64/full-codegen-mips64.cc

Issue 1086083002: [turbofan] Fix ForInStatement that deopts during filter. (Closed) Base URL: https://chromium.googlesource.com/v8/v8.git@master
Patch Set: Ported to all architectures. Created 5 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « src/mips/full-codegen-mips.cc ('k') | src/ppc/full-codegen-ppc.cc » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright 2012 the V8 project authors. All rights reserved. 1 // Copyright 2012 the V8 project authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "src/v8.h" 5 #include "src/v8.h"
6 6
7 #if V8_TARGET_ARCH_MIPS64 7 #if V8_TARGET_ARCH_MIPS64
8 8
9 // Note on Mips implementation: 9 // Note on Mips implementation:
10 // 10 //
(...skipping 1251 matching lines...) Expand 10 before | Expand all | Expand 10 after
1262 // For proxies, no filtering is done. 1262 // For proxies, no filtering is done.
1263 // TODO(rossberg): What if only a prototype is a proxy? Not specified yet. 1263 // TODO(rossberg): What if only a prototype is a proxy? Not specified yet.
1264 DCHECK_EQ(static_cast<Smi*>(0), Smi::FromInt(0)); 1264 DCHECK_EQ(static_cast<Smi*>(0), Smi::FromInt(0));
1265 __ Branch(&update_each, eq, a2, Operand(zero_reg)); 1265 __ Branch(&update_each, eq, a2, Operand(zero_reg));
1266 1266
1267 // Convert the entry to a string or (smi) 0 if it isn't a property 1267 // Convert the entry to a string or (smi) 0 if it isn't a property
1268 // any more. If the property has been removed while iterating, we 1268 // any more. If the property has been removed while iterating, we
1269 // just skip it. 1269 // just skip it.
1270 __ Push(a1, a3); // Enumerable and current entry. 1270 __ Push(a1, a3); // Enumerable and current entry.
1271 __ InvokeBuiltin(Builtins::FILTER_KEY, CALL_FUNCTION); 1271 __ InvokeBuiltin(Builtins::FILTER_KEY, CALL_FUNCTION);
1272 PrepareForBailoutForId(stmt->FilterId(), TOS_REG);
1272 __ mov(a3, result_register()); 1273 __ mov(a3, result_register());
1273 __ Branch(loop_statement.continue_label(), eq, a3, Operand(zero_reg)); 1274 __ Branch(loop_statement.continue_label(), eq, a3, Operand(zero_reg));
1274 1275
1275 // Update the 'each' property or variable from the possibly filtered 1276 // Update the 'each' property or variable from the possibly filtered
1276 // entry in register a3. 1277 // entry in register a3.
1277 __ bind(&update_each); 1278 __ bind(&update_each);
1278 __ mov(result_register(), a3); 1279 __ mov(result_register(), a3);
1279 // Perform the assignment as if via '='. 1280 // Perform the assignment as if via '='.
1280 { EffectContext context(this); 1281 { EffectContext context(this);
1281 EmitAssignment(stmt->each()); 1282 EmitAssignment(stmt->each());
(...skipping 4196 matching lines...) Expand 10 before | Expand all | Expand 10 after
5478 Assembler::target_address_at(pc_immediate_load_address)) == 5479 Assembler::target_address_at(pc_immediate_load_address)) ==
5479 reinterpret_cast<uint64_t>( 5480 reinterpret_cast<uint64_t>(
5480 isolate->builtins()->OsrAfterStackCheck()->entry())); 5481 isolate->builtins()->OsrAfterStackCheck()->entry()));
5481 return OSR_AFTER_STACK_CHECK; 5482 return OSR_AFTER_STACK_CHECK;
5482 } 5483 }
5483 5484
5484 5485
5485 } } // namespace v8::internal 5486 } } // namespace v8::internal
5486 5487
5487 #endif // V8_TARGET_ARCH_MIPS64 5488 #endif // V8_TARGET_ARCH_MIPS64
OLDNEW
« no previous file with comments | « src/mips/full-codegen-mips.cc ('k') | src/ppc/full-codegen-ppc.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698