src/compiler/ast-graph-builder.cc - Issue 1086083002: [turbofan] Fix ForInStatement that deopts during filter.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: src/compiler/ast-graph-builder.cc

Issue 1086083002: [turbofan] Fix ForInStatement that deopts during filter. (Closed) Base URL: https://chromium.googlesource.com/v8/v8.git@master

Patch Set: Ported to all architectures. Created 5 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: src/compiler/ast-graph-builder.cc

diff --git a/src/compiler/ast-graph-builder.cc b/src/compiler/ast-graph-builder.cc

index 9b2ce879357b3878612d37727fd437028b7635f4..6828b5b0a86c7bb3e85ae2745c12401a1f5cc812 100644

--- a/src/compiler/ast-graph-builder.cc

+++ b/src/compiler/ast-graph-builder.cc

@@ -1270,8 +1270,7 @@ void AstGraphBuilder::VisitForInBody(ForInStatement* stmt) {

// is gone.

Node* res = NewNode(javascript()->CallFunction(3, NO_CALL_FUNCTION_FLAGS),

function, obj, value);

- // TODO(jarin): provide real bailout id.

- PrepareFrameState(res, BailoutId::None());

+ PrepareFrameState(res, stmt->FilterId(), OutputFrameStateCombine::Push());

Node* property_missing =

NewNode(javascript()->StrictEqual(), res, jsgraph()->ZeroConstant());

{

« no previous file with comments | « src/ast.h ('k') | src/ia32/full-codegen-ia32.cc » ('j') | no next file with comments »