Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(265)

Side by Side Diff: src/mips/full-codegen-mips.cc

Issue 1086083002: [turbofan] Fix ForInStatement that deopts during filter. (Closed) Base URL: https://chromium.googlesource.com/v8/v8.git@master
Patch Set: Ported to all architectures. Created 5 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « src/ia32/full-codegen-ia32.cc ('k') | src/mips64/full-codegen-mips64.cc » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright 2012 the V8 project authors. All rights reserved. 1 // Copyright 2012 the V8 project authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "src/v8.h" 5 #include "src/v8.h"
6 6
7 #if V8_TARGET_ARCH_MIPS 7 #if V8_TARGET_ARCH_MIPS
8 8
9 // Note on Mips implementation: 9 // Note on Mips implementation:
10 // 10 //
(...skipping 1255 matching lines...) Expand 10 before | Expand all | Expand 10 after
1266 // For proxies, no filtering is done. 1266 // For proxies, no filtering is done.
1267 // TODO(rossberg): What if only a prototype is a proxy? Not specified yet. 1267 // TODO(rossberg): What if only a prototype is a proxy? Not specified yet.
1268 DCHECK_EQ(static_cast<Smi*>(0), Smi::FromInt(0)); 1268 DCHECK_EQ(static_cast<Smi*>(0), Smi::FromInt(0));
1269 __ Branch(&update_each, eq, a2, Operand(zero_reg)); 1269 __ Branch(&update_each, eq, a2, Operand(zero_reg));
1270 1270
1271 // Convert the entry to a string or (smi) 0 if it isn't a property 1271 // Convert the entry to a string or (smi) 0 if it isn't a property
1272 // any more. If the property has been removed while iterating, we 1272 // any more. If the property has been removed while iterating, we
1273 // just skip it. 1273 // just skip it.
1274 __ Push(a1, a3); // Enumerable and current entry. 1274 __ Push(a1, a3); // Enumerable and current entry.
1275 __ InvokeBuiltin(Builtins::FILTER_KEY, CALL_FUNCTION); 1275 __ InvokeBuiltin(Builtins::FILTER_KEY, CALL_FUNCTION);
1276 PrepareForBailoutForId(stmt->FilterId(), TOS_REG);
1276 __ mov(a3, result_register()); 1277 __ mov(a3, result_register());
1277 __ Branch(loop_statement.continue_label(), eq, a3, Operand(zero_reg)); 1278 __ Branch(loop_statement.continue_label(), eq, a3, Operand(zero_reg));
1278 1279
1279 // Update the 'each' property or variable from the possibly filtered 1280 // Update the 'each' property or variable from the possibly filtered
1280 // entry in register a3. 1281 // entry in register a3.
1281 __ bind(&update_each); 1282 __ bind(&update_each);
1282 __ mov(result_register(), a3); 1283 __ mov(result_register(), a3);
1283 // Perform the assignment as if via '='. 1284 // Perform the assignment as if via '='.
1284 { EffectContext context(this); 1285 { EffectContext context(this);
1285 EmitAssignment(stmt->each()); 1286 EmitAssignment(stmt->each());
(...skipping 4186 matching lines...) Expand 10 before | Expand all | Expand 10 after
5472 Assembler::target_address_at(pc_immediate_load_address)) == 5473 Assembler::target_address_at(pc_immediate_load_address)) ==
5473 reinterpret_cast<uint32_t>( 5474 reinterpret_cast<uint32_t>(
5474 isolate->builtins()->OsrAfterStackCheck()->entry())); 5475 isolate->builtins()->OsrAfterStackCheck()->entry()));
5475 return OSR_AFTER_STACK_CHECK; 5476 return OSR_AFTER_STACK_CHECK;
5476 } 5477 }
5477 5478
5478 5479
5479 } } // namespace v8::internal 5480 } } // namespace v8::internal
5480 5481
5481 #endif // V8_TARGET_ARCH_MIPS 5482 #endif // V8_TARGET_ARCH_MIPS
OLDNEW
« no previous file with comments | « src/ia32/full-codegen-ia32.cc ('k') | src/mips64/full-codegen-mips64.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698