Give names to all utility processes.

Give names to all utility processes.

BUG=472340
Committed: https://crrev.com/e3d6b757596c96fb8f59fd4d3ca24e2b282bafcb
Cr-Commit-Position: refs/heads/master@{#324130}

[Lei Zhang, 2015-04-06 22:34:08]

thestig@chromium.org changed reviewers:
+ creis@chromium.org

[Charlie Reis, 2015-04-06 23:47:41]

Thanks for adding these!  The names seem reasonable to me at a high level.  LGTM
apart from a few likely typos.

https://codereview.chromium.org/1062873003/diff/40001/chrome/browser/chromeos...
File chrome/browser/chromeos/file_manager/zip_file_creator.cc (right):

https://codereview.chromium.org/1062873003/diff/40001/chrome/browser/chromeos...
chrome/browser/chromeos/file_manager/zip_file_creator.cc:97:
l10n_util::GetStringUTF16(IDS_UTILITY_PROCESS_PROXY_RESOLVER_NAME));
This should be IDS_UTILITY_PROCESS_ZIP_FILE_CREATOR_NAME, right?

https://codereview.chromium.org/1062873003/diff/40001/chrome/browser/media_ga...
File chrome/browser/media_galleries/fileapi/safe_picasa_album_table_reader.cc
(right):

https://codereview.chromium.org/1062873003/diff/40001/chrome/browser/media_ga...
chrome/browser/media_galleries/fileapi/safe_picasa_album_table_reader.cc:71:
IDS_UTILITY_PROCESS_MEDIA_LIBRARY_FILE_CHECKER_NAME));
I'm guessing it's intentional to give the utility processes for both iTunes and
Picasa the same name?  Not quite as precise as it could be, but it seems
reasonable to me.

https://codereview.chromium.org/1062873003/diff/40001/chrome/browser/media_ga...
File chrome/browser/media_galleries/fileapi/safe_picasa_albums_indexer.cc
(right):

https://codereview.chromium.org/1062873003/diff/40001/chrome/browser/media_ga...
chrome/browser/media_galleries/fileapi/safe_picasa_albums_indexer.cc:102:
IDS_UTILITY_PROCESS_PROXY_RESOLVER_NAME));
This doesn't look right.

[Lei Zhang, 2015-04-06 23:51:34]

Thanks for sanity checking. I'll fix the typos.

Re: IDS_UTILITY_PROCESS_MEDIA_LIBRARY_FILE_CHECKER_NAME - it's probably uncommon
for Mac users to have Picasa, and for Windows users to have both iTunes and
Picasa installed. In most cases, we can figure out which program's library files
we are parsing based on what's installed.

[Lei Zhang, 2015-04-06 23:56:34]

Fixed copy+paste errors in patch set 4.

[Lei Zhang, 2015-04-06 23:56:37]

The CQ bit was checked by thestig@chromium.org

[Lei Zhang, 2015-04-06 23:56:38]

The patchset sent to the CQ was uploaded after l-g-t-m from creis@chromium.org
Link to the patchset: https://codereview.chromium.org/1062873003/#ps60001
(title: "fix typos")

[commit-bot: I haz the power, 2015-04-06 23:57:45]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1062873003/60001

[commit-bot: I haz the power, 2015-04-07 00:09:48]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2015-04-07 00:09:49]

Try jobs failed on following builders:
  chromium_presubmit on tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/chromium_presub...)

[Charlie Reis, 2015-04-07 00:11:06]

Right, you'll need more owners than me.

[Lei Zhang, 2015-04-07 00:12:11]

thestig@chromium.org changed reviewers:
+ kalman@chromium.org

[Lei Zhang, 2015-04-07 00:12:12]

Oh, Monday.

+kalman for extensions/

[not at google - send to devlin, 2015-04-07 16:45:39]

lgtm, I'm not the primary reviewer here so I won't block anything on addressing
my comments. They may be something to consider though.

https://codereview.chromium.org/1062873003/diff/60001/chrome/browser/extensio...
File
chrome/browser/extensions/api/image_writer_private/image_writer_utility_client.cc
(right):

https://codereview.chromium.org/1062873003/diff/60001/chrome/browser/extensio...
chrome/browser/extensions/api/image_writer_private/image_writer_utility_client.cc:95:
utility_process_host_->SetName(l10n_util::GetStringUTF16(
The next round of utility processes are just going to forget to call SetName.
Should it be a constructor argument, optional or otherwise?

https://codereview.chromium.org/1062873003/diff/60001/chrome/browser/extensio...
chrome/browser/extensions/api/image_writer_private/image_writer_utility_client.cc:96:
IDS_UTILITY_PROCESS_IMAGE_WRITER_NAME));
Triaging process manager bugs filed from other languages is going to be a little
bit interesting.

[Lei Zhang, 2015-04-07 21:53:54]

https://codereview.chromium.org/1062873003/diff/60001/chrome/browser/extensio...
File
chrome/browser/extensions/api/image_writer_private/image_writer_utility_client.cc
(right):

https://codereview.chromium.org/1062873003/diff/60001/chrome/browser/extensio...
chrome/browser/extensions/api/image_writer_private/image_writer_utility_client.cc:95:
utility_process_host_->SetName(l10n_util::GetStringUTF16(
On 2015/04/07 16:45:39, kalman wrote:
> The next round of utility processes are just going to forget to call SetName.
> Should it be a constructor argument, optional or otherwise?

I was thinking about that, but I don't want to force it at the content API
level. It defaults to "utility process" (untranslated) if SetName() does not get
called.

I bet new utility process host code will be written via copy + paste of existing
code. So chances are, new code will copy the SetName() call too.

https://codereview.chromium.org/1062873003/diff/60001/chrome/browser/extensio...
chrome/browser/extensions/api/image_writer_private/image_writer_utility_client.cc:96:
IDS_UTILITY_PROCESS_IMAGE_WRITER_NAME));
On 2015/04/07 16:45:39, kalman wrote:
> Triaging process manager bugs filed from other languages is going to be a
little
> bit interesting.

The translators are going to have fun with these as well.

[Lei Zhang, 2015-04-07 21:53:59]

The CQ bit was checked by thestig@chromium.org

[commit-bot: I haz the power, 2015-04-07 21:54:20]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1062873003/60001

[commit-bot: I haz the power, 2015-04-07 21:59:05]

Committed patchset #4 (id:60001)

[commit-bot: I haz the power, 2015-04-07 21:59:54]

Patchset 4 (id:??) landed as
https://crrev.com/e3d6b757596c96fb8f59fd4d3ca24e2b282bafcb
Cr-Commit-Position: refs/heads/master@{#324130}