Give names to all utility processes.

chrome/browser/extensions/api/image_writer_private/image_writer_utility_client.cc

 // Copyright 2014 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "base/bind.h"
 #include "base/message_loop/message_loop.h"
 #include "chrome/browser/browser_process.h"
 #include "chrome/browser/extensions/api/image_writer_private/image_writer_utility_client.h"
 #include "chrome/common/extensions/chrome_utility_extensions_messages.h"
+#include "chrome/grit/generated_resources.h"
 #include "content/public/browser/browser_thread.h"
+#include "ui/base/l10n/l10n_util.h"
 
 using content::BrowserThread;
 
 ImageWriterUtilityClient::ImageWriterUtilityClient()
     : message_loop_proxy_(base::MessageLoopProxy::current()) {}
 ImageWriterUtilityClient::~ImageWriterUtilityClient() {}
 
 void ImageWriterUtilityClient::Write(const ProgressCallback& progress_callback,
                                      const SuccessCallback& success_callback,
                                      const ErrorCallback& error_callback,
@@ skipping 62 matching lines @@
   error_callback_ = base::Callback<void(const std::string&)>();
   cancel_callback_ = base::Closure();
 }
 
 void ImageWriterUtilityClient::StartHost() {
   if (!utility_process_host_) {
     scoped_refptr<base::SequencedTaskRunner> task_runner =
         base::MessageLoop::current()->message_loop_proxy();
     utility_process_host_ = content::UtilityProcessHost::Create(
                                 this, task_runner.get())->AsWeakPtr();
+    utility_process_host_->SetName(l10n_util::GetStringUTF16(

[not at google - send to devlin, 2015/04/07 16:45:39]

The next round of utility processes are just going to forget to call SetName.
Should it be a constructor argument, optional or otherwise?

[Lei Zhang, 2015/04/07 21:53:54]

I was thinking about that, but I don't want to force it at the content API
level. It defaults to "utility process" (untranslated) if SetName() does not get
called.

I bet new utility process host code will be written via copy + paste of existing
code. So chances are, new code will copy the SetName() call too.

+        IDS_UTILITY_PROCESS_IMAGE_WRITER_NAME));

[not at google - send to devlin, 2015/04/07 16:45:39]

Triaging process manager bugs filed from other languages is going to be a little
bit interesting.

[Lei Zhang, 2015/04/07 21:53:54]

The translators are going to have fun with these as well.

 
 #if defined(OS_WIN)
     utility_process_host_->ElevatePrivileges();
 #else
     utility_process_host_->DisableSandbox();
 #endif
     utility_process_host_->StartBatchMode();
   }
 }
 
@@ skipping 45 matching lines @@
                                   base::Bind(error_callback_, message));
   }
 }
 
 void ImageWriterUtilityClient::OnWriteImageProgress(int64 progress) {
   if (!progress_callback_.is_null()) {
     message_loop_proxy_->PostTask(FROM_HERE,
                                   base::Bind(progress_callback_, progress));
   }
 }