Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(3269)

Unified Diff: chrome/browser/local_discovery/service_discovery_host_client.cc

Issue 1062873003: Give names to all utility processes. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: fix typos Created 5 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/local_discovery/service_discovery_host_client.cc
diff --git a/chrome/browser/local_discovery/service_discovery_host_client.cc b/chrome/browser/local_discovery/service_discovery_host_client.cc
index ebdbe62609e1bd5d750513194f9bb913867006d0..f201ffbdc876f286a80554214afbc37e10e2f073 100644
--- a/chrome/browser/local_discovery/service_discovery_host_client.cc
+++ b/chrome/browser/local_discovery/service_discovery_host_client.cc
@@ -5,10 +5,12 @@
#include "chrome/browser/local_discovery/service_discovery_host_client.h"
#include "chrome/common/local_discovery/local_discovery_messages.h"
+#include "chrome/grit/generated_resources.h"
#include "content/public/browser/browser_thread.h"
#include "content/public/browser/utility_process_host.h"
#include "net/dns/mdns_client.h"
#include "net/socket/socket_descriptor.h"
+#include "ui/base/l10n/l10n_util.h"
#if defined(OS_POSIX)
#include <netinet/in.h>
@@ -282,8 +284,8 @@ void ServiceDiscoveryHostClient::OnSocketsReady(const SocketInfoList& sockets) {
DCHECK(!utility_host_);
utility_host_ = UtilityProcessHost::Create(
this, base::MessageLoopProxy::current().get())->AsWeakPtr();
- if (!utility_host_)
- return;
+ utility_host_->SetName(l10n_util::GetStringUTF16(
+ IDS_UTILITY_PROCESS_SERVICE_DISCOVERY_HANDLER_NAME));
utility_host_->EnableMDns();
utility_host_->StartBatchMode();
if (sockets.empty()) {
@@ -304,8 +306,8 @@ void ServiceDiscoveryHostClient::StartOnIOThread() {
DCHECK(!utility_host_);
utility_host_ = UtilityProcessHost::Create(
this, base::MessageLoopProxy::current().get())->AsWeakPtr();
- if (!utility_host_)
- return;
+ utility_host_->SetName(l10n_util::GetStringUTF16(
+ IDS_UTILITY_PROCESS_SERVICE_DISCOVERY_HANDLER_NAME));
utility_host_->EnableMDns();
utility_host_->StartBatchMode();
// Windows does not enumerate networks here.

Powered by Google App Engine
This is Rietveld 408576698