chrome/browser/chrome_select_file_dialog_factory_win.cc - Issue 1062873003: Give names to all utility processes.

Unified Diff: chrome/browser/chrome_select_file_dialog_factory_win.cc

Issue 1062873003: Give names to all utility processes. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: fix typos Created 5 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/browser/chrome_browser_main_win.cc ('k') | chrome/browser/chromeos/file_manager/zip_file_creator.cc » ('j') | chrome/browser/extensions/api/image_writer_private/image_writer_utility_client.cc » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/chrome_select_file_dialog_factory_win.cc

diff --git a/chrome/browser/chrome_select_file_dialog_factory_win.cc b/chrome/browser/chrome_select_file_dialog_factory_win.cc

index 08f2024c1585c1334264e2248b00e06904ddcb49..40d3baa4b60570cd347d5ed250ce53ca1ebd48f7 100644

--- a/chrome/browser/chrome_select_file_dialog_factory_win.cc

+++ b/chrome/browser/chrome_select_file_dialog_factory_win.cc

@@ -17,9 +17,11 @@

#include "base/synchronization/waitable_event.h"

#include "base/win/metro.h"

#include "chrome/common/chrome_utility_messages.h"

+#include "chrome/grit/generated_resources.h"

#include "content/public/browser/utility_process_host.h"

#include "content/public/browser/utility_process_host_client.h"

#include "ipc/ipc_message_macros.h"

+#include "ui/base/l10n/l10n_util.h"

#include "ui/base/win/open_file_name_win.h"

#include "ui/shell_dialogs/select_file_dialog_win.h"

@@ -65,9 +67,9 @@ class GetOpenFileNameClient : public content::UtilityProcessHostClient {

const std::vector<base::FilePath>& filenames() const { return filenames_; }

// UtilityProcessHostClient implementation

- virtual void OnProcessCrashed(int exit_code) override;

- virtual void OnProcessLaunchFailed() override;

- virtual bool OnMessageReceived(const IPC::Message& message) override;

+ void OnProcessCrashed(int exit_code) override;

+ void OnProcessLaunchFailed() override;

+ bool OnMessageReceived(const IPC::Message& message) override;

protected:

virtual ~GetOpenFileNameClient();

@@ -137,6 +139,8 @@ void DoInvokeGetOpenFileName(

base::WeakPtr<content::UtilityProcessHost> utility_process_host(

content::UtilityProcessHost::Create(client, current_task_runner)

->AsWeakPtr());

+ utility_process_host->SetName(l10n_util::GetStringUTF16(

+ IDS_UTILITY_PROCESS_FILE_DIALOG_NAME));

utility_process_host->DisableSandbox();

utility_process_host->Send(new ChromeUtilityMsg_GetOpenFileName(

ofn->hwndOwner,

@@ -196,9 +200,9 @@ class GetSaveFileNameClient : public content::UtilityProcessHostClient {

int one_based_filter_index() const { return one_based_filter_index_; }