chrome/browser/extensions/api/image_writer_private/image_writer_utility_client.cc - Issue 1062873003: Give names to all utility processes.

Unified Diff: chrome/browser/extensions/api/image_writer_private/image_writer_utility_client.cc

Issue 1062873003: Give names to all utility processes. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: fix typos Created 5 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/browser/component_updater/component_patcher_operation_out_of_process.cc ('k') | chrome/browser/extensions/api/networking_private/networking_private_credentials_getter_win.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/extensions/api/image_writer_private/image_writer_utility_client.cc

diff --git a/chrome/browser/extensions/api/image_writer_private/image_writer_utility_client.cc b/chrome/browser/extensions/api/image_writer_private/image_writer_utility_client.cc

index 37d80908c78c6ca2d9961cab91b4f0391b7a62a9..9c77870764b610705a63016e726baa5e1ba0341b 100644

--- a/chrome/browser/extensions/api/image_writer_private/image_writer_utility_client.cc

+++ b/chrome/browser/extensions/api/image_writer_private/image_writer_utility_client.cc

@@ -7,7 +7,9 @@

#include "chrome/browser/browser_process.h"

#include "chrome/browser/extensions/api/image_writer_private/image_writer_utility_client.h"

#include "chrome/common/extensions/chrome_utility_extensions_messages.h"

+#include "chrome/grit/generated_resources.h"

#include "content/public/browser/browser_thread.h"

+#include "ui/base/l10n/l10n_util.h"

using content::BrowserThread;

@@ -90,6 +92,8 @@ void ImageWriterUtilityClient::StartHost() {

base::MessageLoop::current()->message_loop_proxy();

utility_process_host_ = content::UtilityProcessHost::Create(

this, task_runner.get())->AsWeakPtr();

+ utility_process_host_->SetName(l10n_util::GetStringUTF16(

not at google - send to devlin 2015/04/07 16:45:39 The next round of utility processes are just going

Lei Zhang 2015/04/07 21:53:54 I was thinking about that, but I don't want to for

+ IDS_UTILITY_PROCESS_IMAGE_WRITER_NAME));

not at google - send to devlin 2015/04/07 16:45:39 Triaging process manager bugs filed from other lan

Lei Zhang 2015/04/07 21:53:54 The translators are going to have fun with these a

#if defined(OS_WIN)

utility_process_host_->ElevatePrivileges();