Add an ONC property for disabling LCP echo

Add an ONC property for disabling LCP echo

This CL maps an ONC property for disabling L2TP connection
monitoring via PPP LCP frames.

BUG=463602
TEST=Expanded test ONC and JSON test sets

Committed: https://crrev.com/b20f791602f4064dbb96418abc64ff6fdb79379d
Cr-Commit-Position: refs/heads/master@{#323943}

[Paul Stewart, 2015-04-02 18:23:45]

The CQ bit was checked by pstew@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2015-04-02 18:24:27]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1058973002/1

[commit-bot: I haz the power, 2015-04-02 18:24:28]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2015-04-02 18:24:29]

No LGTM from a valid reviewer yet. Only full committers are accepted.
Even if an LGTM may have been provided, it was from a non-committer,
_not_ a full super star committer.
See http://www.chromium.org/getting-involved/become-a-committer
Note that this has nothing to do with OWNERS files.

[Paul Stewart, 2015-04-03 23:39:40]

pstew@chromium.org changed reviewers:
+ pneubeck@chromium.org, stevenjb@chromium.org

[stevenjb, 2015-04-03 23:45:31]

lgtm w/ nit

https://codereview.chromium.org/1058973002/diff/40001/chromeos/network/onc/on...
File chromeos/network/onc/onc_signature.cc (right):

https://codereview.chromium.org/1058973002/diff/40001/chromeos/network/onc/on...
chromeos/network/onc/onc_signature.cc:100: {::onc::vpn::kUsername,
&kStringSignature},
nit: while we are in here we should really add Password/SaveCredentials/Username
to the l2tp namespace and use those here.

https://codereview.chromium.org/1058973002/diff/40001/chromeos/network/onc/on...
File chromeos/network/onc/onc_translation_tables.cc (right):

https://codereview.chromium.org/1058973002/diff/40001/chromeos/network/onc/on...
chromeos/network/onc/onc_translation_tables.cc:61: {::onc::vpn::kUsername,
shill::kL2tpIpsecUserProperty},
nit: s/vpn/l2tp/

https://codereview.chromium.org/1058973002/diff/40001/chromeos/test/data/netw...
File chromeos/test/data/network/shill_l2tpipsec.json (right):

https://codereview.chromium.org/1058973002/diff/40001/chromeos/test/data/netw...
chromeos/test/data/network/shill_l2tpipsec.json:11: "L2TPIPsec.Password": "some
password",
Dupe

[Paul Stewart, 2015-04-06 20:04:41]

I'll try inheriting LGTM.  I've re-done chromeos unittests.

[Paul Stewart, 2015-04-06 20:04:50]

The CQ bit was checked by pstew@chromium.org

[Paul Stewart, 2015-04-06 20:04:51]

The patchset sent to the CQ was uploaded after l-g-t-m from
stevenjb@chromium.org
Link to the patchset: https://codereview.chromium.org/1058973002/#ps60001
(title: "Address stevenjb@'s comments")

[commit-bot: I haz the power, 2015-04-06 20:05:07]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1058973002/60001

[commit-bot: I haz the power, 2015-04-06 21:00:36]

Committed patchset #4 (id:60001)

[commit-bot: I haz the power, 2015-04-06 21:01:30]

Patchset 4 (id:??) landed as
https://crrev.com/b20f791602f4064dbb96418abc64ff6fdb79379d
Cr-Commit-Position: refs/heads/master@{#323943}

[pneubeck (no reviews), 2015-04-07 09:45:20]

https://codereview.chromium.org/1058973002/diff/60001/chromeos/network/onc/on...
File chromeos/network/onc/onc_signature.cc (right):

https://codereview.chromium.org/1058973002/diff/60001/chromeos/network/onc/on...
chromeos/network/onc/onc_signature.cc:99: {::onc::l2tp::kSaveCredentials,
&kBoolSignature},
because of the rename, we'll have to check&update all usages of the old vpn
fields, e.g.
https://code.google.com/p/chromium/codesearch#chromium/src/components/onc/onc...

which lists for example the now incorrect usage in vpn_config_view.cc:792
https://code.google.com/p/chromium/codesearch#chromium/src/chrome/browser/chr...

https://codereview.chromium.org/1058973002/diff/60001/chromeos/network/onc/on...
File chromeos/network/onc/onc_translation_tables.cc (right):

https://codereview.chromium.org/1058973002/diff/60001/chromeos/network/onc/on...
chromeos/network/onc/onc_translation_tables.cc:62:
{::onc::l2tp::kLcpEchoDisabled, shill::kL2tpIpsecLcpEchoDisabledProperty},
please add documentation for this field to  components/onc/docs/onc_spec.html

I didn't find any documentation for this field in Shill.

[Paul Stewart, 2015-04-07 15:34:33]

https://codereview.chromium.org/1058973002/diff/60001/chromeos/network/onc/on...
File chromeos/network/onc/onc_signature.cc (right):

https://codereview.chromium.org/1058973002/diff/60001/chromeos/network/onc/on...
chromeos/network/onc/onc_signature.cc:99: {::onc::l2tp::kSaveCredentials,
&kBoolSignature},
On 2015/04/07 09:45:20, pneubeck wrote:
> because of the rename, we'll have to check&update all usages of the old vpn
> fields, e.g.
>
https://code.google.com/p/chromium/codesearch#chromium/src/components/onc/onc...
> 
> which lists for example the now incorrect usage in vpn_config_view.cc:792
>
https://code.google.com/p/chromium/codesearch#chromium/src/chrome/browser/chr...

Acknowledged.

https://codereview.chromium.org/1058973002/diff/60001/chromeos/network/onc/on...
File chromeos/network/onc/onc_translation_tables.cc (right):

https://codereview.chromium.org/1058973002/diff/60001/chromeos/network/onc/on...
chromeos/network/onc/onc_translation_tables.cc:62:
{::onc::l2tp::kLcpEchoDisabled, shill::kL2tpIpsecLcpEchoDisabledProperty},
On 2015/04/07 09:45:20, pneubeck wrote:
> please add documentation for this field to  components/onc/docs/onc_spec.html
> 
> I didn't find any documentation for this field in Shill.

It's a little late for this CL.  See https://codereview.chromium.org/1060333003