Add an ONC property for disabling LCP echo

chromeos/network/onc/onc_signature.cc

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "chromeos/network/onc/onc_signature.h"
 
 #include "components/onc/onc_constants.h"
 #include "third_party/cros_system_api/dbus/service_constants.h"
 
 using base::Value;
@@ skipping 77 matching lines @@
     //  { ipsec::kEAP, &kEAPSignature },
     {NULL}};
 
 const OncFieldSignature xauth_fields[] = {
     {::onc::vpn::kPassword, &kStringSignature},
     {::onc::vpn::kUsername, &kStringSignature},
     {NULL}};
 
 const OncFieldSignature l2tp_fields[] = {
     {::onc::kRecommended, &kRecommendedSignature},
-    {::onc::vpn::kPassword, &kStringSignature},
-    {::onc::vpn::kSaveCredentials, &kBoolSignature},
-    {::onc::vpn::kUsername, &kStringSignature},
+    {::onc::l2tp::kPassword, &kStringSignature},
+    {::onc::l2tp::kSaveCredentials, &kBoolSignature},

[pneubeck (no reviews), 2015/04/07 09:45:20]

because of the rename, we'll have to check&update all usages of the old vpn
fields, e.g.
https://code.google.com/p/chromium/codesearch#chromium/src/components/onc/onc...

which lists for example the now incorrect usage in vpn_config_view.cc:792
https://code.google.com/p/chromium/codesearch#chromium/src/chrome/browser/chr...

[Paul Stewart, 2015/04/07 15:34:33]

Acknowledged.

+    {::onc::l2tp::kUsername, &kStringSignature},
+    {::onc::l2tp::kLcpEchoDisabled, &kBoolSignature},
     {NULL}};
 
 const OncFieldSignature openvpn_fields[] = {
     {::onc::kRecommended, &kRecommendedSignature},
     {::onc::openvpn::kAuth, &kStringSignature},
     {::onc::openvpn::kAuthNoCache, &kBoolSignature},
     {::onc::openvpn::kAuthRetry, &kStringSignature},
     {::onc::openvpn::kCipher, &kStringSignature},
     {::onc::client_cert::kClientCertPattern, &kCertificatePatternSignature},
     {::onc::client_cert::kClientCertRef, &kStringSignature},
@@ skipping 416 matching lines @@
     if (&signature == entry->value_signature &&
         onc_field_name == entry->field_name) {
       return true;
     }
   }
   return false;
 }
 
 }  // namespace onc
 }  // namespace chromeos