Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(844)

Issue 1060333003: Add documentation for LCP echo ONC property (Closed)

Created:
5 years, 8 months ago by Paul Stewart
Modified:
5 years, 8 months ago
CC:
chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Add documentation for LCP echo ONC property Add documentation for the "LcpEchoDisabled" ONC property. BUG=463602 TEST=None Committed: https://crrev.com/9be8c5d50aa3c09504d6d0312cca24376aeb1ace Cr-Commit-Position: refs/heads/master@{#324256}

Patch Set 1 #

Total comments: 2

Patch Set 2 : Address pneubeck@'s nits. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+11 lines, -0 lines) Patch
M components/onc/docs/onc_spec.html View 1 1 chunk +11 lines, -0 lines 0 comments Download

Messages

Total messages: 8 (3 generated)
Paul Stewart
5 years, 8 months ago (2015-04-07 15:35:08 UTC) #2
pneubeck (no reviews)
thanks! lgtm https://codereview.chromium.org/1060333003/diff/1/components/onc/docs/onc_spec.html File components/onc/docs/onc_spec.html (right): https://codereview.chromium.org/1060333003/diff/1/components/onc/docs/onc_spec.html#newcode1038 components/onc/docs/onc_spec.html:1038: (optional) nit: (optional) -> (optional, defaults to ...
5 years, 8 months ago (2015-04-08 08:22:31 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1060333003/20001
5 years, 8 months ago (2015-04-08 17:37:31 UTC) #6
commit-bot: I haz the power
Committed patchset #2 (id:20001)
5 years, 8 months ago (2015-04-08 18:35:53 UTC) #7
commit-bot: I haz the power
5 years, 8 months ago (2015-04-08 18:37:23 UTC) #8
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/9be8c5d50aa3c09504d6d0312cca24376aeb1ace
Cr-Commit-Position: refs/heads/master@{#324256}

Powered by Google App Engine
This is Rietveld 408576698