Add an ONC property for disabling LCP echo

chromeos/network/onc/onc_translation_tables.cc

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "chromeos/network/onc/onc_translation_tables.h"
 
 #include <cstddef>
 
 #include "base/logging.h"
 #include "components/onc/onc_constants.h"
@@ skipping 36 matching lines @@
     // { ::onc::vpn::kSaveCredentials, shill::kSaveCredentialsProperty},
     {::onc::ipsec::kServerCAPEMs, shill::kL2tpIpsecCaCertPemProperty},
     {NULL}};
 
 const FieldTranslationEntry xauth_fields[] = {
     {::onc::vpn::kPassword, shill::kL2tpIpsecXauthPasswordProperty},
     {::onc::vpn::kUsername, shill::kL2tpIpsecXauthUserProperty},
     {NULL}};
 
 const FieldTranslationEntry l2tp_fields[] = {
-    {::onc::vpn::kPassword, shill::kL2tpIpsecPasswordProperty},
+    {::onc::l2tp::kPassword, shill::kL2tpIpsecPasswordProperty},
     // We don't synchronize l2tp's SaveCredentials field for now, as Shill
     // doesn't support separate settings for ipsec and l2tp.
-    // { ::onc::vpn::kSaveCredentials, &kBoolSignature },
-    {::onc::vpn::kUsername, shill::kL2tpIpsecUserProperty},
+    // { ::onc::l2tp::kSaveCredentials, &kBoolSignature },
+    {::onc::l2tp::kUsername, shill::kL2tpIpsecUserProperty},
+    {::onc::l2tp::kLcpEchoDisabled, shill::kL2tpIpsecLcpEchoDisabledProperty},

[pneubeck (no reviews), 2015/04/07 09:45:20]

please add documentation for this field to  components/onc/docs/onc_spec.html

I didn't find any documentation for this field in Shill.

[Paul Stewart, 2015/04/07 15:34:33]

It's a little late for this CL.  See https://codereview.chromium.org/1060333003

     {NULL}};
 
 const FieldTranslationEntry openvpn_fields[] = {
     {::onc::openvpn::kAuth, shill::kOpenVPNAuthProperty},
     {::onc::openvpn::kAuthNoCache, shill::kOpenVPNAuthNoCacheProperty},
     {::onc::openvpn::kAuthRetry, shill::kOpenVPNAuthRetryProperty},
     {::onc::openvpn::kCipher, shill::kOpenVPNCipherProperty},
     {::onc::openvpn::kCompLZO, shill::kOpenVPNCompLZOProperty},
     {::onc::openvpn::kCompNoAdapt, shill::kOpenVPNCompNoAdaptProperty},
     {::onc::openvpn::kIgnoreDefaultRoute,
@@ skipping 354 matching lines @@
       continue;
     *onc_value = table[i].onc_value;
     return true;
   }
   LOG(ERROR) << "Value '" << shill_value << "' cannot be translated to ONC";
   return false;
 }
 
 }  // namespace onc
 }  // namespace chromeos