Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(4949)

Unified Diff: chromeos/network/onc/onc_translation_tables.cc

Issue 1058973002: Add an ONC property for disabling LCP echo (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Address stevenjb@'s comments Created 5 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chromeos/network/onc/onc_translation_tables.cc
diff --git a/chromeos/network/onc/onc_translation_tables.cc b/chromeos/network/onc/onc_translation_tables.cc
index 3db2cfa80d02845f2072dbdf5c8a03acd994363a..564b9dc3f8340175705cdd9edec76c7e678c4178 100644
--- a/chromeos/network/onc/onc_translation_tables.cc
+++ b/chromeos/network/onc/onc_translation_tables.cc
@@ -54,11 +54,12 @@ const FieldTranslationEntry xauth_fields[] = {
{NULL}};
const FieldTranslationEntry l2tp_fields[] = {
- {::onc::vpn::kPassword, shill::kL2tpIpsecPasswordProperty},
+ {::onc::l2tp::kPassword, shill::kL2tpIpsecPasswordProperty},
// We don't synchronize l2tp's SaveCredentials field for now, as Shill
// doesn't support separate settings for ipsec and l2tp.
- // { ::onc::vpn::kSaveCredentials, &kBoolSignature },
- {::onc::vpn::kUsername, shill::kL2tpIpsecUserProperty},
+ // { ::onc::l2tp::kSaveCredentials, &kBoolSignature },
+ {::onc::l2tp::kUsername, shill::kL2tpIpsecUserProperty},
+ {::onc::l2tp::kLcpEchoDisabled, shill::kL2tpIpsecLcpEchoDisabledProperty},
pneubeck (no reviews) 2015/04/07 09:45:20 please add documentation for this field to compon
Paul Stewart 2015/04/07 15:34:33 It's a little late for this CL. See https://coder
{NULL}};
const FieldTranslationEntry openvpn_fields[] = {

Powered by Google App Engine
This is Rietveld 408576698