Reland: Made content editables report the caret and text selection by treating them as text controls

Made content editables report the caret and text selection by treating them as text controls.

Reland after CL 1080533004, which disables content editable descendents accessibility browser test.
BUG=347859
R=dmazzoni,dcheng

Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=193803

Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=193910

[dmazzoni, 2015-04-02 06:54:55]

https://codereview.chromium.org/1056763002/diff/1/Source/modules/accessibilit...
File Source/modules/accessibility/AXLayoutObject.cpp (right):

https://codereview.chromium.org/1056763002/diff/1/Source/modules/accessibilit...
Source/modules/accessibility/AXLayoutObject.cpp:1648: AXObject::PlainTextRange
AXLayoutObject::selectedTextRange() const
I believe this function needs to be updated to handle contentEditable. There may
be some code there, maybe under ariaSelectedTextRange, but I don't think it's
complete and correct.

[blink-reviews, 2015-04-10 20:49:07]

PTAL

To unsubscribe from this group and stop receiving emails from it, send an email
to blink-reviews+unsubscribe@chromium.org.

[dmazzoni, 2015-04-10 21:23:25]

does this affect any tests? could you add at least one new test or a change to a
test as part of this change to demonstrate what works now that didn't before?

https://codereview.chromium.org/1056763002/diff/40001/Source/modules/accessib...
File Source/modules/accessibility/AXLayoutObject.cpp (right):

https://codereview.chromium.org/1056763002/diff/40001/Source/modules/accessib...
Source/modules/accessibility/AXLayoutObject.cpp:1593: if (isNativeTextControl()
&& m_layoutObject->isTextControl()) {
Is this redundant? Any reason this couldn't be just if
(m_layoutObject->isTextControl())?

https://codereview.chromium.org/1056763002/diff/40001/Source/modules/accessib...
File Source/modules/accessibility/AXObject.cpp (right):

https://codereview.chromium.org/1056763002/diff/40001/Source/modules/accessib...
Source/modules/accessibility/AXObject.cpp:456: // If you call
node->hasEditableStyle() since that will return true if an ancestor is editable.
Please fix this sentence while you're at it, it doesn't make sense.

https://codereview.chromium.org/1056763002/diff/40001/Source/modules/accessib...
File Source/modules/accessibility/AXObject.h (right):

https://codereview.chromium.org/1056763002/diff/40001/Source/modules/accessib...
Source/modules/accessibility/AXObject.h:412: bool
hasContentEditableAttributeSet() const;
Instead of moving hasContentEditableAttributeSet to AXObject, how about moving
the implementation of isTextControl to AXNodeObject?

There are some AXObjects that aren't nodes. Code that checks the attributes of
an HTML element should be in AXNodeObject or a subclass of that, not on
AXObject.

[blink-reviews, 2015-04-13 15:29:21]

All comments addressed.

To unsubscribe from this group and stop receiving emails from it, send an email
to blink-reviews+unsubscribe@chromium.org.

[dmazzoni, 2015-04-13 17:44:33]

lgtm

[nektarios, 2015-04-15 02:58:29]

The CQ bit was checked by nektar@chromium.org

[nektarios, 2015-04-15 02:58:29]

The patchset sent to the CQ was uploaded after l-g-t-m from
dmazzoni@chromium.org
Link to the patchset: https://codereview.chromium.org/1056763002/#ps180001
(title: "Fix test expectations.")

[commit-bot: I haz the power, 2015-04-15 02:58:41]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1056763002/180001

[commit-bot: I haz the power, 2015-04-15 07:29:48]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2015-04-15 07:29:49]

Try jobs failed on following builders:
  linux_blink_rel on tryserver.blink (JOB_FAILED,
http://build.chromium.org/p/tryserver.blink/builders/linux_blink_rel/builds/5...)

[nektarios, 2015-04-15 15:32:37]

The CQ bit was checked by nektar@chromium.org

[nektarios, 2015-04-15 15:32:38]

The patchset sent to the CQ was uploaded after l-g-t-m from
dmazzoni@chromium.org
Link to the patchset: https://codereview.chromium.org/1056763002/#ps200001
(title: "Copy pasted expectation file from test output in order to remove extra
blank line.")

[commit-bot: I haz the power, 2015-04-15 15:33:54]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1056763002/200001

[commit-bot: I haz the power, 2015-04-15 16:51:49]

Committed patchset #11 (id:200001) as
https://src.chromium.org/viewvc/blink?view=rev&revision=193803

[dcheng, 2015-04-15 22:43:15]

A revert of this CL (patchset #11 id:200001) has been created in
https://codereview.chromium.org/1086253002/ by dcheng@chromium.org.

The reason for reverting is: This is probably blocking the Blink roll..

[dcheng, 2015-04-15 22:45:39]

dcheng@chromium.org changed reviewers:
+ dcheng@chromium.org

[dcheng, 2015-04-15 22:45:40]

Failing test: content_browsertests
--gtest_filter=DumpAccessibilityTreeTest.AccessibilityContenteditableDescendants

Sample log:
https://build.chromium.org/p/chromium.webkit/builders/Mac10.8%20Tests/builds/...

[nektarios, 2015-04-16 00:27:57]

The CQ bit was checked by nektar@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2015-04-16 00:28:21]

Dry run: CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1056763002/200001

[commit-bot: I haz the power, 2015-04-16 00:29:06]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2015-04-16 00:29:07]

This issue passed the CQ dry run.

[nektarios, 2015-04-16 16:26:10]

The CQ bit was checked by nektar@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2015-04-16 16:26:27]

Dry run: CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1056763002/200001

[commit-bot: I haz the power, 2015-04-16 16:29:37]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2015-04-16 16:29:38]

Dry run: This issue passed the CQ dry run.

[nektarios, 2015-04-16 16:41:56]

The CQ bit was unchecked by nektar@chromium.org

[nektarios, 2015-04-16 16:42:14]

The CQ bit was checked by nektar@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2015-04-16 16:42:27]

Dry run: CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1056763002/200001

[commit-bot: I haz the power, 2015-04-16 16:42:41]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2015-04-16 16:42:42]

Dry run: This issue passed the CQ dry run.

[nektarios, 2015-04-16 20:36:31]

The CQ bit was checked by nektar@chromium.org

[nektarios, 2015-04-16 20:36:31]

The patchset sent to the CQ was uploaded after l-g-t-m from
dmazzoni@chromium.org
Link to the patchset: https://codereview.chromium.org/1056763002/#ps220001
(title: "Rebased on master.")

[nektarios, 2015-04-16 20:36:54]

The CQ bit was unchecked by nektar@chromium.org

[nektarios, 2015-04-16 21:14:31]

The CQ bit was checked by nektar@chromium.org

[nektarios, 2015-04-16 21:14:32]

The patchset sent to the CQ was uploaded after l-g-t-m from
dmazzoni@chromium.org
Link to the patchset: https://codereview.chromium.org/1056763002/#ps240001
(title: "Merged with master.")

[commit-bot: I haz the power, 2015-04-16 21:15:11]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1056763002/240001

[nektarios, 2015-04-16 21:25:57]

The CQ bit was unchecked by nektar@chromium.org

[nektarios, 2015-04-16 23:33:46]

The CQ bit was checked by nektar@chromium.org

[commit-bot: I haz the power, 2015-04-16 23:34:20]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1056763002/240001

[commit-bot: I haz the power, 2015-04-16 23:35:26]

Committed patchset #13 (id:240001) as
https://src.chromium.org/viewvc/blink?view=rev&revision=193910