Source/modules/accessibility/AXLayoutObject.h - Issue 1056763002: Reland: Made content editables report the caret and text selection by treating them as text controls

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: Source/modules/accessibility/AXLayoutObject.h

Issue 1056763002: Reland: Made content editables report the caret and text selection by treating them as text controls (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master

Patch Set: Merged with master. Created 5 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « LayoutTests/accessibility/editable-selected-range-expected.txt ('k') | Source/modules/accessibility/AXLayoutObject.cpp » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: Source/modules/accessibility/AXLayoutObject.h

diff --git a/Source/modules/accessibility/AXLayoutObject.h b/Source/modules/accessibility/AXLayoutObject.h

index 0bd69fbd2966735dba0c9aeae08af27b3a66cd8c..0c39e8585df1a2288a77d5908f2dd7129c9178b6 100644

--- a/Source/modules/accessibility/AXLayoutObject.h

+++ b/Source/modules/accessibility/AXLayoutObject.h

@@ -195,7 +195,7 @@ protected:

private:

bool isAllowedChildOfTree() const;

void ariaListboxSelectedChildren(AccessibilityChildrenVector&);

- PlainTextRange ariaSelectedTextRange() const;

+ PlainTextRange visibleSelectionUnderObject() const;

bool nodeIsTextControl(const Node*) const;

bool isTabItemSelected() const;

AXObject* accessibilityImageMapHitTest(HTMLAreaElement*, const IntPoint&) const;

« no previous file with comments | « LayoutTests/accessibility/editable-selected-range-expected.txt ('k') | Source/modules/accessibility/AXLayoutObject.cpp » ('j') | no next file with comments »