Source/modules/accessibility/AXObject.cpp - Issue 1056763002: Reland: Made content editables report the caret and text selection by treating them as text controls

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: Source/modules/accessibility/AXObject.cpp

Issue 1056763002: Reland: Made content editables report the caret and text selection by treating them as text controls (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master

Patch Set: Merged with master. Created 5 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: Source/modules/accessibility/AXObject.cpp

diff --git a/Source/modules/accessibility/AXObject.cpp b/Source/modules/accessibility/AXObject.cpp

index e05a796356d47388e2b9ba1dfd4e4a83316fcee2..819a449dabf12351bb48553f110d71c5ed3689e0 100644

--- a/Source/modules/accessibility/AXObject.cpp

+++ b/Source/modules/accessibility/AXObject.cpp

@@ -453,18 +453,6 @@ bool AXObject::isPasswordFieldAndShouldHideValue() const

return isPasswordField();

}

-bool AXObject::isTextControl() const

- switch (roleValue()) {

- case TextFieldRole:

- case ComboBoxRole:

- case SearchBoxRole:

- return true;

- default:

- return false;

- }

bool AXObject::isClickable() const

{

switch (roleValue()) {

« no previous file with comments | « Source/modules/accessibility/AXObject.h ('k') | no next file » | no next file with comments »