Issue 1086253002: Revert of Made content editables report the caret and text selection by treating them as text controls.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 1086253002: Revert of Made content editables report the caret and text selection by treating them as text controls. (Closed)

Created:
5 years, 8 months ago by dcheng

Modified:
5 years, 8 months ago

Reviewers:
nektarios, dmazzoni

CC:
blink-reviews, nektarios, dmazzoni, je_julie(Not used), aboxhall

Base URL:
https://chromium.googlesource.com/chromium/blink.git@master

Target Ref:
refs/heads/master

Project:
blink

Visibility:
Public.

Revert of Made content editables report the caret and text selection by treating them as text controls. (patchset #11 id:200001 of https://codereview.chromium.org/1056763002/) Reason for revert: This is probably blocking the Blink roll. Original issue's description: > Made content editables report the caret and text selection by treating them as text controls. > > BUG=347859 > R=dmazzoni > > Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=193803 TBR=dmazzoni@chromium.org,nektar@chromium.org NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=347859 Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=193829

Created: 5 years, 8 months ago

(Patch set is too large to download)

	Unified diffs	Side-by-side diffs	Stats (+28 lines, -153 lines)			Patch
D	LayoutTests/accessibility/contenteditable-caret-position.html	View	1 chunk	+0 lines, -90 lines	0 comments	Download
D	LayoutTests/accessibility/contenteditable-caret-position-expected.txt	View	1 chunk	+0 lines, -32 lines	0 comments	Download
M	Source/modules/accessibility/AXLayoutObject.h	View	1 chunk	+1 line, -1 line	0 comments	Download
M	Source/modules/accessibility/AXLayoutObject.cpp	View	6 chunks	+11 lines, -9 lines	0 comments	Download
M	Source/modules/accessibility/AXNodeObject.h	View	1 chunk	+0 lines, -2 lines	0 comments	Download
M	Source/modules/accessibility/AXNodeObject.cpp	View	2 chunks	+2 lines, -18 lines	0 comments	Download
M	Source/modules/accessibility/AXObject.h	View	2 chunks	+2 lines, -1 line	0 comments	Download
M	Source/modules/accessibility/AXObject.cpp	View	1 chunk	+12 lines, -0 lines	0 comments	Download

Total messages: 1 (0 generated)

dcheng

5 years, 8 months ago (2015-04-15 22:43:15 UTC) #1

Created Revert of Made content editables report the caret and text selection by
treating them as text controls.