Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(594)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 105523006: Revert 241151 "Make RenderFrameHostManager swap RenderFrameHosts..." (Closed)

Created:
7 years ago by tzik
Modified:
7 years ago
Reviewers:
Charlie Reis
CC:
chromium-reviews
Visibility:
Public.

Description

Revert 241151 "Make RenderFrameHostManager swap RenderFrameHosts..." r241151 seems to break content_unittests and browser_tests on Chrome OS ASAN bot: http://build.chromium.org/p/chromium.memory/builders/Linux%20Chromium%20OS%20ASAN%20Tests%20%283%29/builds/12154 > Make RenderFrameHostManager swap RenderFrameHosts, not RenderViewHosts. > > We still only have a RFHM for the main frame and not subframes, unless > the --site-per-process flag is passed. To external callers, RFHM is > still effectively swapping RenderViewHosts. > > RenderFrameHosts now indirectly keep their RenderViewHosts alive. > > BUG=314791 > TEST=No visible behavior change. > > Review URL: https://codereview.chromium.org/106963004 TBR=creis@chromium.org Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=241159

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+681 lines, -942 lines) Patch
M trunk/src/chrome/renderer/safe_browsing/phishing_classifier_browsertest.cc View 2 chunks +1 line, -8 lines 0 comments Download
M trunk/src/chrome/renderer/safe_browsing/phishing_classifier_delegate_browsertest.cc View 3 chunks +2 lines, -8 lines 0 comments Download
M trunk/src/chrome/renderer/safe_browsing/phishing_dom_feature_extractor_browsertest.cc View 3 chunks +3 lines, -11 lines 0 comments Download
M trunk/src/content/browser/frame_host/frame_tree.h View 5 chunks +16 lines, -39 lines 0 comments Download
M trunk/src/content/browser/frame_host/frame_tree.cc View 6 chunks +31 lines, -81 lines 0 comments Download
M trunk/src/content/browser/frame_host/frame_tree_node.h View 5 chunks +42 lines, -21 lines 0 comments Download
M trunk/src/content/browser/frame_host/frame_tree_node.cc View 3 chunks +14 lines, -24 lines 0 comments Download
M trunk/src/content/browser/frame_host/frame_tree_unittest.cc View 5 chunks +67 lines, -35 lines 0 comments Download
M trunk/src/content/browser/frame_host/interstitial_page_impl.h View 2 chunks +2 lines, -4 lines 0 comments Download
M trunk/src/content/browser/frame_host/interstitial_page_impl.cc View 5 chunks +18 lines, -14 lines 0 comments Download
M trunk/src/content/browser/frame_host/render_frame_host_impl.h View 1 chunk +2 lines, -7 lines 0 comments Download
M trunk/src/content/browser/frame_host/render_frame_host_impl.cc View 2 chunks +0 lines, -5 lines 0 comments Download
M trunk/src/content/browser/frame_host/render_frame_host_manager.h View 9 chunks +44 lines, -82 lines 0 comments Download
M trunk/src/content/browser/frame_host/render_frame_host_manager.cc View 31 chunks +235 lines, -367 lines 0 comments Download
M trunk/src/content/browser/frame_host/render_frame_host_manager_unittest.cc View 26 chunks +112 lines, -138 lines 0 comments Download
M trunk/src/content/browser/renderer_host/DEPS View 1 chunk +2 lines, -0 lines 0 comments Download
M trunk/src/content/browser/renderer_host/media/web_contents_video_capture_device_unittest.cc View 2 chunks +8 lines, -5 lines 0 comments Download
M trunk/src/content/browser/renderer_host/render_view_host_browsertest.cc View 2 chunks +8 lines, -9 lines 0 comments Download
M trunk/src/content/browser/renderer_host/render_view_host_factory.h View 2 chunks +2 lines, -0 lines 0 comments Download
M trunk/src/content/browser/renderer_host/render_view_host_factory.cc View 1 chunk +6 lines, -4 lines 0 comments Download
M trunk/src/content/browser/renderer_host/render_view_host_impl.h View 6 chunks +20 lines, -4 lines 0 comments Download
M trunk/src/content/browser/renderer_host/render_view_host_impl.cc View 8 chunks +16 lines, -4 lines 0 comments Download
M trunk/src/content/browser/renderer_host/render_view_host_unittest.cc View 2 chunks +4 lines, -5 lines 0 comments Download
M trunk/src/content/browser/web_contents/web_contents_impl.cc View 4 chunks +7 lines, -12 lines 0 comments Download
M trunk/src/content/browser/web_contents/web_contents_impl_unittest.cc View 7 chunks +7 lines, -13 lines 0 comments Download
M trunk/src/content/renderer/dom_serializer_browsertest.cc View 2 chunks +1 line, -8 lines 0 comments Download
M trunk/src/content/renderer/resource_fetcher_browsertest.cc View 2 chunks +1 line, -8 lines 0 comments Download
M trunk/src/content/test/test_render_frame_host.cc View 2 chunks +1 line, -10 lines 0 comments Download
M trunk/src/content/test/test_render_view_host.h View 4 chunks +1 line, -11 lines 0 comments Download
M trunk/src/content/test/test_render_view_host.cc View 2 chunks +3 lines, -2 lines 0 comments Download
M trunk/src/content/test/test_render_view_host_factory.h View 1 chunk +1 line, -0 lines 0 comments Download
M trunk/src/content/test/test_render_view_host_factory.cc View 1 chunk +3 lines, -2 lines 0 comments Download
M trunk/src/content/test/test_web_contents.cc View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 3 (0 generated)
tzik
7 years ago (2013-12-17 06:27:05 UTC) #1
tzik
Committed patchset #1 manually as r241159.
7 years ago (2013-12-17 06:27:42 UTC) #2
tzik
7 years ago (2013-12-17 06:30:09 UTC) #3
Message was sent while issue was closed. 
On 2013/12/17 06:27:42, tzik wrote:
> Committed patchset #1 manually as r241159.

Sorry, the build log link is broken.
The correct URL is:
http://build.chromium.org/p/chromium.memory/builders/Linux%20Chromium%20OS%20...

Powered by Google App Engine
This is Rietveld 408576698