Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(80)

Side by Side Diff: trunk/src/content/browser/frame_host/frame_tree_node.cc

Issue 105523006: Revert 241151 "Make RenderFrameHostManager swap RenderFrameHosts..." (Closed) Base URL: svn://svn.chromium.org/chrome/
Patch Set: Created 7 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
OLDNEW
1 // Copyright 2013 The Chromium Authors. All rights reserved. 1 // Copyright 2013 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "content/browser/frame_host/frame_tree_node.h" 5 #include "content/browser/frame_host/frame_tree_node.h"
6 6
7 #include <queue> 7 #include <queue>
8 8
9 #include "base/stl_util.h" 9 #include "base/stl_util.h"
10 #include "content/browser/frame_host/frame_tree.h"
11 #include "content/browser/frame_host/navigator.h" 10 #include "content/browser/frame_host/navigator.h"
12 #include "content/browser/frame_host/render_frame_host_impl.h" 11 #include "content/browser/frame_host/render_frame_host_impl.h"
13 #include "content/browser/renderer_host/render_view_host_impl.h"
14 12
15 namespace content { 13 namespace content {
16 14
17 const int64 FrameTreeNode::kInvalidFrameId = -1; 15 const int64 FrameTreeNode::kInvalidFrameId = -1;
18 int64 FrameTreeNode::next_frame_tree_node_id_ = 1; 16 int64 FrameTreeNode::next_frame_tree_node_id_ = 1;
19 17
20 FrameTreeNode::FrameTreeNode(FrameTree* frame_tree, 18 FrameTreeNode::FrameTreeNode(Navigator* navigator,
21 Navigator* navigator,
22 RenderFrameHostDelegate* render_frame_delegate, 19 RenderFrameHostDelegate* render_frame_delegate,
23 RenderViewHostDelegate* render_view_delegate, 20 RenderViewHostDelegate* render_view_delegate,
24 RenderWidgetHostDelegate* render_widget_delegate, 21 RenderWidgetHostDelegate* render_widget_delegate,
25 RenderFrameHostManager::Delegate* manager_delegate, 22 RenderFrameHostManager::Delegate* manager_delegate,
26 int64 frame_id, 23 int64 frame_id,
27 const std::string& name) 24 const std::string& name)
28 : frame_tree_(frame_tree), 25 : navigator_(navigator),
29 navigator_(navigator), 26 render_manager_(render_frame_delegate,
30 render_manager_(this,
31 render_frame_delegate,
32 render_view_delegate, 27 render_view_delegate,
33 render_widget_delegate, 28 render_widget_delegate,
34 manager_delegate), 29 manager_delegate),
35 frame_tree_node_id_(next_frame_tree_node_id_++), 30 frame_tree_node_id_(next_frame_tree_node_id_++),
36 frame_id_(frame_id), 31 frame_id_(frame_id),
37 frame_name_(name) { 32 frame_name_(name),
33 owns_render_frame_host_(true),
34 render_frame_host_(NULL) {
38 } 35 }
39 36
40 FrameTreeNode::~FrameTreeNode() { 37 FrameTreeNode::~FrameTreeNode() {
38 if (owns_render_frame_host_)
39 delete render_frame_host_;
41 } 40 }
42 41
43 bool FrameTreeNode::IsMainFrame() const { 42 void FrameTreeNode::AddChild(scoped_ptr<FrameTreeNode> child) {
44 return frame_tree_->root() == this;
45 }
46
47 void FrameTreeNode::AddChild(scoped_ptr<FrameTreeNode> child,
48 int frame_routing_id) {
49 // Initialize the RenderFrameHost for the new node. We always create child
50 // frames in the same SiteInstance as the current frame, and they can swap to
51 // a different one if they navigate away.
52 child->render_manager()->Init(
53 render_manager_.current_host()->GetSiteInstance()->GetBrowserContext(),
54 render_manager_.current_host()->GetSiteInstance(),
55 render_manager_.current_host()->GetRoutingID(),
56 frame_routing_id);
57 children_.push_back(child.release()); 43 children_.push_back(child.release());
58 } 44 }
59 45
60 void FrameTreeNode::RemoveChild(FrameTreeNode* child) { 46 void FrameTreeNode::RemoveChild(FrameTreeNode* child) {
61 std::vector<FrameTreeNode*>::iterator iter; 47 std::vector<FrameTreeNode*>::iterator iter;
62 48
63 for (iter = children_.begin(); iter != children_.end(); ++iter) { 49 for (iter = children_.begin(); iter != children_.end(); ++iter) {
64 if ((*iter) == child) 50 if ((*iter) == child)
65 break; 51 break;
66 } 52 }
67 53
68 if (iter != children_.end()) 54 if (iter != children_.end())
69 children_.erase(iter); 55 children_.erase(iter);
70 } 56 }
71 57
72 void FrameTreeNode::ResetForMainFrameSwap() { 58 void FrameTreeNode::ResetForMainFrame(
59 RenderFrameHostImpl* new_render_frame_host) {
60 owns_render_frame_host_ = false;
73 frame_id_ = kInvalidFrameId; 61 frame_id_ = kInvalidFrameId;
74 current_url_ = GURL(); 62 current_url_ = GURL();
75 63
76 // The children may not have been cleared if a cross-process navigation 64 // The children may not have been cleared if a cross-process navigation
77 // commits before the old process cleans everything up. Make sure the child 65 // commits before the old process cleans everything up. Make sure the child
78 // nodes get deleted. 66 // nodes get deleted.
79 children_.clear(); 67 children_.clear();
68
69 render_frame_host_ = new_render_frame_host;
80 } 70 }
81 71
82 } // namespace content 72 } // namespace content
OLDNEW
« no previous file with comments | « trunk/src/content/browser/frame_host/frame_tree_node.h ('k') | trunk/src/content/browser/frame_host/frame_tree_unittest.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698