Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(6)

Unified Diff: trunk/src/content/browser/renderer_host/render_view_host_browsertest.cc

Issue 105523006: Revert 241151 "Make RenderFrameHostManager swap RenderFrameHosts..." (Closed) Base URL: svn://svn.chromium.org/chrome/
Patch Set: Created 7 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: trunk/src/content/browser/renderer_host/render_view_host_browsertest.cc
===================================================================
--- trunk/src/content/browser/renderer_host/render_view_host_browsertest.cc (revision 241158)
+++ trunk/src/content/browser/renderer_host/render_view_host_browsertest.cc (working copy)
@@ -6,7 +6,6 @@
#include "base/strings/utf_string_conversions.h"
#include "base/time/time.h"
#include "base/values.h"
-#include "content/browser/frame_host/render_frame_host_impl.h"
#include "content/browser/renderer_host/render_view_host_impl.h"
#include "content/browser/web_contents/web_contents_impl.h"
#include "content/common/view_messages.h"
@@ -101,19 +100,19 @@
GURL test_url = embedded_test_server()->GetURL("/simple_page.html");
NavigateToURL(shell(), test_url);
- FrameTreeNode* old_root = static_cast<WebContentsImpl*>(
- shell()->web_contents())->GetFrameTree()->root();
- EXPECT_TRUE(old_root->current_frame_host());
+ RenderViewHostImpl* rvh = static_cast<RenderViewHostImpl*>(
+ shell()->web_contents()->GetRenderViewHost());
+ EXPECT_TRUE(rvh->main_render_frame_host());
ShellAddedObserver new_shell_observer;
EXPECT_TRUE(ExecuteScript(shell()->web_contents(), "window.open();"));
Shell* new_shell = new_shell_observer.GetShell();
- FrameTreeNode* new_root = static_cast<WebContentsImpl*>(
- new_shell->web_contents())->GetFrameTree()->root();
+ RenderViewHostImpl* new_rvh = static_cast<RenderViewHostImpl*>(
+ new_shell->web_contents()->GetRenderViewHost());
- EXPECT_TRUE(new_root->current_frame_host());
- EXPECT_NE(old_root->current_frame_host()->routing_id(),
- new_root->current_frame_host()->routing_id());
+ EXPECT_TRUE(new_rvh->main_render_frame_host());
+ EXPECT_NE(rvh->main_render_frame_host()->routing_id(),
+ new_rvh->main_render_frame_host()->routing_id());
}
} // namespace content

Powered by Google App Engine
This is Rietveld 408576698