Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(391)

Unified Diff: trunk/src/content/browser/frame_host/interstitial_page_impl.h

Issue 105523006: Revert 241151 "Make RenderFrameHostManager swap RenderFrameHosts..." (Closed) Base URL: svn://svn.chromium.org/chrome/
Patch Set: Created 7 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: trunk/src/content/browser/frame_host/interstitial_page_impl.h
===================================================================
--- trunk/src/content/browser/frame_host/interstitial_page_impl.h (revision 241158)
+++ trunk/src/content/browser/frame_host/interstitial_page_impl.h (working copy)
@@ -180,8 +180,8 @@
// - any command sent by the RenderViewHost will be ignored.
void Disable();
- // Delete ourselves, causing Shutdown on the RVH to be called.
- void Shutdown();
+ // Shutdown the RVH. We will be deleted by the time this method returns.
+ void Shutdown(RenderViewHostImpl* render_view_host);
void OnNavigatingAwayOrTabClosing();
@@ -229,8 +229,6 @@
// The RenderViewHost displaying the interstitial contents. This is valid
// until Hide is called, at which point it will be set to NULL, signifying
// that shutdown has started.
- // TODO(creis): This is now owned by the FrameTree. We should route things
- // through the tree's root RenderFrameHost instead.
RenderViewHostImpl* render_view_host_;
// The frame tree structure of the current page.

Powered by Google App Engine
This is Rietveld 408576698