Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(382)

Unified Diff: trunk/src/content/browser/web_contents/web_contents_impl.cc

Issue 105523006: Revert 241151 "Make RenderFrameHostManager swap RenderFrameHosts..." (Closed) Base URL: svn://svn.chromium.org/chrome/
Patch Set: Created 7 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: trunk/src/content/browser/web_contents/web_contents_impl.cc
===================================================================
--- trunk/src/content/browser/web_contents/web_contents_impl.cc (revision 241158)
+++ trunk/src/content/browser/web_contents/web_contents_impl.cc (working copy)
@@ -631,7 +631,7 @@
}
RenderFrameHost* WebContentsImpl::GetMainFrame() {
- return frame_tree_.root()->current_frame_host();
+ return frame_tree_.root()->render_frame_host();
}
RenderViewHost* WebContentsImpl::GetRenderViewHost() const {
@@ -3032,13 +3032,8 @@
const PageState& page_state) {
// Ensure that this state update comes from either the active RVH or one of
// the swapped out RVHs. We don't expect to hear from any other RVHs.
- // TODO(nasko): This should go through RenderFrameHost.
- // TODO(creis): We can't update state for cross-process subframes until we
- // have FrameNavigationEntries. Once we do, this should be a DCHECK.
- if (rvh != GetRenderViewHost() &&
- !GetRenderManager()->IsRVHOnSwappedOutList(
- static_cast<RenderViewHostImpl*>(rvh)))
- return;
+ DCHECK(rvh == GetRenderViewHost() ||
+ GetRenderManager()->IsOnSwappedOutList(rvh));
// We must be prepared to handle state updates for any page, these occur
// when the user is scrolling and entering form data, as well as when we're
@@ -3465,8 +3460,8 @@
int WebContentsImpl::CreateSwappedOutRenderView(
SiteInstance* instance) {
- return GetRenderManager()->CreateRenderFrame(instance, MSG_ROUTING_NONE,
- true, true);
+ return GetRenderManager()->CreateRenderView(instance, MSG_ROUTING_NONE,
+ true, true);
}
void WebContentsImpl::OnUserGesture() {
@@ -3635,8 +3630,8 @@
// Create a swapped out RenderView in the given SiteInstance if none exists,
// setting its opener to the given route_id. Return the new view's route_id.
- return GetRenderManager()->CreateRenderFrame(instance, opener_route_id,
- true, true);
+ return GetRenderManager()->CreateRenderView(instance, opener_route_id,
+ true, true);
}
NavigationControllerImpl& WebContentsImpl::GetControllerForRenderManager() {

Powered by Google App Engine
This is Rietveld 408576698