Add BUILD.gn files for chromecast/media

Add BUILD.gn files for chromecast/media
Set default chromecast args in chromecast/args.gn

BUG=

Committed: https://crrev.com/4025129eb8db73777a99731cae1aef839933b366
Cr-Commit-Position: refs/heads/master@{#326133}

[prashantv, 2015-04-20 23:47:11]

Patchset #1 (id:1) has been deleted

[prashantv, 2015-04-21 01:19:43]

Patchset #1 (id:20001) has been deleted

[prashantv, 2015-04-21 01:20:11]

prashantv@chromium.org changed reviewers:
+ gunsch@chromium.org

[gunsch, 2015-04-21 02:09:14]

gunsch@chromium.org changed reviewers:
+ brettw@chromium.org

[gunsch, 2015-04-21 02:09:43]

+brettw to comment on initial GN setup.

Thanks for doing this! It looks pretty good overall. Pile of mostly small
comments.

https://codereview.chromium.org/1055173005/diff/40001/build/config/features.gni
File build/config/features.gni (right):

https://codereview.chromium.org/1055173005/diff/40001/build/config/features.g...
build/config/features.gni:86: enable_browser_cdms = is_android
is this not available for overriding without moving it into this block?

https://codereview.chromium.org/1055173005/diff/40001/chromecast/BUILD.gn
File chromecast/BUILD.gn (right):

https://codereview.chromium.org/1055173005/diff/40001/chromecast/BUILD.gn#new...
chromecast/BUILD.gn:7: # TODO(gyp) propagate this to webkit for chromecast
builds.
do defines propagate to all includers if they live in chromecast.gni?

https://codereview.chromium.org/1055173005/diff/40001/chromecast/BUILD.gn#new...
chromecast/BUILD.gn:15: # TODO(gyp): Figure out how to propagate config to
everything under chromecast.
what does this mean? do you mean that args you set don't apply to all GN files
under src/chromecast/, or something else?

https://codereview.chromium.org/1055173005/diff/40001/chromecast/args.gn
File chromecast/args.gn (right):

https://codereview.chromium.org/1055173005/diff/40001/chromecast/args.gn#newc...
chromecast/args.gn:1: # Build arguments for Chromecast.
Since this isn't actually a gn file itself, how about putting it into a script
like "chromecast/build/setup_gn_args.sh"

https://codereview.chromium.org/1055173005/diff/40001/chromecast/args.gn#newc...
chromecast/args.gn:12: # ozone_platform_cast = 1
Yes, but this isn't necessarily where they apply chromecast/args.gn.

https://codereview.chromium.org/1055173005/diff/40001/chromecast/args.gn#newc...
chromecast/args.gn:13: # disable_display: 0
doesn't need to be set explicitly, as long as it defaults to 0 in the .gni

https://codereview.chromium.org/1055173005/diff/40001/chromecast/args.gn#newc...
chromecast/args.gn:14: # enable_default_cast_graphics: 1
same comment as disable_display

https://codereview.chromium.org/1055173005/diff/40001/chromecast/args.gn#newc...
chromecast/args.gn:15: # ozone_platform_cast: 0
dupe to above

https://codereview.chromium.org/1055173005/diff/40001/chromecast/args.gn#newc...
chromecast/args.gn:16: # use_chromecast_Webui: 0
same comment as disable_display

https://codereview.chromium.org/1055173005/diff/40001/chromecast/base/BUILD.gn
File chromecast/base/BUILD.gn (right):

https://codereview.chromium.org/1055173005/diff/40001/chromecast/base/BUILD.g...
chromecast/base/BUILD.gn:1: # Copyright (c) 2015 The Chromium Authors. All
rights reserved.
this file and elsewhere: rm the (c)

https://codereview.chromium.org/1055173005/diff/40001/chromecast/media/base/B...
File chromecast/media/base/BUILD.gn (right):

https://codereview.chromium.org/1055173005/diff/40001/chromecast/media/base/B...
chromecast/media/base/BUILD.gn:4: import("//build/config/crypto.gni")
nit: blank line above

https://codereview.chromium.org/1055173005/diff/40001/chromecast/media/base/d...
File chromecast/media/base/decrypt_context.cc (right):

https://codereview.chromium.org/1055173005/diff/40001/chromecast/media/base/d...
chromecast/media/base/decrypt_context.cc:5: 
?

https://codereview.chromium.org/1055173005/diff/40001/chromecast/media/cdm/BU...
File chromecast/media/cdm/BUILD.gn (right):

https://codereview.chromium.org/1055173005/diff/40001/chromecast/media/cdm/BU...
chromecast/media/cdm/BUILD.gn:12: "//chromecast/media/base",
nit: alphabetize

https://codereview.chromium.org/1055173005/diff/40001/chromecast/media/cma/ba...
File chromecast/media/cma/backend/BUILD.gn (right):

https://codereview.chromium.org/1055173005/diff/40001/chromecast/media/cma/ba...
chromecast/media/cma/backend/BUILD.gn:29: "//chromecast/media/base",
nit: alphabetize (here and throughout CL)

https://codereview.chromium.org/1055173005/diff/40001/media/base/BUILD.gn
File media/base/BUILD.gn (right):

https://codereview.chromium.org/1055173005/diff/40001/media/base/BUILD.gn#new...
media/base/BUILD.gn:15: "//chromecast/*",
This is probably not correct. The "media" source set in media/BUILD.gn exports
media_base as "public_deps". Does it still build correctly if you just delete
all the //media/base references in the new Chromecast GN files?

[brettw, 2015-04-21 16:39:09]

Thanks!

I made several comments about components. It looks like the GYP build used
components for everything. Generally, this is not the optimal way since making
all of these intermediate shared libraries (when doing the component build) will
actually slow things down.

Usually we want bigger components and then use shared libraries for the smaller
things. This gets tricky in the GYP build, though due to the say static
libraries are linked. GN has the concept of a source_set which solves this

Looking briefly, I would keep the toplevel "chromecast" target as a component,
and convert everything else to a source_set, and see if it works. If it doesn,
this is likely the best way to structure the build.

https://codereview.chromium.org/1055173005/diff/40001/build/config/features.gni
File build/config/features.gni (right):

https://codereview.chromium.org/1055173005/diff/40001/build/config/features.g...
build/config/features.gni:86: enable_browser_cdms = is_android
On 2015/04/21 02:09:43, gunsch wrote:
> is this not available for overriding without moving it into this block?

Correct, the declare_args block marks those variables as overridable.

https://codereview.chromium.org/1055173005/diff/40001/chromecast/BUILD.gn
File chromecast/BUILD.gn (right):

https://codereview.chromium.org/1055173005/diff/40001/chromecast/BUILD.gn#new...
chromecast/BUILD.gn:4: import("//chromecast/chromecast.gni")
Blank line before this.

https://codereview.chromium.org/1055173005/diff/40001/chromecast/BUILD.gn#new...
chromecast/BUILD.gn:7: # TODO(gyp) propagate this to webkit for chromecast
builds.
On 2015/04/21 02:09:43, gunsch wrote:
> do defines propagate to all includers if they live in chromecast.gni?

These will get applied to all targets with this config applied. This is
generally done explicitly, which you can see in chromecast/media/base/BUILD.gn.

However, I suspect you'll also want to apply this to the other chromecast
targets, right?

https://codereview.chromium.org/1055173005/diff/40001/chromecast/BUILD.gn#new...
chromecast/BUILD.gn:15: # TODO(gyp): Figure out how to propagate config to
everything under chromecast.
On 2015/04/21 02:09:43, gunsch wrote:
> what does this mean? do you mean that args you set don't apply to all GN files
> under src/chromecast/, or something else?

See above, just apply the config to all the targets.

https://codereview.chromium.org/1055173005/diff/40001/chromecast/args.gn
File chromecast/args.gn (right):

https://codereview.chromium.org/1055173005/diff/40001/chromecast/args.gn#newc...
chromecast/args.gn:1: # Build arguments for Chromecast.
On 2015/04/21 02:09:43, gunsch wrote:
> Since this isn't actually a gn file itself, how about putting it into a script
> like "chromecast/build/setup_gn_args.sh"

Since the suggestion is that you copy and paste this, the file extension seems
appropriate. It's in GN format, and it's not a shell script.

https://codereview.chromium.org/1055173005/diff/40001/chromecast/base/BUILD.gn
File chromecast/base/BUILD.gn (right):

https://codereview.chromium.org/1055173005/diff/40001/chromecast/base/BUILD.g...
chromecast/base/BUILD.gn:5: component("base") {
I'm suspicious whether we actually want a full shared library for one .cc file
of a few paths. I would normally make this kind of thing a source_set. If
there's a good technical reason for the component, it's OK.

You'll want to apply the config with the defines in it.

https://codereview.chromium.org/1055173005/diff/40001/chromecast/base/metrics...
File chromecast/base/metrics/BUILD.gn (right):

https://codereview.chromium.org/1055173005/diff/40001/chromecast/base/metrics...
chromecast/base/metrics/BUILD.gn:6: sources = [
Apply the config to these targets.

Also: source_set instead of config unless it breaks for some reason.

https://codereview.chromium.org/1055173005/diff/40001/chromecast/chromecast.gni
File chromecast/chromecast.gni (right):

https://codereview.chromium.org/1055173005/diff/40001/chromecast/chromecast.g...
chromecast/chromecast.gni:1: declare_args() {
Copyright block.

https://codereview.chromium.org/1055173005/diff/40001/chromecast/chromecast.g...
chromecast/chromecast.gni:3: chromecast_branding = "Chromium"
You can choose how you want to do this. Since there are only two values we'll
ever have, I made the chrome branding one a boolean: is_chrome_branded. This
makes typos impossible and means you don't have hardcoded strings floating
around. So I would suggest (optional) is_chromecast_chrome_branded or something.

https://codereview.chromium.org/1055173005/diff/40001/chromecast/media/BUILD.gn
File chromecast/media/BUILD.gn (right):

https://codereview.chromium.org/1055173005/diff/40001/chromecast/media/BUILD....
chromecast/media/BUILD.gn:7: component("media") {
Make this a group unless you have a specific need for a shared library here. I
don't even know what this thing is in the GYP build, since it's a shared library
consisting of other shared libraries, which I think means it's nothing. In GN
"group" is a collection of other targets that doesn't actually produce any
output itself, which looks like what you want here.

https://codereview.chromium.org/1055173005/diff/40001/chromecast/media/BUILD....
chromecast/media/BUILD.gn:39: 
I would apply the config here.

https://codereview.chromium.org/1055173005/diff/40001/chromecast/media/cdm/BU...
File chromecast/media/cdm/BUILD.gn (right):

https://codereview.chromium.org/1055173005/diff/40001/chromecast/media/cdm/BU...
chromecast/media/cdm/BUILD.gn:5: component("cdm") {
Same component suggestion.

https://codereview.chromium.org/1055173005/diff/40001/chromecast/media/cma/BU...
File chromecast/media/cma/BUILD.gn (right):

https://codereview.chromium.org/1055173005/diff/40001/chromecast/media/cma/BU...
chromecast/media/cma/BUILD.gn:5: component("cma") {
group

[prashantv, 2015-04-21 18:15:02]

Patchset #2 (id:60001) has been deleted

[prashantv, 2015-04-21 18:18:00]

Patchset #2 (id:80001) has been deleted

[prashantv, 2015-04-21 18:21:21]

On 2015/04/21 16:39:09, brettw wrote:
> Thanks!
> 
> I made several comments about components. It looks like the GYP build used
> components for everything. Generally, this is not the optimal way since making
> all of these intermediate shared libraries (when doing the component build)
will
> actually slow things down.
> 
> Usually we want bigger components and then use shared libraries for the
smaller
> things. This gets tricky in the GYP build, though due to the say static
> libraries are linked. GN has the concept of a source_set which solves this
> 
> Looking briefly, I would keep the toplevel "chromecast" target as a component,
> and convert everything else to a source_set, and see if it works. If it doesn,
> this is likely the best way to structure the build.

Thanks for all the suggestions. I've updated the BUILD files to use source_set
and groups, except the top level chromecast target. This seems to work fine.

[prashantv, 2015-04-21 18:21:36]

https://codereview.chromium.org/1055173005/diff/40001/chromecast/BUILD.gn
File chromecast/BUILD.gn (right):

https://codereview.chromium.org/1055173005/diff/40001/chromecast/BUILD.gn#new...
chromecast/BUILD.gn:4: import("//chromecast/chromecast.gni")
On 2015/04/21 16:39:09, brettw wrote:
> Blank line before this.

Done.

https://codereview.chromium.org/1055173005/diff/40001/chromecast/BUILD.gn#new...
chromecast/BUILD.gn:7: # TODO(gyp) propagate this to webkit for chromecast
builds.
On 2015/04/21 16:39:09, brettw wrote:
> On 2015/04/21 02:09:43, gunsch wrote:
> > do defines propagate to all includers if they live in chromecast.gni?
> 
> These will get applied to all targets with this config applied. This is
> generally done explicitly, which you can see in
chromecast/media/base/BUILD.gn.
> 
> However, I suspect you'll also want to apply this to the other chromecast
> targets, right?

Yes, I was hoping to automatically propagate this to all targets under
chromecast. Is there any way to do that? For now, I'll add it to the targets
explicitly.

https://codereview.chromium.org/1055173005/diff/40001/chromecast/BUILD.gn#new...
chromecast/BUILD.gn:15: # TODO(gyp): Figure out how to propagate config to
everything under chromecast.
On 2015/04/21 16:39:09, brettw wrote:
> On 2015/04/21 02:09:43, gunsch wrote:
> > what does this mean? do you mean that args you set don't apply to all GN
files
> > under src/chromecast/, or something else?
> 
> See above, just apply the config to all the targets.

Done.

https://codereview.chromium.org/1055173005/diff/40001/chromecast/args.gn
File chromecast/args.gn (right):

https://codereview.chromium.org/1055173005/diff/40001/chromecast/args.gn#newc...
chromecast/args.gn:1: # Build arguments for Chromecast.
On 2015/04/21 16:39:09, brettw wrote:
> On 2015/04/21 02:09:43, gunsch wrote:
> > Since this isn't actually a gn file itself, how about putting it into a
script
> > like "chromecast/build/setup_gn_args.sh"
> 
> Since the suggestion is that you copy and paste this, the file extension seems
> appropriate. It's in GN format, and it's not a shell script.

I'm using args.gn since that's the actual filename for the file inside the out
folder. You can run gn args, and copy this file to the out directly, so figured
I should call it this.

https://codereview.chromium.org/1055173005/diff/40001/chromecast/args.gn#newc...
chromecast/args.gn:12: # ozone_platform_cast = 1
On 2015/04/21 02:09:43, gunsch wrote:
> Yes, but this isn't necessarily where they apply chromecast/args.gn.

Should I delete this for now from here then?

https://codereview.chromium.org/1055173005/diff/40001/chromecast/args.gn#newc...
chromecast/args.gn:13: # disable_display: 0
On 2015/04/21 02:09:43, gunsch wrote:
> doesn't need to be set explicitly, as long as it defaults to 0 in the .gni

Done.

https://codereview.chromium.org/1055173005/diff/40001/chromecast/args.gn#newc...
chromecast/args.gn:14: # enable_default_cast_graphics: 1
On 2015/04/21 02:09:43, gunsch wrote:
> same comment as disable_display

Done.

https://codereview.chromium.org/1055173005/diff/40001/chromecast/args.gn#newc...
chromecast/args.gn:15: # ozone_platform_cast: 0
On 2015/04/21 02:09:43, gunsch wrote:
> dupe to above

Done.

https://codereview.chromium.org/1055173005/diff/40001/chromecast/args.gn#newc...
chromecast/args.gn:16: # use_chromecast_Webui: 0
On 2015/04/21 02:09:43, gunsch wrote:
> same comment as disable_display

Done.

https://codereview.chromium.org/1055173005/diff/40001/chromecast/base/BUILD.gn
File chromecast/base/BUILD.gn (right):

https://codereview.chromium.org/1055173005/diff/40001/chromecast/base/BUILD.g...
chromecast/base/BUILD.gn:1: # Copyright (c) 2015 The Chromium Authors. All
rights reserved.
On 2015/04/21 02:09:43, gunsch wrote:
> this file and elsewhere: rm the (c)

Done.

https://codereview.chromium.org/1055173005/diff/40001/chromecast/base/BUILD.g...
chromecast/base/BUILD.gn:5: component("base") {
On 2015/04/21 16:39:09, brettw wrote:
> I'm suspicious whether we actually want a full shared library for one .cc file
> of a few paths. I would normally make this kind of thing a source_set. If
> there's a good technical reason for the component, it's OK.
> 
> You'll want to apply the config with the defines in it.

Done.

https://codereview.chromium.org/1055173005/diff/40001/chromecast/base/metrics...
File chromecast/base/metrics/BUILD.gn (right):

https://codereview.chromium.org/1055173005/diff/40001/chromecast/base/metrics...
chromecast/base/metrics/BUILD.gn:6: sources = [
On 2015/04/21 16:39:09, brettw wrote:
> Apply the config to these targets.
> 
> Also: source_set instead of config unless it breaks for some reason.

Done.

https://codereview.chromium.org/1055173005/diff/40001/chromecast/chromecast.gni
File chromecast/chromecast.gni (right):

https://codereview.chromium.org/1055173005/diff/40001/chromecast/chromecast.g...
chromecast/chromecast.gni:1: declare_args() {
On 2015/04/21 16:39:09, brettw wrote:
> Copyright block.

Done.

https://codereview.chromium.org/1055173005/diff/40001/chromecast/chromecast.g...
chromecast/chromecast.gni:3: chromecast_branding = "Chromium"
On 2015/04/21 16:39:09, brettw wrote:
> You can choose how you want to do this. Since there are only two values we'll
> ever have, I made the chrome branding one a boolean: is_chrome_branded. This
> makes typos impossible and means you don't have hardcoded strings floating
> around. So I would suggest (optional) is_chromecast_chrome_branded or
something.

Done.

https://codereview.chromium.org/1055173005/diff/40001/chromecast/media/BUILD.gn
File chromecast/media/BUILD.gn (right):

https://codereview.chromium.org/1055173005/diff/40001/chromecast/media/BUILD....
chromecast/media/BUILD.gn:7: component("media") {
On 2015/04/21 16:39:09, brettw wrote:
> Make this a group unless you have a specific need for a shared library here. I
> don't even know what this thing is in the GYP build, since it's a shared
library
> consisting of other shared libraries, which I think means it's nothing. In GN
> "group" is a collection of other targets that doesn't actually produce any
> output itself, which looks like what you want here.

Done.

https://codereview.chromium.org/1055173005/diff/40001/chromecast/media/BUILD....
chromecast/media/BUILD.gn:39: 
On 2015/04/21 16:39:09, brettw wrote:
> I would apply the config here.

Done.

https://codereview.chromium.org/1055173005/diff/40001/chromecast/media/base/B...
File chromecast/media/base/BUILD.gn (right):

https://codereview.chromium.org/1055173005/diff/40001/chromecast/media/base/B...
chromecast/media/base/BUILD.gn:4: import("//build/config/crypto.gni")
On 2015/04/21 02:09:43, gunsch wrote:
> nit: blank line above

Done.

https://codereview.chromium.org/1055173005/diff/40001/chromecast/media/base/d...
File chromecast/media/base/decrypt_context.cc (right):

https://codereview.chromium.org/1055173005/diff/40001/chromecast/media/base/d...
chromecast/media/base/decrypt_context.cc:5: 
On 2015/04/21 02:09:43, gunsch wrote:
> ?

reverted.

https://codereview.chromium.org/1055173005/diff/40001/chromecast/media/cdm/BU...
File chromecast/media/cdm/BUILD.gn (right):

https://codereview.chromium.org/1055173005/diff/40001/chromecast/media/cdm/BU...
chromecast/media/cdm/BUILD.gn:5: component("cdm") {
On 2015/04/21 16:39:09, brettw wrote:
> Same component suggestion.

Done.

https://codereview.chromium.org/1055173005/diff/40001/chromecast/media/cdm/BU...
chromecast/media/cdm/BUILD.gn:12: "//chromecast/media/base",
On 2015/04/21 02:09:43, gunsch wrote:
> nit: alphabetize

Done.

https://codereview.chromium.org/1055173005/diff/40001/chromecast/media/cma/BU...
File chromecast/media/cma/BUILD.gn (right):

https://codereview.chromium.org/1055173005/diff/40001/chromecast/media/cma/BU...
chromecast/media/cma/BUILD.gn:5: component("cma") {
On 2015/04/21 16:39:09, brettw wrote:
> group

Done.

https://codereview.chromium.org/1055173005/diff/40001/chromecast/media/cma/ba...
File chromecast/media/cma/backend/BUILD.gn (right):

https://codereview.chromium.org/1055173005/diff/40001/chromecast/media/cma/ba...
chromecast/media/cma/backend/BUILD.gn:29: "//chromecast/media/base",
On 2015/04/21 02:09:43, gunsch wrote:
> nit: alphabetize (here and throughout CL)

Done.

https://codereview.chromium.org/1055173005/diff/40001/media/base/BUILD.gn
File media/base/BUILD.gn (right):

https://codereview.chromium.org/1055173005/diff/40001/media/base/BUILD.gn#new...
media/base/BUILD.gn:15: "//chromecast/*",
On 2015/04/21 02:09:43, gunsch wrote:
> This is probably not correct. The "media" source set in media/BUILD.gn exports
> media_base as "public_deps". Does it still build correctly if you just delete
> all the //media/base references in the new Chromecast GN files?

Forgot to revert this after testing something for the browser CDM issue.
Reverted file.

[brettw, 2015-04-21 19:25:12]

lgtm

https://codereview.chromium.org/1055173005/diff/40001/chromecast/BUILD.gn
File chromecast/BUILD.gn (right):

https://codereview.chromium.org/1055173005/diff/40001/chromecast/BUILD.gn#new...
chromecast/BUILD.gn:7: # TODO(gyp) propagate this to webkit for chromecast
builds.
No. The closest you can get is to add a public_config on a target that
everything in here depends on. But it doesn't seem like you have that structure.
Also, the public_config thing will leak out into other non-chromecast targets
which you probably don't want in this case.

[gunsch, 2015-04-21 20:58:18]

Couple comments still but mostly lg.

https://codereview.chromium.org/1055173005/diff/40001/chromecast/BUILD.gn
File chromecast/BUILD.gn (right):

https://codereview.chromium.org/1055173005/diff/40001/chromecast/BUILD.gn#new...
chromecast/BUILD.gn:7: # TODO(gyp) propagate this to webkit for chromecast
builds.
On 2015/04/21 19:25:12, brettw wrote:
> No. The closest you can get is to add a public_config on a target that
> everything in here depends on. But it doesn't seem like you have that
structure.
> Also, the public_config thing will leak out into other non-chromecast targets
> which you probably don't want in this case.

Brett: we need to enable Blink logging in production Chromecast builds, which is
why we set LOG_DISABLED=0 in our build/common.gypi block. How would be most
appropriate to do an equivalent for GN? It looks like GYP at least has a
"blink_logging_always_on" GYP define that can be set, should we look into adding
a GN equivalent?

Prashant: we do want this define, but it's not really useful within chromecast/.
Can you remove it for now and add a TODO about this in chromecast/build/args.gn?

https://codereview.chromium.org/1055173005/diff/40001/chromecast/args.gn
File chromecast/args.gn (right):

https://codereview.chromium.org/1055173005/diff/40001/chromecast/args.gn#newc...
chromecast/args.gn:1: # Build arguments for Chromecast.
On 2015/04/21 18:21:35, prashantv wrote:
> On 2015/04/21 16:39:09, brettw wrote:
> > On 2015/04/21 02:09:43, gunsch wrote:
> > > Since this isn't actually a gn file itself, how about putting it into a
> script
> > > like "chromecast/build/setup_gn_args.sh"
> > 
> > Since the suggestion is that you copy and paste this, the file extension
seems
> > appropriate. It's in GN format, and it's not a shell script.
> 
> I'm using args.gn since that's the actual filename for the file inside the out
> folder. You can run gn args, and copy this file to the out directly, so
figured
> I should call it this.

OK, can you move to chromecast/build/args.gn though?

https://codereview.chromium.org/1055173005/diff/100001/chromecast/args.gn
File chromecast/args.gn (right):

https://codereview.chromium.org/1055173005/diff/100001/chromecast/args.gn#new...
chromecast/args.gn:11: # TODO: should we set these flags:
"TODO(halliwell): look into supporting Cast Ozone with GN."

https://codereview.chromium.org/1055173005/diff/100001/chromecast/chromecast.gni
File chromecast/chromecast.gni (right):

https://codereview.chromium.org/1055173005/diff/100001/chromecast/chromecast....
chromecast/chromecast.gni:9: use_playready = true
this should actually be "false" by default

[prashantv, 2015-04-21 21:20:17]

Moved chromecast args.gn to chromecast/build

https://codereview.chromium.org/1055173005/diff/100001/chromecast/args.gn
File chromecast/args.gn (right):

https://codereview.chromium.org/1055173005/diff/100001/chromecast/args.gn#new...
chromecast/args.gn:11: # TODO: should we set these flags:
On 2015/04/21 20:58:18, gunsch wrote:
> "TODO(halliwell): look into supporting Cast Ozone with GN."

Done.

https://codereview.chromium.org/1055173005/diff/100001/chromecast/chromecast.gni
File chromecast/chromecast.gni (right):

https://codereview.chromium.org/1055173005/diff/100001/chromecast/chromecast....
chromecast/chromecast.gni:9: use_playready = true
On 2015/04/21 20:58:18, gunsch wrote:
> this should actually be "false" by default

Done.

[gunsch, 2015-04-21 21:25:55]

lgtm. Thanks for kicking this off!

[prashantv, 2015-04-21 21:28:23]

The CQ bit was checked by prashantv@chromium.org

[prashantv, 2015-04-21 21:28:23]

The patchset sent to the CQ was uploaded after l-g-t-m from brettw@chromium.org
Link to the patchset: https://codereview.chromium.org/1055173005/#ps120001
(title: "moved args.gn")

[commit-bot: I haz the power, 2015-04-21 21:30:33]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1055173005/120001

[commit-bot: I haz the power, 2015-04-21 21:54:30]

Committed patchset #3 (id:120001)

[commit-bot: I haz the power, 2015-04-21 21:55:37]

Patchset 3 (id:??) landed as
https://crrev.com/4025129eb8db73777a99731cae1aef839933b366
Cr-Commit-Position: refs/heads/master@{#326133}